Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp5977017pxb; Mon, 14 Feb 2022 12:09:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/SISf6zNwCOuEVQfJMBLbDDYCthH6mJsaV5mKLcYs788+0ZDI5aZo54RGeTUWPPQzEAKD X-Received: by 2002:a17:902:76cb:: with SMTP id j11mr419545plt.85.1644869360397; Mon, 14 Feb 2022 12:09:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644869360; cv=none; d=google.com; s=arc-20160816; b=08TIjd9qIz2G0MWfccQhHHhqKldsnKl2LJtCoKgsH4G2CnuJSgSleZtcmTCGDv7DKd d9idbm/WQx+/HWwvyMdM5xEz8m/9vF28nI5pj9FUmbEjLxKkoRcM5wIsCsNYNWuRE/JK cp4nW8KFdWhrq3jEKBSjdiMXVKIj0MUQ+PMDWkVgkLRhh6PnCLIdxmcHM+LP6Iml0BJl ssumYv7fuwN/3uy7/7hVRy+KdWotKGubSFTh2CJbpCqQMLu30wL2GdaWsxThz/p0B/jC EJ4K6VKQnvBGYs2l+UL9cpPnGhLCwdwDEjn2P1QDgHTv4znk2+gu2nuoMe/EQAwzCHkU obnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pn6IR7IHkUusxfm6s7lTOCvOL9+Z8oCV5dqXSZ5RnGo=; b=ce/c15HoIpmbJy7XlyRiQAMV0y2MibrbMp+uOokP93/vPRMHwl9hG42IoQzTrYRRxy eA43E6dQLHho1Br/XylIKCNN1EU+Ia9S5y/7bW2voojmlRXEPet7Md5jT3mneoC2DygA nQ/Tpqw0jv1G9o150gzYi2UgqJjwnRUG7fwk7Uo++usV+8yZL6uqonob9agYXg5NpH8/ WlO36apoINyvZBj9XxffV46lqO3j6xPhWwt23oSvNFRKj6a0EXW3chldXnZGfNLJ2B29 VHRo+GzB+BB4Q4RHkCnPDunj48XlzQhrRUv/0BJYdvoAPoF9fcZEJBJVVjH28GdrHy2d U9oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MY+UITTG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q125si587412pgq.311.2022.02.14.12.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 12:09:20 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MY+UITTG; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4C4D79E9E4; Mon, 14 Feb 2022 11:46:31 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243404AbiBNJye (ORCPT + 99 others); Mon, 14 Feb 2022 04:54:34 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:33192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343951AbiBNJv1 (ORCPT ); Mon, 14 Feb 2022 04:51:27 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E742B76E2A; Mon, 14 Feb 2022 01:42:21 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D7C7B80D83; Mon, 14 Feb 2022 09:42:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7100C340E9; Mon, 14 Feb 2022 09:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644831739; bh=/DjVnQ7jgYXBQt/wqucYtc26jeqXAAs5ubdP37etpC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MY+UITTGPlqZlYlCLqEknJT2TAvytj5gYX3H3S9njYX0+56hT/4Y1iiF0ovCni9QC t/wg8HQqzMHFAUoqKL1AVrRyh2RRoMMRQr70stazek726oWV8QAMpb8UixUvuGNOl3 XDDkJc2C4MSLMQxT+fqO1j8t1+xq5XCT6bRxw9uc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Selwin Sebastian , Raju Rangoju , "David S. Miller" , Sasha Levin Subject: [PATCH 5.10 081/116] net: amd-xgbe: disable interrupts during pci removal Date: Mon, 14 Feb 2022 10:26:20 +0100 Message-Id: <20220214092501.567657409@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220214092458.668376521@linuxfoundation.org> References: <20220214092458.668376521@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Raju Rangoju [ Upstream commit 68c2d6af1f1e469544d6cbe9a601d96fb9c00e7f ] Hardware interrupts are enabled during the pci probe, however, they are not disabled during pci removal. Disable all hardware interrupts during pci removal to avoid any issues. Fixes: e75377404726 ("amd-xgbe: Update PCI support to use new IRQ functions") Suggested-by: Selwin Sebastian Signed-off-by: Raju Rangoju Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c index 90cb55eb54665..014513ce00a14 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c @@ -418,6 +418,9 @@ static void xgbe_pci_remove(struct pci_dev *pdev) pci_free_irq_vectors(pdata->pcidev); + /* Disable all interrupts in the hardware */ + XP_IOWRITE(pdata, XP_INT_EN, 0x0); + xgbe_free_pdata(pdata); } -- 2.34.1