Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220214090020.89984-1-yang.lee@linux.alibaba.com>
In-Reply-To: <20220214090020.89984-1-yang.lee@linux.alibaba.com>
From:   =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>
Date:   Mon, 14 Feb 2022 13:22:48 +0100
Message-ID: <CAOtMz3O5ygQQDU_WNNdJGW4+6Vi02zDebhWLic9Sm7UGSpFyVQ@mail.gmail.com>
Subject: Re: [PATCH -next v2] i2c: designware: remove unneeded semicolon
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

pon., 14 lut 2022 o 10:00 Yang Li <yang.lee@linux.alibaba.com> napisa=C5=82=
(a):
>
> Eliminate the following coccicheck warning:

nit: warnings

> ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolon
> ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

Beside a nit above:
Reviewed-by: Jan Dabros <jsd@semihalf.com>

Best Regards,
Jan

> ---
>
> --Changes in v2:
>   According to Jan's suggestion
>   Fix the same problem in check_i2c_req_sts() function.
>
>  drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-amdpsp.c b/drivers/i2c/bus=
ses/i2c-designware-amdpsp.c
> index 752e0024db03..9d37becbd846 100644
> --- a/drivers/i2c/busses/i2c-designware-amdpsp.c
> +++ b/drivers/i2c/busses/i2c-designware-amdpsp.c
> @@ -172,7 +172,7 @@ static int check_i2c_req_sts(struct psp_i2c_req *req)
>         case PSP_I2C_REQ_STS_INV_PARAM:
>         default:
>                 return -EIO;
> -       };
> +       }
>  }
>
>  static int psp_send_check_i2c_req(struct psp_i2c_req *req)
> @@ -245,7 +245,7 @@ static int psp_acquire_i2c_bus(void)
>         if (psp_i2c_access_count) {
>                 psp_i2c_access_count++;
>                 goto cleanup;
> -       };
> +       }
>
>         status =3D psp_send_i2c_req(PSP_I2C_REQ_ACQUIRE);
>         if (status) {
> --
> 2.20.1.7.g153144c
>