Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220211193634.3183388-1-pgonda@google.com> <a3008754-86a8-88d6-df7f-a2770b0a2c93@redhat.com>
In-Reply-To: <a3008754-86a8-88d6-df7f-a2770b0a2c93@redhat.com>
From:   Peter Gonda <pgonda@google.com>
Date:   Mon, 14 Feb 2022 08:52:47 -0700
Message-ID: <CAMkAt6rLafSikpQEKkbbT8DW4OG_pDL63jPLtCFiO1NNtTRe+A@mail.gmail.com>
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors
To:     Paolo Bonzini <pbonzini@redhat.com>
Cc:     kvm list <kvm@vger.kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        Marc Orr <marcorr@google.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 14, 2022 at 5:57 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 2/11/22 20:36, Peter Gonda wrote:
> > +     list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
> > +     list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
> > +                              mirror_entry) {
>
> Is list_for_each_entry_safe actually necessary here?  (It would be if
> you used list_add/list_del instead of list_cut_before).

 I don't think so, I think we could use list_for_each_entry here. Do
you want me to send another revision?

>
> > +             kvm_get_kvm(dst_kvm);
> > +             kvm_put_kvm(src_kvm);
> > +             mirror->enc_context_owner = dst_kvm;
> > +     }
>
> Thanks,
>
> Paolo
>