Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220214124701.105814-1-yang.lee@linux.alibaba.com> <307ca790-e9ca-c8f3-e0f7-28ad594db2aa@linux.intel.com>
In-Reply-To: <307ca790-e9ca-c8f3-e0f7-28ad594db2aa@linux.intel.com>
From:   =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>
Date:   Mon, 14 Feb 2022 15:01:35 +0100
Message-ID: <CAOtMz3P0-y0NX8BM2SpEf3ZnaWO0nRfchRSv-nAJm51JJOn+Cw@mail.gmail.com>
Subject: Re: [PATCH -next v2 RESEND] i2c: designware: remove unneeded semicolon
To:     Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc:     Yang Li <yang.lee@linux.alibaba.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

pon., 14 lut 2022 o 14:03 Jarkko Nikula
<jarkko.nikula@linux.intel.com> napisa=C5=82(a):
>
> Hi
>
> On 2/14/22 14:47, Yang Li wrote:
> > Eliminate the following coccicheck warnings:
> > ./drivers/i2c/busses/i2c-designware-amdpsp.c:172:2-3: Unneeded semicolo=
n
> > ./drivers/i2c/busses/i2c-designware-amdpsp.c:245:2-3: Unneeded semicolo=
n
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> > ---
> >
> > --Changes in v2:
> >    According to Jan's suggestion
> >    Fix the same problem in check_i2c_req_sts() function.
> >
> >   drivers/i2c/busses/i2c-designware-amdpsp.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> For future contributions: Technically this would be v3 rather than v2
> RESEND since you fixed the typo in commit log noted by Jan for v2.
>
> Please use RESEND only if you'll send exactly the same version for
> instance if you didn't receive any comments for several weeks or some
> recipient was missing from Cc field.
>
> I believe Jan will give Reviewed-by tag to this version too.
>
> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

Correct.
Reviewed-by: Jan Dabros <jsd@semihalf.com>

Best Regards,
Jan