Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220212130410.6901-1-ojeda@kernel.org> <20220212130410.6901-13-ojeda@kernel.org>
 <YgosclY9ebD3t020@smile.fi.intel.com>
In-Reply-To: <YgosclY9ebD3t020@smile.fi.intel.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Mon, 14 Feb 2022 13:27:48 +0100
Message-ID: <CANiq72mwkSo-W3QcyMnQ-o1COA5YJt1Ab9Xti7cdG6Krz3Sj7w@mail.gmail.com>
Subject: Re: [PATCH v4 12/20] vsprintf: add new `%pA` format specifier
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        rust-for-linux <rust-for-linux@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Gary Guo <gary@garyguo.net>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@google.com>,
        Petr Mladek <pmladek@suse.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Andy,

On Mon, Feb 14, 2022 at 11:19 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Not sure I understand this...
>
> ...together with this in the current SoB chain.

From my reading of `Documentation/process/submitting-patches.rst`,
this is the case I have to use:

```
Example of a patch submitted by a Co-developed-by: author::

    From: From Author <from@author.example.org>

    <changelog>

    Co-developed-by: Random Co-Author <random@coauthor.example.org>
    Signed-off-by: Random Co-Author <random@coauthor.example.org>
    Signed-off-by: From Author <from@author.example.org>
    Co-developed-by: Submitting Co-Author <sub@coauthor.example.org>
    Signed-off-by: Submitting Co-Author <sub@coauthor.example.org>
```

Do you think another case applies?

> I'm wondering if you considered to use %pV.

Please see Rasmus' reply, i.e. we are using Rust's own formatting
machinery (the compiler validates the format string and creates an
object that represents the formatting to be done).

Thanks for taking a look!

Cheers,
Miguel