Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c8c33c66-8b82-1fcd-9268-94a01a7759cb@amd.com>
Date:   Mon, 14 Feb 2022 23:24:40 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH v7 03/12] EDAC/mce_amd: Extract node id from MCA_IPID
Content-Language: en-US
To:     Yazen Ghannam <yazen.ghannam@amd.com>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, mingo@redhat.com,
        mchehab@kernel.org, Muralidhara M K <muralimk@amd.com>
References: <20220203174942.31630-1-nchatrad@amd.com>
 <20220203174942.31630-4-nchatrad@amd.com> <YgRO7afWufCF/fxi@yaz-ubuntu>
From:   "Chatradhi, Naveen Krishna" <nchatrad@amd.com>
In-Reply-To: <YgRO7afWufCF/fxi@yaz-ubuntu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUcwQ3RabjBCYk9EcVVoNUZzVU1yWUhJNmprcmVERnRMSUwra3ptMUo0QTFM?=
 =?utf-8?B?Qm9ER1hBaUt3cDFkc3J5VnE1TG5qeXhlYXNnbi90WkZEM01aWnliR1BoZ1Ru?=
 =?utf-8?B?d2JZU1F0VE04MVI4ZHlrbmNaSDJKS1pBdjYvYWNOY0pob0dNSWFtem50S0h5?=
 =?utf-8?B?YnRjRnNCb01MSmdqQnhvUWZKTExhL1YyRmFvWEtOOVc5eGZWMStoTDhEQnhC?=
 =?utf-8?B?WksyRkFPeUordGR4WnNwdXZQd0JZN3VuYmd1SWFCNE55cGFpZXprRzR4bU5U?=
 =?utf-8?B?ZFRyai9Cc3ZJTmxWanhNWjJmdUFId01ENEZjc0gvVHJpanBvOFZUeHU1VmtG?=
 =?utf-8?B?bTRtTjFpSVFONHJFSUtkaDg2TGplMHloK3BPY1ZyY3JZTC9WbUFUTG1ta1p0?=
 =?utf-8?B?Yi9kbFhLdkFWekR0OEpISEdEcVlVN0xiKzMrT0IwWHpteFFhL3A5TndBWHdl?=
 =?utf-8?B?ckd2bk1MR1NIc0s1c3plMnRVeDBpajlFM2dPYnU0dFVMb0VHVnl6ZVpVU3JI?=
 =?utf-8?B?V0haV2RKbTQyWUJBbWJyOVNpWE9JS1JNK2EzZml3Z2Z6V014bmJrVDF4bmdJ?=
 =?utf-8?B?cW45aUdPVmppemZNMW92NjU1SDYxYUZ6RDlQSXVyVDJ6Yk5Dc1dzU0gxMnI5?=
 =?utf-8?B?QzZjQVlDU1diblBNTDUzTW9jNjArM2s5NFlJd0E4NFBYYm5QM1d1YVJJOGhs?=
 =?utf-8?B?VURBZjdUYnlYVnRURXc2OXFQTFRDQVR2aldzRFN5VHppY2FzRGlWbVVvbkt5?=
 =?utf-8?B?VXVNNnR0dVQ0ZVlvMGpGZ0xQNmhZT0h2SmhJWmZHb2NlcVJrM0UrZlJvd0JF?=
 =?utf-8?B?M2V1Mms0VFVhOVRibHpUYjNPa2RCTmFtT2xiSFVjTzRYZlEvQmtJdlQ0WFg2?=
 =?utf-8?B?TDkxMGQwVkZVK3hDVGdQb1lSYk1acTRReG9OaTFpQjZQbm5OREpUbnFzdVIy?=
 =?utf-8?B?amhMNFJBbklSM2ViN1RYaUhreGVCbXpRSmFOSjh4QWpUc0N4amlIY2JnVG0x?=
 =?utf-8?B?RVREYWdkbGpMdkVEWHlndnRpNWtNdWtuRW1DVmxCdk9SN2svNXpGbmRkNFhI?=
 =?utf-8?B?RnBhdDB1OG0zUklFUkxSVW5tRDU4UkdLRlM4WCtiUVJkT3RzbWVZOXNPQXlC?=
 =?utf-8?B?UHVScFlVV2J0a0dPVUJ6ZHlzcHg0OFQ2T1JRelZoMU5FQ3ZNRWRheGsvTVJ3?=
 =?utf-8?B?cTU2V1N0SWRlQU5GV25ueUc2MWN4Ny9taGJ2dnNlVnJtV0owYUVOazEzSkZm?=
 =?utf-8?B?UWdFQjFKbVU2OXFPNkdQZEYrSnZmY3hkWGgwYUJOK1JqUTVFekVVWEYwdmx1?=
 =?utf-8?B?M3lrYjZ6WUdlM1RJSmVXNVZTWXE3VlZRNUVyT0I3bU9xQVd1KzIzSEpXWWlQ?=
 =?utf-8?B?eE90ZU9mMVMxOWJEQitMUW16NndJOVdDSDFBa09VYnhMUlh2Vmt2TWF5NUhE?=
 =?utf-8?B?R2h2OEtFeDJiWkc5MGNFRmdNMDhRQ2RDT3V0V1hRNUE3MlFIVldWRlcvMnhC?=
 =?utf-8?B?RWFkb2JXUHdreGdoem92MXlKNHZGa3lWRHFYVUtpV01PcVBtYzRQQkxlMGE0?=
 =?utf-8?B?RG9NRDZjajM5c2tQeWVSUU1MbkdhVzF5cU5zUUIvd0NmRE4zRGdYbk0vSlZR?=
 =?utf-8?B?UTVCWHVZbWJmQmJscGowY2I2YTk2Tkx3WWNYRHI2NlpwZDlkakZvYnZjQVRj?=
 =?utf-8?B?aFpWLzVVaVhqeEhjOVV5ZHdPa0pRRzQ0aDFWMWdDeEtNSk1yYThNekF6b3Zw?=
 =?utf-8?B?TjhwT1ExMHc0YzcvamxYSXBuMGVZVGh2MnU1d2lyeldsTkx3SXZlMm5wM2tF?=
 =?utf-8?B?TWtkQzBSdFYvdjdlQ1p1SlZuVWZ4cGw3R3BrU3RNQkIzZ0hraDFXOGYvS3JL?=
 =?utf-8?B?TUw2em1FMlM2ejlkRzZLZytyU0UxNHdpM1Rrb09wRkQxTklsckpZYlBGZURx?=
 =?utf-8?B?RnZiaWpLQzlOaFh4SVc3VzJmZUtJSHgxLzZiVHNTbTBUcU01WmdDcy9HQmxT?=
 =?utf-8?B?NENIOVRkZ3RObWFJTC9mV1d0VEo1UmZFalI0ekxDQXZZZXA5RlRRUEZ6MEdu?=
 =?utf-8?B?ZjNPMHoySE50Q2ZIeEFRTytRQ2twWlE2VXdBdnFVY1Fjc0V5T1htc1V2V2JB?=
 =?utf-8?B?Tm4yTk51NXBQblI4Um9JelBlamgzU2R1dkdtc0hxL3R6NlR0cWVMNTBvT0ZU?=
 =?utf-8?Q?9HW5Uno3Po0quz48+0eG9Oo=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 972cfc34-079e-4b15-5826-08d9efe322e6
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5286.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 17:55:07.6470
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z/VzSQNXJ0I00ighvYJB7M+MCbc5DRlpfvfShYHRDJiZHYYaikRN2497vnpnkbcNOBUMrifNMCf7SQZTPeTLTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0001
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yazen

On 2/10/2022 5:01 AM, Yazen Ghannam wrote:
> On Thu, Feb 03, 2022 at 11:49:33AM -0600, Naveen Krishna Chatradhi wrote:
>> On SMCA banks of the GPU nodes, the node id information is
>> available in register MCA_IPID[47:44](InstanceIdHi).
>>
>> Convert the hardware node ID to a value used by Linux
>> where GPU nodes are sequentially after the CPU nodes.
>>
> Terminology should be consistent. I see "node id" and "node ID" here.
Will keep it consistent.
>   
> ...
>
>> +		} else if (bank_type == SMCA_UMC_V2) {
>> +			/*
>> +			 * SMCA_UMC_V2 exists on GPU nodes, extract the node id
>> +			 * from register MCA_IPID[47:44](InstanceIdHi).
>> +			 * The InstanceIdHi field represents the instance ID of the GPU.
>> +			 * Which needs to be mapped to a value used by Linux,
>> +			 * where GPU nodes are simply numerically after the CPU nodes.
>> +			 */
>> +			node_id = amd_get_gpu_node_system_id(m->ipid);
> As mentioned for the previous patch, why not define this function in EDAC?

Sure, with recent changes we can move this function to edac. Will wait 
for comments on other patches

in the series and submit next version with feedback addressed.

Regards,

Naveenk

>
> Thanks,
> Yazen