Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   "Jonas Mark (BT-FIR/ENG1-Grb)" <Mark.Jonas@de.bosch.com>
To:     "Jonas Mark (BT-FIR/ENG1-Grb)" <mark.jonas@de.bosch.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "RUAN Tingquan (BT-FIR/ENG1-Zhu)" <Tingquan.Ruan@cn.bosch.com>
Subject: AW: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output
Thread-Topic: [PATCH] gpu: ipu-v3: Fix dev_dbg frequency output
Thread-Index: AQHYHDV1Q6HWKEJY1UC+dT9O++/HWqyTSuDw
Date:   Mon, 14 Feb 2022 16:44:46 +0000
Message-ID: <PAXPR10MB540528C7049118472B4F190EAD339@PAXPR10MB5405.EURPRD10.PROD.OUTLOOK.COM>
References: <20220207151411.5009-1-mark.jonas@de.bosch.com>
In-Reply-To: <20220207151411.5009-1-mark.jonas@de.bosch.com>
Accept-Language: en-US
Content-Language: de-DE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?axa/gkCo0f9Uha8yybK9Wvb/2E/Pi0OtKlNFNvbWMcmmUh3IQmX0r1SDJ8?=
 =?iso-8859-1?Q?blpy3ws6gtVJMKTKxa8Il5dPoMxcZBazXdkA+5noFq1KhT/QyFVCod9exy?=
 =?iso-8859-1?Q?e1OmU2V+eBZ+NrFDwyq6ul7psU8n4lgmMMaAlcc7qPZTN8m3g9pherib/v?=
 =?iso-8859-1?Q?jPWWK+Nf2tYgFzbHQdhRjtsEQdOIbY8+UySsD/JuqVOPkpz7KUaBxPkmQl?=
 =?iso-8859-1?Q?YaYcEuos0imHWL+v3sHkP7AAGRcMS28FcAFj0RM2BhoCiN3kheN1e/46QE?=
 =?iso-8859-1?Q?oamebqJxyF/n1bEdAjehEDr41cxRpeBSjsGm2x4ifubQOuWSGGhYpHgKz1?=
 =?iso-8859-1?Q?hpCiX2x4rLjjKDMWjnZX6nuxojKSwvH2KfLGD6KTTJin5UlGva9+o/w/TQ?=
 =?iso-8859-1?Q?Nep93PZmmkb9YqPwZcClhzCsBHq1PZCQVAqdW4FltvRTng/jT5NaI8KwW5?=
 =?iso-8859-1?Q?BCONHE1nwcAwn5BUVOH2fcxo+01CDpuspL7//oEOUEitfXESrVJB2TZHxL?=
 =?iso-8859-1?Q?VnNoM/L4aPvrRQxBym457QMyX/gTt6Bs8M+a7dHj+Zdg0MptO4NhI64Mtf?=
 =?iso-8859-1?Q?zOipX4CtHA1CQUWyMrKEmrkIZKcMIDpNMIqKxP9j1taV7/9lnHFgPNRm9A?=
 =?iso-8859-1?Q?rjcZPvFSkKTvsz1ZX251tTawsv24qeLkWGAWzbDK3QyHOva9vIOr5rZP9s?=
 =?iso-8859-1?Q?8lMbuPh1mMGu3druYhytZRnPAz4msDpNjB67tmn3yk6MYSGRZwH57ib+Jl?=
 =?iso-8859-1?Q?G/M3zR3Lp7u4BKaLSTp2hRc8VTpA8viJ+prxaXvV5pbTdjg9/YwGpsKIlC?=
 =?iso-8859-1?Q?5Ayh30LiRtPjbQx+VbkW2APDLF017cIaVOjCS+FbQZfI3M92xCHNVFST1M?=
 =?iso-8859-1?Q?GZIgbtJMTmUxQxiEIsp06796xLl2LgEz4gCigkgdP7NNG33dFp9HRul6X+?=
 =?iso-8859-1?Q?rjQXTmTZtns8x9EQ1N2Cwi5XGH65TQRZpg9E9VecAAHYhld4eHA0Yhwl9W?=
 =?iso-8859-1?Q?r2/22WN2aOzA1a3GTEATK/A1kchAc09lExmzIFEMUKEAgzCUiUstZK+XZO?=
 =?iso-8859-1?Q?OBUPCss1oZQHjKR6Tfjw6r/kU4XUqkzp1vJ8qc0AJHakqBndPLEVNVJsFi?=
 =?iso-8859-1?Q?H9hClSagZ4KUmi8+AHfm45fBeF/1dYdf9Bsej4wMSAIAEkd9LXJhmuHspI?=
 =?iso-8859-1?Q?jDZaleYs8OW/TBKa8bXcQz9hnojYXXFskD2Q2wno+vdBvs62ohRhjnE+tC?=
 =?iso-8859-1?Q?hDBM6O+166f2APUaQ/pUaI4ok6u8DNF6qMhxO0xZdbFf2OqWnnh5m74I7j?=
 =?iso-8859-1?Q?PJUablcws4cGbCjqkizuUWuKRptl/Y6r4Uv9fzTQXycD/At5Myg1zWfEIb?=
 =?iso-8859-1?Q?X5rJj+nYLo5Fwu64Iso8nJGkeSz0FpETFBLs8wbxPIAUgRoixxIYpdD5uS?=
 =?iso-8859-1?Q?x8f1roQ2/sRwIZjjAUUVqfOvBThnmJdOS8DK4tdOr17kNCjZ4aU64aYc5C?=
 =?iso-8859-1?Q?9wVwuX4+dCMxWck/dfEdWbT2qSiQ8AXzQ5GTJAjQx0yBF4druT39ZRfRtU?=
 =?iso-8859-1?Q?e+G02/GbkcKyrLazEBvoU1iExHS9mKcP6Xk11OWo24uvkk3fg4lMav+uQJ?=
 =?iso-8859-1?Q?97bQGZ9/F8v6V8yoFmcxIVsbp7UFiwsdiGCrlhz8IA3HhjFx+nHnCGzw?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: de.bosch.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB5405.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 98a5f109-b371-4d7e-27c7-08d9efd94f83
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 16:44:46.9635
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 0ae51e19-07c8-4e4b-bb6d-648ee58410f4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0BqnocVPG+SSx1AULCTZqJVe/Ol9cW1QXVXmFd6gJxaFXxkaMl+VSoWSc702Fwnxk688HtJ95J6oqOw9sEM7Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB2717
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

> From: Leo Ruan <tingquan.ruan@cn.bosch.com>
>=20
> This commit corrects the printing of the IPU clock error percentage if it=
 is
> between -0.1% to -0.9%. For example, if the pixel clock requested is 27.2
> MHz but only 27.0 MHz can be achieved the deviation is -0.8%.
> But the fixed point math had a flaw and calculated error of 0.2%.
>=20
> Before:
>   Clocks: IPU 270000000Hz DI 24716667Hz Needed 27200000Hz
>   IPU clock can give 27000000 with divider 10, error 0.2%
>   Want 27200000Hz IPU 270000000Hz DI 24716667Hz using IPU,
> 27000000Hz
>=20
> After:
>   Clocks: IPU 270000000Hz DI 24716667Hz Needed 27200000Hz
>   IPU clock can give 27000000 with divider 10, error -0.8%
>   Want 27200000Hz IPU 270000000Hz DI 24716667Hz using IPU,
> 27000000Hz
>=20
> Signed-off-by: Leo Ruan <tingquan.ruan@cn.bosch.com>
> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
> ---
>  drivers/gpu/ipu-v3/ipu-di.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c in=
dex
> b4a31d506fcc..74eca68891ad 100644
> --- a/drivers/gpu/ipu-v3/ipu-di.c
> +++ b/drivers/gpu/ipu-v3/ipu-di.c
> @@ -451,8 +451,9 @@ static void ipu_di_config_clock(struct ipu_di *di,
>=20
>  		error =3D rate / (sig->mode.pixelclock / 1000);
>=20
> -		dev_dbg(di->ipu->dev, "  IPU clock can give %lu with divider
> %u, error %d.%u%%\n",
> -			rate, div, (signed)(error - 1000) / 10, error % 10);
> +		dev_dbg(di->ipu->dev, "  IPU clock can give %lu with divider
> %u, error %c%d.%d%%\n",
> +			rate, div, error < 1000 ? '-' : '+',
> +			abs(error - 1000) / 10, abs(error - 1000) % 10);
>=20
>  		/* Allow a 1% error */
>  		if (error < 1010 && error >=3D 990) {

Is there anything I can do to help getting this patch mainline?

Cheers,
Mark

Mark Jonas=20

Building Technologies, Panel Software Fire (BT-FIR/ENG1-Grb)
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY =
| www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
Aufsichtsratsvorsitzender: Christian Fischer; Gesch=E4ftsf=FChrung: Thomas =
Quante, Peter L=F6ffler, Henrik Siegle