Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH v7 net-next 4/4] net: mscc: ocelot: use bulk reads for
 stats
Thread-Topic: [PATCH v7 net-next 4/4] net: mscc: ocelot: use bulk reads for
 stats
Thread-Index: AQHYIQ3AYXOdYKMSCUmkRckqwTRmUaySztIA
Date:   Mon, 14 Feb 2022 09:51:40 +0000
Message-ID: <20220214095140.gkltte6lbr7uzoze@skbuf>
References: <20220213191254.1480765-1-colin.foster@in-advantage.com>
 <20220213191254.1480765-5-colin.foster@in-advantage.com>
In-Reply-To: <20220213191254.1480765-5-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SoFwHl+8hHlSJrhmc2bzQf363t1LRlvaMrJvcEoOsVTnv1PtKmgS5HlruP8i?=
 =?us-ascii?Q?9WRnmq2H8OLBIt193vJo1eGmydEzkk5A8TuegGXLSC/JjuTNo/WJ4MjaB4ow?=
 =?us-ascii?Q?VTCoDV3SuQnZmmcq1IDQYSU3pirvFNA1yWlJSmTUjU5ATtk4Bs44xIxCHwy3?=
 =?us-ascii?Q?Egk3N4ncLpAq5XJ68+VFDbGQ+k+IoVtZDschtYuFtEDDyYO+YGuPOtsZIAjT?=
 =?us-ascii?Q?d1AEW1RSeLWFoY2UUJ0VBOI9LmvfOPDSnqMj7tiAwWtRpx/A4vToPiBVzL1J?=
 =?us-ascii?Q?Pgl6z4+J2yDcjiw3d3ZOUPex9apkErVLiUMVYfnCBF046qCYrY+V+OLs8At7?=
 =?us-ascii?Q?Cu39Zr0NIfo9jq9IdUFsVKyUDmBGuhz+7F+kwU90ZmF1J861x2JnKv+1gx/6?=
 =?us-ascii?Q?BSGoPTdQbbWU9HBlqvsQGxHvgmt67WyEfjOolsqFmuRxb2XfalpTX7MdbB7V?=
 =?us-ascii?Q?IPbD4OMfXVj9jlJp5s5t7qzTjr1qdWX90/3tf79pnzXANUqVL1kRSPAojJj2?=
 =?us-ascii?Q?zoozHXbXc4xE3zyHNw3uQ999JCyRzDfROm34E1WAJYotRbdT+d3+S3posvdv?=
 =?us-ascii?Q?Ipy/rK50cwKGLaFfdzy1LpVOjosvQpis7JqXGI+4oJfNjoa7yxRKCjfyOR2z?=
 =?us-ascii?Q?mO8FkJVzNi4ujltwsDoHLUOF3BKGk8OLS80PSlm/IeSxTiP9j/ZGT4YpdXJe?=
 =?us-ascii?Q?T1q26WMcJwOMrpUPsdqKvRbK2Kvm1aZURWA5brAKGgaG1Neo17VRg6tZANTl?=
 =?us-ascii?Q?gydPoKiHdlDKfVvv11tVRWsEiDji9B66Ide/0dx42gH6FNUGmeyPXfKYphUB?=
 =?us-ascii?Q?FT7uxUTAlduaeWdX7fCK473Q7cTmYH9QcChu/R4QC2iAQOwqBdMkL0AhATcx?=
 =?us-ascii?Q?9/sOuB0+BTZPGLcGpdCx5h9jkVHoJCU+e+wMoaj+WweU8p//eGJNCjZV7Tbk?=
 =?us-ascii?Q?DQGUcD5gCLVoWm2/Fm6LzgSPCbxakuzu8Adqk74FEEVx5oOyDDPeeBkLMiaQ?=
 =?us-ascii?Q?ukDShyoMPPN5CHTkLKEnviGjszt+o1quxmz2bTR5tn9EMEB02WSG3h+cjuCF?=
 =?us-ascii?Q?NFOJUBYqTTGsXkSN9oIjzraoXqfXbmWZRFIjXssw8vtbIjVYbaxL8eIk51kJ?=
 =?us-ascii?Q?HbHy72YuZsY4L42kI9xx355SKkZ/nW6rPp6D34vU6J1FCY5jwv3/+1ETNqY7?=
 =?us-ascii?Q?uqPUlfFgcIkFq1rpqN7M8Zihe3sRG+X4H4VEpZPvsgXzSofiiiwffPS527bY?=
 =?us-ascii?Q?QKfNaQw4dgsUlj0RFhQfb3bi58TunGg+ZCqaOvZ/CDM1je1BdTT0csD1Yk8c?=
 =?us-ascii?Q?xidj/VsK4XomXWsFIiNtqCdidIejlJtNPyQnhwyXZumX8q8FTiGwB+XKlt+8?=
 =?us-ascii?Q?gr0psdnP9VUEIIUPmJHf/ahVRU1fmVgzgjWZFUSrdDgQRLN06kTXEHh17dYQ?=
 =?us-ascii?Q?7lm+jGODyfVJyDRSNrcV88Kd/aAYrmOqcJYM226sCICYgQ+UGubnZxEPLxn/?=
 =?us-ascii?Q?KNLHt0EhnK+b7VXGMU2mCKY4IPCjJMvI7OQU7b1u9Qqo3OEo0GgvGqJPzhG9?=
 =?us-ascii?Q?OcuTPtbWdetcdsVwG2IYA/6rqLsTxHIH4IdttI8+CtuFIDT+t+q7uR+6iDNw?=
 =?us-ascii?Q?JXguyze9TpHU1nCJnAIt0Dk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7F3DADFB82496F47AB8941F075547397@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0648487-c5a1-4e41-6872-08d9ef9f99de
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Feb 2022 09:51:40.8870
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 69iiEutXixPtTId9+GhsYPTNl7+uZQXWu8Nd/3bZcWXTX8AYAEJ5TSJT7fuaCiiadMuoeOT/FoOxvmr+d1z60Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8382
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Feb 13, 2022 at 11:12:54AM -0800, Colin Foster wrote:
> Create and utilize bulk regmap reads instead of single access for gatheri=
ng
> stats. The background reading of statistics happens frequently, and over
> a few contiguous memory regions.
>=20
> High speed PCIe buses and MMIO access will probably see negligible
> performance increase. Lower speed buses like SPI and I2C could see
> significant performance increase, since the bus configuration and registe=
r
> access times account for a large percentage of data transfer time.
>=20
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>=