Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 14 Feb 2022 09:57:09 -0600
From:   Dimitri Sivanich <sivanich@hpe.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Xiyu Yang <xiyuyang19@fudan.edu.cn>, linux-kernel@vger.kernel.org,
        Dimitri Sivanich <dimitri.sivanich@hpe.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/1] misc: sgi-gru: Don't cast parameter in bit
 operations
Message-ID: <20220214155709.GA3858@hpe.com>
References: <20220214153958.9721-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220214153958.9721-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk

Acked-by: Dimitri Sivanich <sivanich@hpe.com>

On Mon, Feb 14, 2022 at 05:39:58PM +0200, Andy Shevchenko wrote:
> While in this particular case (*) it would not be an issue,
> the pattern itself is bad and error prone in case somebody
> blindly copies to their code.
> 
> Don't cast parameter to unsigned long pointer in the bit
> operations. Note, new compilers might warn on this line for
> potential outbound access.
> 
> *) it seems a dead code, so remove it all for good
> 
> Fixes: 13d19498b044 ("GRU Driver: driver internal header files")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/misc/sgi-gru/grutables.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/misc/sgi-gru/grutables.h b/drivers/misc/sgi-gru/grutables.h
> index e4c067c61251..5efc869fe59a 100644
> --- a/drivers/misc/sgi-gru/grutables.h
> +++ b/drivers/misc/sgi-gru/grutables.h
> @@ -530,12 +530,6 @@ struct gru_blade_state {
>  		for ((i) = (k)*GRU_CBR_AU_SIZE;				\
>  				(i) < ((k) + 1) * GRU_CBR_AU_SIZE; (i)++)
>  
> -/* Scan each DSR in a DSR bitmap. Note: multiple DSRs in an allocation unit */
> -#define for_each_dsr_in_allocation_map(i, map, k)			\
> -	for_each_set_bit((k), (const unsigned long *)(map), GRU_DSR_AU)	\
> -		for ((i) = (k) * GRU_DSR_AU_CL;				\
> -				(i) < ((k) + 1) * GRU_DSR_AU_CL; (i)++)
> -
>  #define gseg_physical_address(gru, ctxnum)				\
>  		((gru)->gs_gru_base_paddr + ctxnum * GRU_GSEG_STRIDE)
>  #define gseg_virtual_address(gru, ctxnum)				\
> -- 
> 2.34.1