Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp6019268pxb; Mon, 14 Feb 2022 13:16:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJwPL2OItmTqdwZdxx4/BzZduxP5M5QnRTYApfXKxVN5jTl2H1UtCeFPfGILyMyBjYVdQg9d X-Received: by 2002:a17:902:8347:: with SMTP id z7mr684808pln.3.1644873391736; Mon, 14 Feb 2022 13:16:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644873391; cv=none; d=google.com; s=arc-20160816; b=l0Zz/9KXr45e9I6VOdPlcoKKqLoG/8uoDiz652sC8iUuZWUlik8QFR3Ou7P2jFFcvO bAf+6N13/2RLB51QHF/WL4CZtvYQPiUd6PkS3qPHtiAL4Zrde6nM6qcXlpFsmWH/hW48 XmOZbh6wmODgccO4x3hGgQlToelGrn0KttEoNA6ToLM/tMdwKMHvNbOk1lqKMoFz8vlO kGw616qOtRYdCKxyWZcY6CwRR8KsaTt+v3TGnpIqv7ZQ3u3u8G22aREoKarYG9+S6Pm9 BxGwBV9X4oTn34MRFLftghfnXrVeIpYRk7Q/S5PCcv0jnvoIZsukQoo1xl0yJB3hCI4Q ecxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pn6IR7IHkUusxfm6s7lTOCvOL9+Z8oCV5dqXSZ5RnGo=; b=aABoulDgaiAkZrmDzLcRhtO5jrAgotk3bZ4XUiauTnIDYBRY7V0eBEEuvS9PHw1+8X +B8foxlpnnkcrBnlcy3v9PE/08AgH0Lm2rW4XDtRWMVyzKO0uZcyRbAj1+UKc1Mf05jl FwxtmtRqoUJUAWfjOMgdAIjwl2S2iPj+oti8uPSS9750u25z/l+TphP62t48taiWIB3L +m0CEKxo3Ex40HUN0bNtR+B9FAH7j4cuosraxcYvn4ROqEhTkp+tA5rav4qVcAnFC6CE UFZtV/VbVNPM5O20UdjknxsjwBmRxCF1fMGQdpoyHzn2iwh5GvGNTsovFIPJqbx2w9LU 1weA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=waCoVNG7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q131si784748pgq.500.2022.02.14.13.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 13:16:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=waCoVNG7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B4DE319E0A9; Mon, 14 Feb 2022 12:34:04 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345767AbiBNKNJ (ORCPT + 99 others); Mon, 14 Feb 2022 05:13:09 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235917AbiBNKMM (ORCPT ); Mon, 14 Feb 2022 05:12:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 158AE6541D; Mon, 14 Feb 2022 01:50:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A607661238; Mon, 14 Feb 2022 09:50:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89B3BC340EF; Mon, 14 Feb 2022 09:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1644832242; bh=/DjVnQ7jgYXBQt/wqucYtc26jeqXAAs5ubdP37etpC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=waCoVNG7HUTxmBDKMSORBAnj9ufPEGA+SSWO1NeoGn6hFxwDlz0zxQUxZUQXHERHM T4zegbXRAslsWOWve3R7VdFlj40XUXkbGiFZcX1uIGoJdTu7N+y20mqpS0aMcSzkII kkC4TUsTLMvtJDMernnvkmMEibdwM+AJ2+sov0T8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Selwin Sebastian , Raju Rangoju , "David S. Miller" , Sasha Levin Subject: [PATCH 5.15 124/172] net: amd-xgbe: disable interrupts during pci removal Date: Mon, 14 Feb 2022 10:26:22 +0100 Message-Id: <20220214092510.696909905@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220214092506.354292783@linuxfoundation.org> References: <20220214092506.354292783@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Raju Rangoju [ Upstream commit 68c2d6af1f1e469544d6cbe9a601d96fb9c00e7f ] Hardware interrupts are enabled during the pci probe, however, they are not disabled during pci removal. Disable all hardware interrupts during pci removal to avoid any issues. Fixes: e75377404726 ("amd-xgbe: Update PCI support to use new IRQ functions") Suggested-by: Selwin Sebastian Signed-off-by: Raju Rangoju Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c index 90cb55eb54665..014513ce00a14 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c +++ b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c @@ -418,6 +418,9 @@ static void xgbe_pci_remove(struct pci_dev *pdev) pci_free_irq_vectors(pdata->pcidev); + /* Disable all interrupts in the hardware */ + XP_IOWRITE(pdata, XP_INT_EN, 0x0); + xgbe_free_pdata(pdata); } -- 2.34.1