Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp6025810pxb; Mon, 14 Feb 2022 13:24:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJz2EXVsoagru2UayQfYGciQXQTSGRDeAlYUMfMBWiFnfPbCDh4MY2R3ymKm7lVOFOsjsZd0 X-Received: by 2002:a17:902:c409:: with SMTP id k9mr711446plk.91.1644873876948; Mon, 14 Feb 2022 13:24:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644873876; cv=none; d=google.com; s=arc-20160816; b=bHdeNwjgPTe5+XlEBmClqqoHRROqMOyQFGcXdEUbR8ztswDDXSTJg6dXwEiTgt3oS+ ccrfGjTv1j//Rq21HAf64cAIWNm/PnmF5PsCuvIIjm6PfRVVKOK2UEH9rZ1tbwK0fdtz Az9XMY5mKiTuaOiR7DOMmcGYjH8dtd8GaH/wWf8Hb6uhlfK9TmxX4t/hx7xNrcje+eTI Xsrr40r/J95Q5y7TOSgyIuqBzGeQaIcsPY26bn1c4N+nN/evsgrNF7hCDbJkI9YG5coB VpXjhYHl5rgCu7UKQFgW9tUwfLyQ9qQlh9Wm99a/gbzEWumNLjt1XsukTyzP0LlTOEbU a1Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B3WRB1YL+L5+JbxjEZnwA++AmlGgE13EuGL+PRtHx8Q=; b=rCotlwf1mQItkeC232FWRCZbcZZv/Zs9XvIbSH/wJWgqOhn1NB/A76zGENLDf+Up9f sPG04zDLCuWOXw4rS0XHIHUa7gluYLKioBxb+LmdAf755uVr8A7v04JW0+tzVc9SD/5/ wVS7G1QjMS5gynS+ISNARM0T5fmeDaDVHbAMJBliMHy5lOgCyBZuMt4N9TNKaURpu2xc 3BWNyjPcNXZa6eEnQpNtxxruVl8sYRJ1uB1gXQdtf//Dpo1Ml1C3IJF6aUZhw7VXd9Be dr4TtRBom6B6By/YIPRg20K6zyp6tCFweRifVtfxTH0FY3VlMfLwxSeJP2H922YWUUp8 AL/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AG59o1Fv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t9si14265120plg.315.2022.02.14.13.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 13:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AG59o1Fv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A0AF81B4F25; Mon, 14 Feb 2022 12:40:42 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229728AbiBNT5t (ORCPT + 99 others); Mon, 14 Feb 2022 14:57:49 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:60134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbiBNT5p (ORCPT ); Mon, 14 Feb 2022 14:57:45 -0500 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B83C4182072 for ; Mon, 14 Feb 2022 11:57:34 -0800 (PST) Received: by mail-oo1-xc35.google.com with SMTP id i10-20020a4aab0a000000b002fccf890d5fso20602798oon.5 for ; Mon, 14 Feb 2022 11:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=B3WRB1YL+L5+JbxjEZnwA++AmlGgE13EuGL+PRtHx8Q=; b=AG59o1FvNvGvpQjnEKK7YIua4+FGo7zkXCx11iAZy3iRr1cIHX4gAGKMYtlr+uUtkK vQ/XbgHjhIMTeqSRSpp3SphCTkg1b1RZgd7SdlkMgl0tVADRCb97t7zFbMb3q+qwalUh 5mFP3ayooEfBQKfTTG8fK2M/3Zk7Sn+qMMyZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B3WRB1YL+L5+JbxjEZnwA++AmlGgE13EuGL+PRtHx8Q=; b=VisHdv8bRA81l312VQ21z5r3kQCgSnGX2oZlY4NrZEZ/l3xMVlnfikNJ45GVRo51wF h2PoWhCz7NEa0YsWgqLjVP8zPcAf4cgyqkZfiUbQDNfL3KzWoglQve7pdUYjBoQZtWkI OhF8aFfA3H6kQpVi/f5K0a2nc0hIOJEV0EvW+eBdWp4QOdFbYdbGg2bV++a2q9AVJOiR atCwstDjUD7qZf3Dx7HsQDgMZbHNf+GTb48nf90VaCOVPXTjgy04umZWrksDL+MteX97 PM31MDX1fsGUlByvVsCM8ZCS5uxzO/nnUDxTXHQO23ZnsGuGhA4OwtB7Hf758N//0pFU MXsQ== X-Gm-Message-State: AOAM533zS6+lRt6r+6BBxD9oEh4WMmKGjAfwS/B5fE/SH2IY1ILmAB+X OAfn/wurittqqdaNWgzDHmQpVM3kJcMxhQ== X-Received: by 2002:a17:90a:688e:: with SMTP id a14mr132426pjd.63.1644866725061; Mon, 14 Feb 2022 11:25:25 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id c4sm25662839pfl.131.2022.02.14.11.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 11:25:24 -0800 (PST) Date: Mon, 14 Feb 2022 11:25:23 -0800 From: Kees Cook To: Muhammad Usama Anjum Cc: Shuah Khan , kernel@collabora.com, sherry.yang@oracle.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] selftests: Use -isystem instead of -I to include headers Message-ID: <202202141125.085DF9BA6@keescook> References: <20220214160756.3543590-1-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220214160756.3543590-1-usama.anjum@collabora.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 14, 2022 at 09:07:56PM +0500, Muhammad Usama Anjum wrote: > Selftests need kernel headers and glibc for compilation. In compilation > of selftests, uapi headers from kernel source are used instead of > default ones while glibc has already been compiled with different header > files installed in the operating system. So there can be redefination > warnings from compiler. These warnings can be suppressed by using > -isystem to include the uapi headers. > > Signed-off-by: Muhammad Usama Anjum Reviewed-by: Kees Cook -- Kees Cook