Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp6028850pxb; Mon, 14 Feb 2022 13:29:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEdjBf3V5hKcdSozM4krjpqSO/aRe+iiLieVY8tXnZL2y/hA6698qm9PHdiYm1ofeiM1Jz X-Received: by 2002:a17:902:dac5:: with SMTP id q5mr878091plx.8.1644874197045; Mon, 14 Feb 2022 13:29:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644874197; cv=none; d=google.com; s=arc-20160816; b=NfUB/ZoYTTYziafsv1AVXkp1eIbCEwstz0I+gwUZjBZ5/KXUbZf8cPgNucuijsT3+t dTtfmlIcPtknClce843DKj6LpbI0OTS7gEQXPUAtrueuikSFOg4FNMkWPVFiJN3RhBFz gETA5zedY8CibccuddyKsV8tlW0HqZMClIRC1K5lpVSX0P5oL0wzeonTsNeiFGt/xVjA lNtcKt1phdDr1wClF2v4SPqmBgvDbsUjRGVQVL4GfKqQzepSsRnCHv6RU6zJ1SYTxR9T 1oI2PUiUWA7Naf58dQ7iiH9u2lP10y3msj2ClipZBJq/Kz8WrxjQWFyMZhBj//edPTNC Abrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=kB12rhcxFz/83R8CfBxx6RpBXbug3BNab8s8DxyFR7M=; b=UV4TO5BRkPIh3tBCZNyTrtmXK7fGpu8UW29PFa77f8oNY40F5LCmHQmzzmUly2v3mm rkoCgCuTgcEMCQ51kB3+S7EkFS3EG4PxASyLoCas8eA09Jg1QAQ1tzYJuGOk34LD7HVh EPbO9u1KxCSZTdUf3d1Lm2bE08sYhd/6LzyyqL0FQRervblTJRDXpD6Osl5puZsh6NY4 bsg5ifTZVtvHq2U+LTxMaAU/WMr8A0ceJeJRmAgJOFOTwwVMuNibfHosrIrLxSKZwdi5 6D2j4FaPgpuBZTnNLIf7Wnq6PBtY3qd/Mk6n6S3CAil1NCZm0mshUC/ZSp/8fPakW45f kvYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id x17si14689299plg.176.2022.02.14.13.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 13:29:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 100E3D10A0; Mon, 14 Feb 2022 12:49:26 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357434AbiBNSXt (ORCPT + 99 others); Mon, 14 Feb 2022 13:23:49 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:35752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357448AbiBNSXn (ORCPT ); Mon, 14 Feb 2022 13:23:43 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD4460ABE for ; Mon, 14 Feb 2022 10:23:34 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJg0S-00063J-6p; Mon, 14 Feb 2022 19:23:24 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nJg0K-00GbDc-9H; Mon, 14 Feb 2022 19:23:15 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nJg0I-003BDB-Qj; Mon, 14 Feb 2022 19:23:14 +0100 Date: Mon, 14 Feb 2022 19:23:11 +0100 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Lino Sanfilippo Cc: alexandre.belloni@bootlin.com, festevam@gmail.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de, richard.genoud@gmail.com, gregkh@linuxfoundation.org, s.hauer@pengutronix.de, linux@armlinux.org.uk, nicolas.ferre@microchip.com, alexandre.torgue@foss.st.com, ludovic.desroches@microchip.com, lukas@wunner.de, linux-imx@nxp.com, mcoquelin.stm32@gmail.com, linux-serial@vger.kernel.org, shawnguo@kernel.org, jirislaby@kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/9] serial: core: move RS485 configuration tasks from drivers into core Message-ID: <20220214182311.xaxkdgw5x66vubvv@pengutronix.de> References: <20220213222737.15709-1-LinoSanfilippo@gmx.de> <20220213222737.15709-2-LinoSanfilippo@gmx.de> <20220214070622.rz5cv6yy3aarvrjv@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5yzygnvea2gsyqvu" Content-Disposition: inline In-Reply-To: X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5yzygnvea2gsyqvu Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Lino, On Mon, Feb 14, 2022 at 04:09:53PM +0100, Lino Sanfilippo wrote: > On 14.02.22 at 08:06, Uwe Kleine-K=F6nig wrote: > > I was only Cc:d for the imx patch (patch #7) and tried to verify the > > claim there that "the serial core already assigns the passed > > configuration to the uart port". That failed when I looked at my kernel > > tree. > > > > So it would be great, if you sent dependencies (or at least a cover > > letter) to all recipients of a given patch to ease review. Also I want > > to suggest to mention uart_set_rs485_config() in the commit log of the > > imx patch (and probably the others) to simplify verifying the claim > > there. >=20 > Thanks for the review, I will correct the typos in the next version. > I will also cc you directly for the next version if you dont mind. I don't mind. I get so many patches by mail, I'm good at ignoring them ;-) > get_maintainers only spit out "Pengutronix Kernel Team" so I used that > address for the whole series (including the cover letter). That's why I eventually found the whole series and could reply to patch #1. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --5yzygnvea2gsyqvu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIKngwACgkQwfwUeK3K 7An98wf/bBKlqhAAMwMSKVu53e8nF1ZTSQ/QjAhBecE3mD4HgqyKTzgmzkKeHYFj KFZpNW2T05fcPMre0otOoR+7X1a2jOMv9lg2c11F6zor06DU6+RrIbtgMuzCFKJW tpM9//kD8f+OcUSESal/ZRzAS683pu+nO0x2N06+h4kRiUVfb6y2UToQhiCniQjO PtPtboM3S+ZistvDYzuo2sVXaYA7C8pTcGVbY8fO2dhWqvbwb//kIQt3ZsFvDnhj g8xi+7QVAJvKcQy9FpB0SKAcCpIx/gy+AnoezVMbbshQejDbrVQ+SYPq7wtka2PB L9NSe4gLIQM2kMMxpd8Fprm67oy+Rw== =KXKx -----END PGP SIGNATURE----- --5yzygnvea2gsyqvu--