Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp6112636pxb; Mon, 14 Feb 2022 15:53:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8sVj89Hzk7p+mA+qabamr1rfqg17rmGD8B4assYCB/0AN3qliAoUeZr7i/mRvDJOEWyWr X-Received: by 2002:a63:5205:: with SMTP id g5mr1233605pgb.61.1644882788415; Mon, 14 Feb 2022 15:53:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644882788; cv=none; d=google.com; s=arc-20160816; b=iZmwLNF63Qx2oqmWNpLusp35FltjkdvHSkcANxYm+b5DmM1JOfa70VOMkIXsQhMhSA CTaewaJXPbGztEVueb9gVTdgqLf0353Xr+Mj1DULpIhTq7YUxWD7EaIl54SRZfSG6PXZ WpxKcZff7pym/xiGD1i5BQcxQPDndQOyVq09l/MWvoRQee0fDBpDquvgek+EoZ4XZkQh J6db3D+wPgNx8TundEgjdqAn1u5KOkS2V7ifTdKW0/nE4hepxY6+G5U2YZl6YjLAYF4Q Xe1O3uEZSnSjSbjZXPa84T5ASDOcGXMnsBmaFswOIm5oK3OyknOh3AoML6Fq4gCANAdL XFfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=jNMP7Q8NQxmAGBwTIuOPJj5l1ccoDFxDqd8DS9mEGlA=; b=tjKY15nylpbaGF/c+1r/xuWe7lr/CffQd4f0WChrAi25Jonc82Mxlmo5EZtXpsqdrm 0i366rf0YQrKHQgAA4oDsqzEzcl0kwySSc5E6erKlIqjKDEuniYrAnkiGfePkhIoAIAA CjBbWqL0+k04R6yNW2miwAmSfsnSaQ9QGkrUNA+VPMuNXKkEpNTOv0QgXNSrtFLuRxQx UDVk3deUVdfOLKzGNTV1Nr/vgZdi0McQ0NrausLTg0Y2Y9Uy/tr/j2i5gwp/H9t7MZkH 5OGfn1kL+sMf7zK+wn+E9OkFgF5P6qFhMmhSt7r0t5LkVlXDbJ7sVR1GdNW/nqLo4tSF lK5w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1si35476171pfg.249.2022.02.14.15.52.52; Mon, 14 Feb 2022 15:53:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231266AbiBNVc4 (ORCPT + 99 others); Mon, 14 Feb 2022 16:32:56 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231420AbiBNVaq (ORCPT ); Mon, 14 Feb 2022 16:30:46 -0500 Received: from finn.localdomain (finn.gateworks.com [108.161.129.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6B8214235D for ; Mon, 14 Feb 2022 13:30:36 -0800 (PST) Received: from 068-189-091-139.biz.spectrum.com ([68.189.91.139] helo=tharvey.pdc.gateworks.com) by finn.localdomain with esmtp (Exim 4.93) (envelope-from ) id 1nJivO-00AkGx-Ej; Mon, 14 Feb 2022 21:30:22 +0000 From: Tim Harvey To: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Tomasz=20Mo=C5=84?= , Richard Genoud , Sergey Organov , Tim Harvey Subject: [PATCH] serial: imx: leave IRTS disabled if using modem-control CTS Date: Mon, 14 Feb 2022 13:30:20 -0800 Message-Id: <20220214213020.685-1-tharvey@gateworks.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If using modem-control gpios for CTS we must leave IRTS disabled as otherwise the hardware will only transmit based on the internal RTS pin routed to it. This allows hardware flow control to be used with cts-gpios. Signed-off-by: Tim Harvey --- drivers/tty/serial/imx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index df8a0c8b8b29..bf2bb987a51f 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -201,6 +201,7 @@ struct imx_port { unsigned int old_status; unsigned int have_rtscts:1; unsigned int have_rtsgpio:1; + unsigned int have_ctsgpio:1; unsigned int dte_mode:1; unsigned int inverted_tx:1; unsigned int inverted_rx:1; @@ -1674,8 +1675,7 @@ imx_uart_set_termios(struct uart_port *port, struct ktermios *termios, if (ucr2 & UCR2_CTS) ucr2 |= UCR2_CTSC; } - - if (termios->c_cflag & CRTSCTS) + if (!sport->have_ctsgpio && termios->c_cflag & CRTSCTS) ucr2 &= ~UCR2_IRTS; if (termios->c_cflag & CSTOPB) ucr2 |= UCR2_STPB; @@ -2227,6 +2227,9 @@ static int imx_uart_probe(struct platform_device *pdev) if (of_get_property(np, "fsl,dte-mode", NULL)) sport->dte_mode = 1; + if (of_get_property(np, "cts-gpios", NULL)) + sport->have_ctsgpio = 1; + if (of_get_property(np, "rts-gpios", NULL)) sport->have_rtsgpio = 1; -- 2.17.1