Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc:     "Trond Myklebust" <trond.myklebust@hammerspace.com>,
        "Anna Schumaker" <anna.schumaker@netapp.com>,
        "Chuck Lever" <chuck.lever@oracle.com>,
        "Andrew Morton" <akpm@linux-foundation.org>,
        "Mark Hemment" <markhemm@googlemail.com>,
        "Christoph Hellwig" <hch@infradead.org>,
        "David Howells" <dhowells@redhat.com>,
        "open list:NFS, SUNRPC, AND..." <linux-nfs@vger.kernel.org>,
        "Linux MM" <linux-mm@kvack.org>,
        "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/21] MM: create new mm/swap.h header file.
In-reply-to: <CAMuHMdUtZyJE0-_B7YDexDpkOe_y5jQ7rWJKPyzJJczuSq7POg@mail.gmail.com>
References: <164420889455.29374.17958998143835612560.stgit@noble.brown>,
 <164420916109.29374.8959231877111146366.stgit@noble.brown>,
 <CAMuHMdUtZyJE0-_B7YDexDpkOe_y5jQ7rWJKPyzJJczuSq7POg@mail.gmail.com>
Date:   Tue, 15 Feb 2022 10:50:26 +1100
Message-id: <164488262648.17471.2510331812560662090@noble.neil.brown.name>
Precedence: bulk

On Fri, 11 Feb 2022, Geert Uytterhoeven wrote:
> Hi Neil,
> 
> On Wed, Feb 9, 2022 at 10:52 AM NeilBrown <neilb@suse.de> wrote:
> > Many functions declared in include/linux/swap.h are only used within mm/
> >
> > Create a new "mm/swap.h" and move some of these declarations there.
> > Remove the redundant 'extern' from the function declarations.
> >
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > Signed-off-by: NeilBrown <neilb@suse.de>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/mm/swap.h
> > @@ -0,0 +1,129 @@
> > +
> 
> scripts/checkpatch.pl:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> 
> Gr{oetje,eeting}s,
> 
>                         Geert

Argg...  I think you pointed that out previously and I forgot to act on
it.
I've now copied the SPDX line from linux/swap.h, and also added that
standard "#ifndef _MM_SWAP_H" etc protection.

Thanks,
NeilBrown