Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>
Cc:     Stephen Brennan <stephen.s.brennan@oracle.com>,
        linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drivers: hv: log when enabling crash_kexec_post_notifiers
Date:   Mon, 14 Feb 2022 17:37:35 -0800
Message-Id: <20220215013735.358327-1-stephen.s.brennan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ye5PdqRWHP+cmMFyGbA7GA66jd6uuyC3OQALOMOL3b6QnAfFD8WVO6gvjaP9?=
 =?us-ascii?Q?EWvQK9c6mY48vB/yVt6BD6x250cwUfOhn3lE4STkvj9QVgG/bsg+N/4AW1gc?=
 =?us-ascii?Q?1OQY++g5o+WFSh9ahbwWP+Dxix6SZ45jDR7jvK6PX+WOcKvrCUyg1GAz76qD?=
 =?us-ascii?Q?Flf9v6Y9vBH7lYzELv2hbcqrNjG1FaHmKJBYmtyaPsWAnBrJVPRtE1+DZrwi?=
 =?us-ascii?Q?blbYNg8BLNB3WMCZmvydrD2nPHP0sxW90qtqVkl0ZR5WTTlsgw0j83GwIT+1?=
 =?us-ascii?Q?G/RfK6gyludci7UaO++Ig3t/sFB1D0Q5paVB6nlVGpi4jYzl80Tou/O0c368?=
 =?us-ascii?Q?ndOtb0KCiOtFB/NResw5lNLw+B1JZ2/My9PPO82yIJjrlksbDeGwWCr4BWEc?=
 =?us-ascii?Q?6A9z5vpMheIgaKZMyZbywj+pdIkq8dMZ/2Rr4LQTJOgYzdGTJDDdn68c3vbt?=
 =?us-ascii?Q?qf3mD2BAJqz1c0CCTgHXrs/VD5VniDiJUt8IV7lH+hoxN/3oVyXF8qzupgAv?=
 =?us-ascii?Q?zgHNE2RHXjA0FAtZgJn43BapERX/kfCXRP1CzWNvpgc1IOIyF4WypegY9IfW?=
 =?us-ascii?Q?FiJobzQJM2m+y4QmTr222/Capl1BW/hQyYtC4ylzI2ysX2LrtOBaIBeuF7kj?=
 =?us-ascii?Q?n0xiDUc4QQLGrdO8lsQClmDtWGaCiOC8MUNHY6Wksp7iOmJIbF5bF9oxVv5c?=
 =?us-ascii?Q?xnPrd64q1+fhSx4ABCQxlL6YQsztybasVVj59q59aJmqodIlF1KmqouQPZFT?=
 =?us-ascii?Q?C/Ci0+KZH/XxNz5zR0YCRqqoZVRB4NoqkyNqR/ZtFZK2wS7a5ZW2TGR76BRS?=
 =?us-ascii?Q?WiW9pvjwySwr2Fgoczh2Dn+CJPDc4qzslMnSdSsYhDY/weOZOsKazM1QvqFj?=
 =?us-ascii?Q?akPYi/uperpX2t7XMsJEZ7e1rSQPzw8TMqf9H/LUJAqNV/+y8cykAqVFqQFY?=
 =?us-ascii?Q?9p8aovQNHxCa+x+RpMm8QJXX3M6J8vmIkxpg/si6ZOxrpNL1RzpNxm8HJ4f9?=
 =?us-ascii?Q?IZd8nvlrUvxLBIHwrMU/GHHEDEziVWkaCukKBJiJG1qvOGEJgvF3QXhJMeXa?=
 =?us-ascii?Q?RpRFQjRs2NzAMWviF6VTVY77yewJIssPMkEb9sM8kXiRekEBvKgEt/iWE2xG?=
 =?us-ascii?Q?hod6HbXjjFhRnccd0SuF9vNdgluElUcgJW79P0UzyAiVDePoGErtgFQejQwT?=
 =?us-ascii?Q?wUfullyMNq0j8Kvtb8bgbTYnpDEKP9ZTr3zlkHK69Z04Y4aLk9EQVo7XfGmj?=
 =?us-ascii?Q?LMCu/P2uf+klk4Ouhq0t3m5JbZwojdMX7xwipHv4nl43Debwto+mx3RzrMpD?=
 =?us-ascii?Q?FdE3VM5KCUUuzPik1v4T2RMpjshiJJOo3nagMcDF2qEZny6ME4mYxOU+hUOu?=
 =?us-ascii?Q?9qhlpWla9BUOBSc2jSzouGa/JL8iz0v7VOdwX+Zj5h6fjjmyztwNRknN7mDt?=
 =?us-ascii?Q?QZYlTS6GZaeOmgo65zJjFcqY735OsebTiPsLrIHAHsVodNiYucoYXibWX7AI?=
 =?us-ascii?Q?eitn/U4GK2mweMniM8eiG5SKvdvxaFm/XPxoIF/Kls1uz3cRDB6BjCxn+Iey?=
 =?us-ascii?Q?58LqzCOIbhhAbPmTB+r3D4ekPaB9wFCoMdrLH7LmqHZKKjOFMmsS1Yd58QKF?=
 =?us-ascii?Q?05MFU5YNG3OdSHUm2Eum8uFAd1CD9QE4J/suh0oiuhoUc3TcDEMKRFYrIh5w?=
 =?us-ascii?Q?tMUoWQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bcf8dcd-dcee-4596-b04e-08d9f023bf9a
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 01:37:38.0305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jkPPPGF4LaN2nKJiJZz+VcTHKGM4sFIYbuGC8UgB0coPtyznwlsL2+snqg7DA7h3f9mZxupJSjck/4BXMTYmu9R5GywQgVOIFFNn29red5w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2385
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10258 signatures=673431
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202150006
X-Proofpoint-ORIG-GUID: lMDDD_brBe_jvsrT2D1--4Vek84qa_3C
X-Proofpoint-GUID: lMDDD_brBe_jvsrT2D1--4Vek84qa_3C
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Recently I went down a rabbit hole looking at a race condition in
panic() on a Hyper-V guest. I assumed, since it was missing from the
command line, that crash_kexec_post_notifiers was disabled. Only after
a rather long reproduction and analysis process did I learn that Hyper-V
actually enables this setting unconditionally.

Users and debuggers alike would like to know when these things happen. I
think it would be good to print a message to the kernel log when this
happens, so that a grep for "crash_kexec_post_notifiers" shows relevant
results.

Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
---
 drivers/hv/hv_common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
index 181d16bbf49d..c1dd21d0d7ef 100644
--- a/drivers/hv/hv_common.c
+++ b/drivers/hv/hv_common.c
@@ -79,8 +79,10 @@ int __init hv_common_init(void)
 	 * calling crash enlightment interface before running kdump
 	 * kernel.
 	 */
-	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE)
+	if (ms_hyperv.misc_features & HV_FEATURE_GUEST_CRASH_MSR_AVAILABLE) {
 		crash_kexec_post_notifiers = true;
+		pr_info("Hyper-V: enabling crash_kexec_post_notifiers\n");
+	}
 
 	/*
 	 * Allocate the per-CPU state for the hypercall input arg.
-- 
2.30.2