Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932208AbXBNBGv (ORCPT ); Tue, 13 Feb 2007 20:06:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932212AbXBNBGv (ORCPT ); Tue, 13 Feb 2007 20:06:51 -0500 Received: from iabervon.org ([66.92.72.58]:4065 "EHLO iabervon.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932208AbXBNBGt (ORCPT ); Tue, 13 Feb 2007 20:06:49 -0500 Date: Tue, 13 Feb 2007 20:06:48 -0500 (EST) From: Daniel Barkalow To: Chuck Ebbert cc: linux-kernel , Dave Jones Subject: Re: Is this bug too obvious? In-Reply-To: <45D25ABE.5080400@redhat.com> Message-ID: References: <45D25ABE.5080400@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 979 Lines: 30 On Tue, 13 Feb 2007, Chuck Ebbert wrote: > drivers/usb/net/usbnet.c: > > int > usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod) > { > struct usbnet *dev; > struct net_device *net; > struct usb_host_interface *interface; > struct driver_info *info; > struct usb_device *xdev; > int status; > > ... > > net = alloc_etherdev(sizeof(*dev)); > ^^^^ > *net ??? No, alloc_etherdev takes the size of the private data, which, in this case, is *dev. -Daniel *This .sig left intentionally blank* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/