Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 2/2] perf jevents: Add support for HiSilicon CPA PMU
 aliasing
To:     John Garry <john.garry@huawei.com>, Qi Liu <liuqi115@huawei.com>,
        "will@kernel.org" <will@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>
CC:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Zhangshaokun <zhangshaokun@hisilicon.com>,
        Linuxarm <linuxarm@huawei.com>,
        <linux-perf-users@vger.kernel.org>
References: <20220214114228.40859-1-liuqi115@huawei.com>
 <20220214114228.40859-3-liuqi115@huawei.com>
 <1da1252e-59d0-77d1-0419-242528739392@huawei.com>
From:   "liuqi (BA)" <liuqi115@huawei.com>
Message-ID: <dfa69bbf-726c-558a-b929-aa97dd6590aa@huawei.com>
Date:   Tue, 15 Feb 2022 09:27:37 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <1da1252e-59d0-77d1-0419-242528739392@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2022/2/14 20:04, John Garry wrote:
> On 14/02/2022 11:42, Qi Liu wrote:
>> Add support for HiSilicon CPA PMU aliasing.
>>
>> The kernel driver is in drivers/perf/hisilicon/hisi_uncore_cpa_pmu.c
>>
>> Signed-off-by: Qi Liu<liuqi115@huawei.com>
> 
> You realy should cc the perf tool list and maintainers there also.
> 
> Reviewed-by: John Garry <john.garry@huawei.com>
> 
>> +    },
>> +    {
>> +        "MetricExpr": "(p0_wr_dat * 64 + p0_rd_dat_64b * 64 + 
>> p0_rd_dat_32b * 32) / cpa_cycles",
>> +        "BriefDescription": "Average bandwidth of CPA Port 0",
>> +        "MetricGroup": "CPA",
> 
Hi john,

> nit: maybe this should have a more distrinct name

got it, will change metric's name next version.

> 
>> +        "MetricName": "p0_avg_bw",
>> +        "Compat": "0x00000030",
> 
> JFYI, I have a rewrite of the perf tool system pmu metric support that 
> will not require us to add the compat here.
> 
great! I'm very glad to test it using CPA PMU.

Thanks,
Qi
>> +        "Unit": "hisi_sicl,cpa"
> 
> Thanks,
> John
> .