Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 14 Feb 2022 16:48:59 -0800
From:   Cong Wang <xiyou.wangcong@gmail.com>
To:     Ido Schimmel <idosch@idosch.org>
Cc:     David Ahern <dsahern@gmail.com>, menglong8.dong@gmail.com,
        kuba@kernel.org, nhorman@tuxdriver.com, davem@davemloft.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        dsahern@kernel.org, rostedt@goodmis.org,
        Menglong Dong <imagedong@tencent.com>
Subject: Re: [PATCH v3 net-next] net: drop_monitor: support drop reason
Message-ID: <Ygr4e/9zLkZ45YWe@pop-os.localdomain>
References: <20220127033356.4050072-1-imagedong@tencent.com>
 <cdb189e9-a804-bb02-9490-146acf8ca0a6@gmail.com>
 <YfLCMFXbGTgef5Uu@shredder>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YfLCMFXbGTgef5Uu@shredder>
Precedence: bulk

On Thu, Jan 27, 2022 at 06:02:56PM +0200, Ido Schimmel wrote:
> On Thu, Jan 27, 2022 at 08:53:04AM -0700, David Ahern wrote:
> > On 1/26/22 8:33 PM, menglong8.dong@gmail.com wrote:
> > > From: Menglong Dong <imagedong@tencent.com>
> > > 
> > > In the commit c504e5c2f964 ("net: skb: introduce kfree_skb_reason()")
> > > drop reason is introduced to the tracepoint of kfree_skb. Therefore,
> > > drop_monitor is able to report the drop reason to users by netlink.
> > > 
> > > For now, the number of drop reason is passed to users ( seems it's
> > > a little troublesome to pass the drop reason as string ). Therefore,
> > > users can do some customized description of the reason.
> > > 
> > > Signed-off-by: Menglong Dong <imagedong@tencent.com>
> > > ---
> > > v3:
> > > - referring to cb->reason and cb->pc directly in
> > >   net_dm_packet_report_fill()
> > > 
> > > v2:
> > > - get a pointer to struct net_dm_skb_cb instead of local var for
> > >   each field
> > > ---
> > >  include/uapi/linux/net_dropmon.h |  1 +
> > >  net/core/drop_monitor.c          | 16 ++++++++++++----
> > >  2 files changed, 13 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/include/uapi/linux/net_dropmon.h b/include/uapi/linux/net_dropmon.h
> > > index 66048cc5d7b3..b2815166dbc2 100644
> > > --- a/include/uapi/linux/net_dropmon.h
> > > +++ b/include/uapi/linux/net_dropmon.h
> > > @@ -93,6 +93,7 @@ enum net_dm_attr {
> > >  	NET_DM_ATTR_SW_DROPS,			/* flag */
> > >  	NET_DM_ATTR_HW_DROPS,			/* flag */
> > >  	NET_DM_ATTR_FLOW_ACTION_COOKIE,		/* binary */
> > > +	NET_DM_ATTR_REASON,			/* u32 */
> > >  
> > 
> > For userspace to properly convert reason from id to string, enum
> > skb_drop_reason needs to be moved from skbuff.h to a uapi file.
> > include/uapi/linux/net_dropmon.h seems like the best candidate to me.
> > Maybe others have a better idea.
> 
> I think the best option would be to convert it to a string in the kernel

This is a bad idea. Integers are much better as they are more flexible
than strings, for example if your application wants to filter with a
specific reason, a simply integer comparison is much faster than a
string comparison. More importantly, user-space could store the integer
to string mapping by itself, saving strings in kernel is just
unnecessary.

> (or report both). Then you don't need to update user space tools such as
> the Wireshark dissector [1] and DropWatch every time a new reason is
> added.
> 
> [1] https://www.wireshark.org/docs/dfref/n/net_dm.html

I don't understand why this is even an argument, we have tons of
applications need to update to catch up with newer kernel...


Thanks.