Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] spi: add missing pci_dev_put() before return
Date:   Mon, 14 Feb 2022 18:00:07 -0800
Message-Id: <1644890407-65167-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Oo7AlYi53f325/gtMymmSCTPQCROGCeaEZdvbVQopAMQVaJR5MzEuBH6oG/y?=
 =?us-ascii?Q?X/W20/Jar8srKPdPSvoY4XlrXSvFF1CboGE28tHyzxJGyWCIEtnmDEhyLeoZ?=
 =?us-ascii?Q?edHYxsA2hcnD5eoPoSZInxPR6ztXaXgIISgho1PiW7OUQiw5fiCwsSDb6HQ+?=
 =?us-ascii?Q?/nKmgNMZbqveD2xIXEoURf6GpI0FVCrJUfBlpTkzTwMuANICoB+AhzvHs0R8?=
 =?us-ascii?Q?xtdMFjnsGjxiG/KMLzWPEPRzjvdr7Jo5Gbk7WsC1nYwvV6padv56K9QVoJzQ?=
 =?us-ascii?Q?De4gNsoHIgtwFtmE2IhKr9EWHm4sMetC2H41rNZxrliwa5kQ/7fLIrUiYf/g?=
 =?us-ascii?Q?aseyA2P6z7ZtMq7DPqduJx5L6vgc6BREx+4VHyZc3Bi0gEb0d5Zcdp8lWX3D?=
 =?us-ascii?Q?LL9YYqknhxSF3ypemXcFHFsi6gf+lRXyAG78k9d70v4g6XOuKeDsrZWlCDaO?=
 =?us-ascii?Q?ApTM0rUMiTguL8CwVWepRyGYC0zFni+rYTv3kMO/kb35kjizl0cZgA1d6tJs?=
 =?us-ascii?Q?vrLQJ4XIk74YlIWVBt82WBWVqwQ+9bmkv/sDNH/p06QuyqdGzp+OTAQz4gkr?=
 =?us-ascii?Q?Lxb3sp93XfzQHqRIGpB8Z3Q9ho1A7ZZbEmDvh+2YOnpHCM6bnw4nXvR72Qey?=
 =?us-ascii?Q?xf/fiZxl9fVqaj40gmp26uV9/njEl5x1BF1dTsQ7LLoAMIhiI6YnnZFm4oi/?=
 =?us-ascii?Q?NfI0+BdO6adJj2GPFyqze7OGarPEa6PYk6mfSNhMgWXeRfB6CmV+mV87ZvBh?=
 =?us-ascii?Q?OW3HTt6NwFHnVTeR7aceIch0yvQgKBdy5k8VBw2l0a2WX8jyMAsCuNx+ff9H?=
 =?us-ascii?Q?Ew0FzZJEqPbspfXNyMyBIlwU9TDPviDeLyu2l6vBmlTDfaQcjQ9vbsXKNHB4?=
 =?us-ascii?Q?Nv2NyStopPNijEYtbSuWJF30a24ce/+eMS6JxH63wNJJaGyvsLkjQORgjfoq?=
 =?us-ascii?Q?eayhaedz8JBJbvyHo76JrGvkdq6QcQlSE7PPL2n3HDm4SGgdye+GL0T9Jgzu?=
 =?us-ascii?Q?ka9WCJ09vcnD1DCNVONa4EFy//ZSyN4HIpqQdld5NrYBPHPhOmpHk5sH3vNu?=
 =?us-ascii?Q?J2wJgW2/M78G7VWlC2lMvtMZeTDiP69YiSXrfvuDpF+SczkCO10WpjbqdMVK?=
 =?us-ascii?Q?NM5a1oYWbkbHvw1ztwUDIKRFZRypZch5GilqxWdMF8BjpJHWIhCG65RcNzHu?=
 =?us-ascii?Q?To7Ox5RhecKgo2PMHB+v3Qf1P+PFhcRnrEpRuSKcmjy91ylUrNp1uD4WR0r9?=
 =?us-ascii?Q?o2TYke4RjGEHwdtZzQrj+kqpVH2uj5ppivI0aAIcGB+z9UIO3iZbMcNNE8cg?=
 =?us-ascii?Q?zuT9i4JTQlGcvF001TKaghSl/LLKXUmeQytxQNL/KG+7/2oXuspto1xZBwA8?=
 =?us-ascii?Q?Vca/EWUJtTILF35XXx6guIQWH84IKtCvUaKrWYfpHpIjawKPzchksVD1qcCx?=
 =?us-ascii?Q?FctbhDPJuSOrr6Dw4gBA2PmpE5/3egt7/uEQYYPNF0UNt9/10SoLF2lk2H3L?=
 =?us-ascii?Q?vLHAeWL+Z15pXPH4p0M/bWBNKBzdvs5jwxt7oWYeWQpBJ+m3wBqH/MKK/oMS?=
 =?us-ascii?Q?TgcP9PyFBKeoImjubYisKKKU9AaPs1ZDDGpYNAQEya83jJ4VCfCc/N3Bt4BP?=
 =?us-ascii?Q?uv2LrZyb73mKyeiJeNWEeIo=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bfd9b3dc-dafc-4800-1411-08d9f026eeb5
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 02:00:25.5622
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RgRyWKFKeBfpK8I6WH8IfkOxf1wUV5XxK4ssecCJMcl58auV8oEoqkkXgecm5yg3JvPiA6wJiwrjINyDHIjMSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4510
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

pci_get_slot() increases its reference count, the caller must
decrement the reference count by calling pci_dev_put()

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/spi/spi-topcliff-pch.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c
index 8c4615b..8e1cc34
--- a/drivers/spi/spi-topcliff-pch.c
+++ b/drivers/spi/spi-topcliff-pch.c
@@ -877,7 +877,7 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
 		dev_err(&data->master->dev,
 			"ERROR: dma_request_channel FAILS(Tx)\n");
 		data->use_dma = 0;
-		return;
+		goto out;
 	}
 	dma->chan_tx = chan;
 
@@ -894,9 +894,12 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
 		dma_release_channel(dma->chan_tx);
 		dma->chan_tx = NULL;
 		data->use_dma = 0;
-		return;
+		goto out;
 	}
 	dma->chan_rx = chan;
+
+out:
+	pci_dev_put(dma_dev);
 }
 
 static void pch_spi_release_dma(struct pch_spi_data *data)
-- 
2.7.4