Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Qing Wang <wangqing@vivo.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Wang Qing <wangqing@vivo.com>
Subject: [PATCH] tty: serial: add missing pci_dev_put() before return
Date:   Mon, 14 Feb 2022 18:01:12 -0800
Message-Id: <1644890472-65306-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OAv8msJEQKNxCsGw4YAo7PHqLeAxwFT/4t4OAYgKilz2Il27P1NZqGJwTW83?=
 =?us-ascii?Q?7WSHFYqTY6ha1pTg1g9R2TtcPerOihQzJQnAlGA0w8GZT2i3xUMDJZhZcW5m?=
 =?us-ascii?Q?MPYaCY6zfPVXybu1/DLxN9QMlHvtDRxNkQ5fm1Y8lZHNRPB4X/HprrhCMu8i?=
 =?us-ascii?Q?/6q3LAvAaOK3Ha93Cu8PpYTHDuZvBMk3e6NDK5d3/sjwTwfL8X06bt9zUjGb?=
 =?us-ascii?Q?ZDEM64FsJDT1n2xCMtYMSa5EIPymHlnVhpvh3g8xp+cb41ldVjSeEPT++L0K?=
 =?us-ascii?Q?oz7hEei5EmNRIuFsYGD5sv5EujPNh5DdAki6R3orxNJj2tKIlHpg8BN5n2FW?=
 =?us-ascii?Q?yfXhdMGtt4+Oizku+0lgqV/8s3KLQ+RU0GyVuzRDJIExwGqSWVd+F2cp/yi6?=
 =?us-ascii?Q?bM7rvzor7gcVV+CvQ1+nY4qCf6mc58aexuue9/j0F/L3dXLhun0Deaq3unjJ?=
 =?us-ascii?Q?b0IwcJ+yv/cSIOZctKfm2mycFVMDFTBzPUrNTEjyjCoBbKgEEe0m3O7LxFiT?=
 =?us-ascii?Q?r3hKy3+0vWsaLMFh1XJ+QHqXf3eZ5x+yqXk6piURx8gUl0ZR3xyUkWWsRFdC?=
 =?us-ascii?Q?51y/SUcGEJ/DPvDdjnjeyniEHBsafPZjvvMWnkIXhtHD5rSEtjlnuOhnBuM0?=
 =?us-ascii?Q?N7LE34V1oSlgU2IoWq7UiR2jlPp4inGwrNJ3YJlbU0PkMATrWsVIQgWd91IY?=
 =?us-ascii?Q?LIpVIgV6WPa4B8el5e/NExa6bJHU5PgHSFZYkwtWJYWo2WafVBnLpRrWm1mX?=
 =?us-ascii?Q?VapOVqxn+4I0vs91VwGN0BbWeP/VOFElrlmuAGsjP+kEkIb1p9K1ws99n5CB?=
 =?us-ascii?Q?+nFenPRqTLkGgjHC8JCPgvcH/2gIQ9E/TV+h990MT+k9eCQ3ZwI1CWQfsVBq?=
 =?us-ascii?Q?DsFkKqHGeKeABCYogR9z+Qx8k3iwoXmy46ntYYoF1KzEMg2SRy3rcJDHsv1I?=
 =?us-ascii?Q?KnxKYcUO//OlWDEouNFNN8QIjMGlDN8dLCzGjl/4Y57SNXjgpGWZViQthfOS?=
 =?us-ascii?Q?R/+aeaIvt9jBlEY16Xm4RG8qXG0qb/bb8a3X2L2CGKezQS/nriETQNusgP5Y?=
 =?us-ascii?Q?4j9Xe4hH+GoSXkuUiA4/KqKyVpeU8ljelT0LLCncclnnKPCEoFXHtdCFsJyJ?=
 =?us-ascii?Q?mjIimTXQWZn3KjfsljwNBHOvgtHHWbXNbrJ3CD5Ik9h0O0aAQ8nYwPuWCTHk?=
 =?us-ascii?Q?IQpISOSInrTcNwkmmusNEuTeiL5JOQDCbpGk5pEJqPQUDniDykDIDT+2J1A8?=
 =?us-ascii?Q?NDBvQHVWon2y4XmJQDFgDS2gfbcqH1ls7WPVX7SXY8B6Ek+01VYfnsHhItHT?=
 =?us-ascii?Q?rvrQetRSImuycqEhccOl4rJ73wk7KeptRlv8NdOwCa713SwR5um1xmOeID68?=
 =?us-ascii?Q?gZXHaxBTKkciy4av23++wxr5R4txmBHJbRhZht8JUgzN4aeSKwWKw/+wz30A?=
 =?us-ascii?Q?l1yTLW6xflVe5TwmHC4OieNNPceO9oI/Xb2nwVaWYgkCYic5FsndGHEoLhgZ?=
 =?us-ascii?Q?hKmH2KsbbsHpANmM2vuECQLyRZPqbuHR+6JnNCQPUHtIDWyeac95dvP81txd?=
 =?us-ascii?Q?VOMyLSknDOnA89tYb8aq89fc4lj7VJaUxq8g96jfM2NoZBEm2RXNGNy5I3Qn?=
 =?us-ascii?Q?zy6FWNA5ErcvXJnt/ivq7NM=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2db495d0-e3d6-47ef-fe67-08d9f027218d
X-MS-Exchange-CrossTenant-AuthSource: SL2PR06MB3082.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 02:01:50.8855
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: D0kDBFttoiq3Yv1AqYcOwmUUL1AWB5ZhXsznrsky9AKrmUt9UcSh8ynO0bBzZ4LWZOwSS0eKLzgXYaFxRtgGIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB4510
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Wang Qing <wangqing@vivo.com>

pci_get_slot() increases its reference count, the caller must
decrement the reference count by calling pci_dev_put()

Signed-off-by: Wang Qing <wangqing@vivo.com>
---
 drivers/tty/serial/pch_uart.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index f0351e6..da5a276
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -723,7 +723,7 @@ static void pch_request_dma(struct uart_port *port)
 	if (!chan) {
 		dev_err(priv->port.dev, "%s:dma_request_channel FAILS(Tx)\n",
 			__func__);
-		return;
+		goto out;
 	}
 	priv->chan_tx = chan;
 
@@ -739,13 +739,16 @@ static void pch_request_dma(struct uart_port *port)
 			__func__);
 		dma_release_channel(priv->chan_tx);
 		priv->chan_tx = NULL;
-		return;
+		goto out;
 	}
 
 	/* Get Consistent memory for DMA */
 	priv->rx_buf_virt = dma_alloc_coherent(port->dev, port->fifosize,
 				    &priv->rx_buf_dma, GFP_KERNEL);
 	priv->chan_rx = chan;
+
+out:
+	pci_dev_put(dma_dev);
 }
 
 static void pch_dma_rx_complete(void *arg)
-- 
2.7.4