Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 13:43:00 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/2] usb: typec: anx7411: Add Analogix PD ANX7411
 support
Message-ID: <20220215054300.GA3752727@anxtwsw-Precision-3640-Tower>
References: <20220208091621.3680427-1-xji@analogixsemi.com>
 <20220208091621.3680427-2-xji@analogixsemi.com>
 <YgPCLopskwyQ6F4K@kuha.fi.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgPCLopskwyQ6F4K@kuha.fi.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QL3PLQi90wB1yoFmAJ8ltx7OT+kjagLOJd/TwIeipIrXV0M387fggKqBnM9H?=
 =?us-ascii?Q?3+YkjjzlLKFS6xCBrK2TPga4gPaSUnV+enYkWTTXUMDrJPHT/rn4+vi9lEn2?=
 =?us-ascii?Q?8bU9rer+6xDzSGW97onjSj4kehGBO7byqauJSjS9EDxRRTIYTe3DhmSQUj+Q?=
 =?us-ascii?Q?+a4Y4Q5xnI/yeYgy/WKFubNlmbMW9RCqUzvzxO0Es0nhce7NRRabaUtNqF5I?=
 =?us-ascii?Q?wJZFVmAhORQXg6f2UGYKaSxV11CD233aCSTBs7yG3nO/t1risNWjmRKXn553?=
 =?us-ascii?Q?P1OY7rgeSF1To7hKOIkOfJryn0u+bc/5S1bgI1LJ2kWd0Jxca4S9QO5OrUQZ?=
 =?us-ascii?Q?uIJPvFzbG5J2UJHXqsSwse6DfVUup9V+PuwlyEBTqC6aueB2vOpiHPsVRjOW?=
 =?us-ascii?Q?4Jo3KvbZ+0k6F70FlcvqCjEFeB6PTx12mBiBNFlxe9ZR0E3GmMO6oyD9VpAF?=
 =?us-ascii?Q?1bJxsaMw6F3+cx65i8FzomzKdibrVB04IsvC6WazYaKVwJ6VV5tIC3QVoOVD?=
 =?us-ascii?Q?mWxiw+EDS7q8w2+kri/mv+gnhVMfG0XTVf1Fx9ULYeZPKED0wrEMQ0wBsAjX?=
 =?us-ascii?Q?wINI7Zy8DOllycx19zHuUmCqJndfkjhm80Y+jn2d2acoxdoSoGu9U1ymGfBA?=
 =?us-ascii?Q?K0ZTjhjEEq3/1R7vl1yNFfLoRJEfojkDeiVzeOlnmrao28kVfUbiX5lQP8S5?=
 =?us-ascii?Q?96DLWi3tUMtkNvifj7ikXJetKnK86lcXloGoswMpqBOwXNgQPu1hldtQ6ntn?=
 =?us-ascii?Q?IkD/FryxeIBxQVzEUtfde6V7eC9N/0sP8js0fD2TPyHzqzF6aWwFekJU0bLI?=
 =?us-ascii?Q?eputQ9NZ8M1LUvFdok0ciiFCeSEzsE6c/5TSpnZAByRdogjLvQGMwG09hLRP?=
 =?us-ascii?Q?Nb88I/PQpkdiAjzYf9rBLKc4C+5138ONFW4XYgdZEXKzjnRYxweEb8thlFpG?=
 =?us-ascii?Q?7SJoOejH0MXqGTaJ8ASUJa4LTtLcn2GP5IlB9ICLys9nnamwEvvdbzA3+zcW?=
 =?us-ascii?Q?kSTsdCIofKfEtTXcHp3co6lggYlMQHVz4TeE/dOspTLRX5BrWlqFzjqR/aTc?=
 =?us-ascii?Q?IO0RiDhcdDo33HZdNgHC/n+9IzIzvTRYg5FcI1nIq2SeheD9NB7R0LlJedR6?=
 =?us-ascii?Q?c0mkZdo6WsQ4fetMz2dAPyzLAChMbY0/dWbZxHEvlNfIsdS+kJkclmA8/Wgq?=
 =?us-ascii?Q?liDJCneQKEMS4vI7sBXTopY580Ot2DtXXfVhA5/6C5EDtC9PsSblLklehyhZ?=
 =?us-ascii?Q?AkqMNmg/8IuzaXdaWrB7yQHXF4AwZEjsJAm4a7L4twDPY7n1oKBBMP+Kjn6O?=
 =?us-ascii?Q?nSsX54pu5EylOENvSb6AiQ+O5UmToSxKjR+UFpfadZV9PjP998qxXouXRtHP?=
 =?us-ascii?Q?KWL6qGy5CUdv3Cxls7JOYmR4AvUwuwZZMnRl94ghspolSeUt4DBW6RvqGRF5?=
 =?us-ascii?Q?IcnlRkdq6OjI6O0ESfLnsGhmHdsq309PM6p9WhLRYy61/sAni6HUkzuuZuC6?=
 =?us-ascii?Q?+LlruJ9c3fkjFCHT2czAnwdWnJ8xMr6XnK8OC6566J/cqSkXIQU0nMB1Ychg?=
 =?us-ascii?Q?1GzvnOxp4T5yT0fQ/3+vAPZjJiIeBac+/oVCjX8ZmYMfxmhPzsbYh+ZX8/kh?=
 =?us-ascii?Q?VmWPSN8Or3Yc7BT8v3OwMw4=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b70e386-7398-4ad1-2a36-08d9f0460bfc
X-MS-Exchange-CrossTenant-AuthSource: CH2PR04MB6741.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 05:43:09.1587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0RckdBGafd+x8ofTc1dTOId64iJR2s9ak4ynGFU2MaK2WzqPoOIqox/Ot9iLHASpccN6oqGTxPuik5fwPC7DPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4861
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 09, 2022 at 03:31:26PM +0200, Heikki Krogerus wrote:
> On Tue, Feb 08, 2022 at 05:16:21PM +0800, Xin Ji wrote:
> > Add driver for analogix ANX7411 USB Type-C DRP port controller.
> 
> We already have the driver drivers/usb/typec/tcpm/tcpci.c for port
> controllers.
> 
> If you need a glue layer - if there is something specific that you
> need to do with ANX7411 that is not completely TCPC compliant - use
> drivers/usb/typec/tcpm/tcpci_*.c as examples.
Hi heikki, ANX7411 PD controller has 2 applications, the one has embeded
internal firmware, the other is not have. The currently upstream patch
is for the first way, driver mustn't use TCPCI framework(embeded firmware
will control all the TCPCI register). The second way(erased internaly
firmware) can work under TCPCI framework.

Thanks,
Xin
> 
> thanks,
> 
> -- 
> heikki