Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp6302749pxb; Mon, 14 Feb 2022 22:16:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxksGCelEKdGXoztwZnUPA1sHTRRDrYB91OENNKbCyGZd5/CPV2dIoGmARfZPPNM8yJ8gda X-Received: by 2002:a17:90b:395:b0:1b9:82f1:7eca with SMTP id ga21-20020a17090b039500b001b982f17ecamr2647517pjb.179.1644905764629; Mon, 14 Feb 2022 22:16:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644905764; cv=none; d=google.com; s=arc-20160816; b=XKsEk2dBYv8qRQXTgwyEjsv/jgorL/hf7p6BmsaHrahB05yWiupqili4szOihBUH7s 7pq5DvYl3bqr1U5XSpMf5hUarbXPvtJwUSwm/085PH2Dp++aCRHEkrpyAYrVlmiFxH8F Iet6QYm1qVfDQ+lYDOw4ek5D4xRe/fdQJH89qq9HnHzuxKwIfOQCwIYxUix5zZ1v3PHF 1q5jK/qF3Or+8IdLbrItcnvLtVwpqxrYpX9BuvovOZ8ZBH7GdGrxy/leVTSCyaGLe2ji MZJl82hPAThOt1lTZaQebPYG3q2POU5JTCrcKgdTzjDtF0tSiN67APF+P9WJdqyP6h3c feEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=ja9OuDjw36pM/gP4pdVDOmixFhji0TTUrt2UvjFwBkk=; b=u/EbV55WXhubSV2FlHIhf+GHPQ6MTFw5OMcp9q8+qrBQTYvAZwMiBUVSE4hPtdaN/r Ho0b+d5wIZZXmOk8UP1S2eQ7dnWR3YrRfRj84q1sNu3kro15CZ6jBAQoO+qpMcNlmwbV v2FDsOLbc/hNSjli+4An3Wo0xCYLnTSG/5JhB+OaPVvsJHJgz+AGp5MwAJApY39ECRia f+ll+/AiymtfWjoP6tYMYKQFPOOIl4bhmeOYADMkFdrffNvSdAn0dtdwSH2G/OyMTteh mpnXaZC7uav7c4/w6xwWKfSMOW8VO7kZjLMEWVBek89ifKJXj8heV1+8wtl/TWrkgEEi zMcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c21si1811784pgj.291.2022.02.14.22.15.50; Mon, 14 Feb 2022 22:16:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233917AbiBOErX (ORCPT + 99 others); Mon, 14 Feb 2022 23:47:23 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbiBOErW (ORCPT ); Mon, 14 Feb 2022 23:47:22 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5E21390266 for ; Mon, 14 Feb 2022 20:47:13 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 07FD01063; Mon, 14 Feb 2022 20:47:13 -0800 (PST) Received: from [10.163.48.145] (unknown [10.163.48.145]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BFE7E3F718; Mon, 14 Feb 2022 20:47:10 -0800 (PST) Subject: Re: [PATCH] mm/pages_alloc.c: Don't create ZONE_MOVABLE beyond the end of a node To: Alistair Popple , akpm@linux-foundation.org Cc: jhubbard@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ziy@nvidia.com References: <20220215025831.2113067-1-apopple@nvidia.com> From: Anshuman Khandual Message-ID: <7b752e06-f345-cbb2-d05c-57e5fc5d8e5a@arm.com> Date: Tue, 15 Feb 2022 10:17:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220215025831.2113067-1-apopple@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alistair, On 2/15/22 8:28 AM, Alistair Popple wrote: > ZONE_MOVABLE uses the remaining memory in each node. It's starting pfn > is also aligned to MAX_ORDER_NR_PAGES. It is possible for the remaining > memory in a node to be less than MAX_ORDER_NR_PAGES, meaning there is > not enough room for ZONE_MOVABLE on that node. How plausible is this scenario on normal systems ? Should not the node always contain MAX_ORDER_NR_PAGES aligned pages ? Also all zones which get created from that node should also be MAX_ORDER_NR_PAGES aligned ? I am just curious how a node could end up being like this. - Anshuman