Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp6355612pxb; Tue, 15 Feb 2022 00:04:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxHP9fjGJDZvfFifyLHym3p2HZgY+h4vPQD2sK6y9mD2CBuDUT314EDMwtsmUa/L47pR31p X-Received: by 2002:a17:907:7e9a:: with SMTP id qb26mr2130768ejc.294.1644912261412; Tue, 15 Feb 2022 00:04:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644912261; cv=none; d=google.com; s=arc-20160816; b=nZlhdnu4kAVPKDe5C8GcHulCt2t6e7oRVcQ+/IXQ5FNo3f6s0WhWcs2o8TGt837ALB D5a4ZwjERiZBxREgOrFD/Cru3CYD9cg6mCaeYRIo38fpbuOl/ngb65I8mEcuU8d/A7aT /JyDZUH4//vH4aMvLSQcDT2rnfOaFFqj6T1wBFe2Q6nLxKxoc9g0iEM4daPye60GLFwM h8LDeDut8qEa7Xi3XK9v/ULFZcdhyLMicUM3Aef9SnDhAK9eCisO0ElOtthReeQXPyGe sSYIeK6Mirv741qmysdifAtBaY1B3Y8X8D7Pt5PglyN+BQ1em6P6KPYP2PQrmuAKh73s h4CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=h1dBf+j7d9lmuUG9Sexlmri+AO+FnOtXkMgXM8bMiaE=; b=O/iqrhMVEPPYIqbFDtiJxva1b6MHcqCdmShEzPgGru1pwY/x2l1UbSgIUKlMZnY+sA 2odLdEQrmm1t+VctPmQ5yfew6zATk9pSJqzc6kgHZBmtBG23z7yOlYsRcE8O78+gTEc5 vAmdSFUoXwI7CFvyboXorLlGBheb1wrHsFgltcwdX3vnBHR7pAbAsaZjwU3Jg2EHBVrl GYtR6myviJttW8prmM4SGMF+C1LFXXiUSCD1+D/eEPH02cHgJj0gc/IUVUhR8VnOjTES DLUqOCOg7v7uU3WI9pDwAuMXVNXEe4VmLDU4dtIFRhiRFI6kec6589SbUdaUkXWdxBJm NcyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bo5si6611851edb.564.2022.02.15.00.03.57; Tue, 15 Feb 2022 00:04:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234039AbiBOFa0 (ORCPT + 99 others); Tue, 15 Feb 2022 00:30:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233988AbiBOFaR (ORCPT ); Tue, 15 Feb 2022 00:30:17 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 064DA123419; Mon, 14 Feb 2022 21:30:09 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4JyV6631Pkz4xcq; Tue, 15 Feb 2022 16:30:06 +1100 (AEDT) From: Michael Ellerman To: Christophe JAILLET , paulus@samba.org, mpe@ellerman.id.au, groug@kaod.org, benh@kernel.crashing.org, tglx@linutronix.de, christophe.leroy@csgroup.eu, clg@kaod.org, allison@lohutok.net Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <564998101804886b151235c8a9f93020923bfd2c.1643718324.git.christophe.jaillet@wanadoo.fr> References: <564998101804886b151235c8a9f93020923bfd2c.1643718324.git.christophe.jaillet@wanadoo.fr> Subject: Re: [PATCH v2] powerpc/xive: Add some error handling code to 'xive_spapr_init()' Message-Id: <164490280126.270256.11152425799703453918.b4-ty@ellerman.id.au> Date: Tue, 15 Feb 2022 16:26:41 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Feb 2022 13:31:16 +0100, Christophe JAILLET wrote: > 'xive_irq_bitmap_add()' can return -ENOMEM. > In this case, we should free the memory already allocated and return > 'false' to the caller. > > Also add an error path which undoes the 'tima = ioremap(...)' > > > [...] Applied to powerpc/next. [1/1] powerpc/xive: Add some error handling code to 'xive_spapr_init()' https://git.kernel.org/powerpc/c/e414e2938ee26e734f19e92a60cd090ebaff37e6 cheers