Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67ace5d3-02b3-034d-969f-9a05bbdd8e30@kernel.org>
Date:   Tue, 15 Feb 2022 06:55:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH] tty: serial: 8250: add missing pci_dev_put() before
 return
Content-Language: en-US
To:     Qing Wang <wangqing@vivo.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1644890454-65258-1-git-send-email-wangqing@vivo.com>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <1644890454-65258-1-git-send-email-wangqing@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15. 02. 22, 3:00, Qing Wang wrote:
> From: Wang Qing <wangqing@vivo.com>
> 
> pci_get_slot() increases its reference count, the caller must
> decrement the reference count by calling pci_dev_put()
> 
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> ---
>   drivers/tty/serial/8250/8250_lpss.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_lpss.c b/drivers/tty/serial/8250/8250_lpss.c
> index d3bafec..57e462f
> --- a/drivers/tty/serial/8250/8250_lpss.c
> +++ b/drivers/tty/serial/8250/8250_lpss.c
> @@ -149,6 +149,8 @@ static int byt_serial_setup(struct lpss8250 *lpss, struct uart_port *port)
>   	/* Disable TX counter interrupts */
>   	writel(BYT_TX_OVF_INT_MASK, port->membase + BYT_TX_OVF_INT);
>   
> +	pci_dev_put(dma_dev);


What about the "return -ENODEV" few lines above?

>   	return 0;
>   }
>   


-- 
js
suse labs