Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <922c4a440b455d158729abcc0c9f78dc3726c2c0.camel@themaw.net>
Subject: Re: [ANNOUNCE] autofs 5.1.8 release
From:   Ian Kent <raven@themaw.net>
To:     NeilBrown <neilb@suse.de>
Cc:     autofs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 15 Feb 2022 15:00:29 +0800
In-Reply-To: <164487880421.17471.502085345359040789@noble.neil.brown.name>
References: <b54fb31652a4ba76b39db66b8ae795ee3af6f025.camel@themaw.net>
        , <164444398868.27779.4643380819577932837@noble.neil.brown.name>
        , <b042424ce0e68f576fdab268adeeff90d48da8a8.camel@themaw.net>
         <164487880421.17471.502085345359040789@noble.neil.brown.name>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.3 (3.42.3-1.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 2022-02-15 at 09:46 +1100, NeilBrown wrote:
> On Mon, 14 Feb 2022, Ian Kent wrote:
> > On Thu, 2022-02-10 at 08:59 +1100, NeilBrown wrote:
> > > On Tue, 19 Oct 2021, Ian Kent wrote:
> > > > Hi all,
> > > > 
> > > > It's time for a release, autofs-5.1.8.
> > > > 
> > > ...
> > > > - also require TCP_REQUESTED when setting NFS port.
> > > 
> > > Unfortunately that last patch is buggy.  TCP_REQUESTED is masked
> > > out
> > > in
> > > the caller.
> > 
> > Mmm ... sounds like I've made a mistake there.
> > I'll need to sort that out, thanks for pointing it out.
> > 
> > > 
> > > Maybe the following is best.
> > > 
> > > NeilBrown
> > > 
> > > From: NeilBrown <neilb@suse.de>
> > > Subject: [PATCH] Test TCP request correctly in nfs_get_info()
> > > 
> > > The TCP_REQUESTED flag is masked out by the caller, so it never
> > > gets
> > > to
> > > nfs_get_info().
> > 
> > That wasn't my intent, I'll need to look at it again.
> > The case I'm trying to cover is fairly specific so I will need to
> > look at it again.
> > 
> 
> I'm curious: What was the case you were trying to solve??  I couldn't
> guess any justification for the change.

Somewhere along the way I broke NFSv4 mounts being able to be mounted
without the use of rpcbind.

I require the option fstype=nfs4 for this and if given the map entry
should be mountable without recall to any other services beside NFS.

So that option shouldn't be masked out since it allows automount
to identify (or should) this case.

Ian