Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7df71f8d-cdc3-4b2e-cf0a-7112eff28142@canonical.com>
Date:   Tue, 15 Feb 2022 09:02:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 00/15] pwm: dt-bindings: Include generic pwm schema
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To:     =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Maxime Ripard <mripard@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Vijayakannan Ayyathurai <vijayakannan.ayyathurai@intel.com>,
        Rahul Tanwar <rtanwar@maxlinear.com>,
        Jeff LaBundy <jeff@labundy.com>,
        Sagar Kadam <sagar.kadam@sifive.com>,
        Vignesh R <vigneshr@ti.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-riscv@lists.infradead.org
References: <20220214212154.8853-1-krzysztof.kozlowski@canonical.com>
 <20220215074030.3nugwproxjh3lwhl@pengutronix.de>
 <CA+Eumj42Hojp1m4deuWnqMOaaNaupTSkzPaNbL_0eyBL-aDi_g@mail.gmail.com>
In-Reply-To: <CA+Eumj42Hojp1m4deuWnqMOaaNaupTSkzPaNbL_0eyBL-aDi_g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 15/02/2022 08:59, Krzysztof Kozlowski wrote:
> On Tue, 15 Feb 2022 at 08:40, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
>>
>> Hello,
>>
>> [dropped Anson Huang and Yash Shah from Cc: which were not reachable for
>> my last mail]
>>
>> On Mon, Feb 14, 2022 at 10:21:39PM +0100, Krzysztof Kozlowski wrote:
>>> Hi,
>>>
>>> Changes since v1:
>>> 1. Add tags.
>>> 2. Adjust subject (Uwe).
>>
>> However you only took a part of my suggestion ...
>>
>>> Krzysztof Kozlowski (15):
>>>   dt-bindings: pwm: allwinner,sun4i-a10: Include generic pwm schema
>>>   dt-bindings: pwm: imx: Include generic pwm schema
>>>   dt-bindings: pwm: intel,lgm: Include generic pwm schema
>>>   dt-bindings: pwm: iqs620a: Include generic pwm schema
>>>   dt-bindings: pwm: mxs: Include generic pwm schema
>>>   dt-bindings: pwm: rockchip: Include generic pwm schema
>>>   dt-bindings: pwm: sifive: Include generic pwm schema
>>>   dt-bindings: pwm: renesas,pwm: Include generic pwm schema
>>>   dt-bindings: pwm: toshiba,visconti: Include generic pwm schema
>>>   dt-bindings: pwm: brcm,bcm7038: Do not require pwm-cells twice
>>>   dt-bindings: pwm: intel,keembay: Do not require pwm-cells twice
>>
>> ... The actual patch has a space after the comma, I like this variant
>> without comma better as this is a compatible string.
> 
> I am confused. My patch does not have comma after space. Your reply
> had such in the subject, but not in the proposed new subject you wrote
> in msg, so I left it as is. Without comma. If you still see comma, it
> is something with your mail client.
> 
> See:
> https://lore.kernel.org/linux-devicetree/20220214212154.8853-12-krzysztof.kozlowski@canonical.com/T/#u
> 
> Also reply from Vijayakannan does not have comma:
> https://lore.kernel.org/linux-devicetree/20220214081605.161394-11-krzysztof.kozlowski@canonical.com/T/#m80af695f2c751341bc971114aefa00ccc929a3ec
> 
>> Also a # before
>> pwm-cells would be nice.
> 
> I can add this.

Just one more clarification - you proposed also to remove "pwm:"
middle-prefix. Shall I remove it from every patch and use instead full
file name?


Best regards,
Krzysztof