Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 10:56:15 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        ludovic.desroches@microchip.com, tudor.ambarus@microchip.com
Subject: Re: [PATCH -next] dmaengine: at_xdmac: Fix missing unlock in
 at_xdmac_tasklet()
Message-ID: <Ygs5d3MFR7R+Z5YA@matsya>
References: <20220107024047.1051915-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220107024047.1051915-1-yangyingliang@huawei.com>
Precedence: bulk

On 07-01-22, 10:40, Yang Yingliang wrote:
> Add the missing unlock before return from at_xdmac_tasklet().

Applied, thanks

> 
> Fixes: e77e561925df ("dmaengine: at_xdmac: Fix race over irq_status")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  drivers/dma/at_xdmac.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index a1da2b4b6d73..1476156af74b 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1681,8 +1681,10 @@ static void at_xdmac_tasklet(struct tasklet_struct *t)
>  		__func__, atchan->irq_status);
>  
>  	if (!(atchan->irq_status & AT_XDMAC_CIS_LIS) &&
> -	    !(atchan->irq_status & error_mask))
> +	    !(atchan->irq_status & error_mask)) {
> +		spin_unlock_irq(&atchan->lock);
>  		return;
> +	}
>  
>  	if (atchan->irq_status & error_mask)
>  		at_xdmac_handle_error(atchan);
> -- 
> 2.25.1

-- 
~Vinod