Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220209032745.38570-1-cai.huoqing@linux.dev> <302e8426-5a22-23dd-2b3b-7eb6d0ee2e8d@amd.com>
In-Reply-To: <302e8426-5a22-23dd-2b3b-7eb6d0ee2e8d@amd.com>
From:   Jens Wiklander <jens.wiklander@linaro.org>
Date:   Tue, 15 Feb 2022 07:49:41 +0100
Message-ID: <CAHUa44G0UY9a7v6KTCx4LdChDZyS1Y0zCmKEXzyddsshFLgv8g@mail.gmail.com>
Subject: Re: [PATCH] tee: amdtee: Make use of the helper macro LIST_HEAD()
To:     Rijo Thomas <Rijo-john.Thomas@amd.com>
Cc:     Cai Huoqing <cai.huoqing@linux.dev>,
        Sumit Garg <sumit.garg@linaro.org>,
        Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 9, 2022 at 8:16 AM Rijo Thomas <Rijo-john.Thomas@amd.com> wrote:
>
>
>
> On 2/9/2022 8:57 AM, Cai Huoqing wrote:
> > Replace "struct list_head head = LIST_HEAD_INIT(head)" with
> > "LIST_HEAD(head)" to simplify the code.
> >
> > Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
> > ---
> >  drivers/tee/amdtee/call.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tee/amdtee/call.c b/drivers/tee/amdtee/call.c
> > index 07f36ac834c8..cec6e70f0ac9 100644
> > --- a/drivers/tee/amdtee/call.c
> > +++ b/drivers/tee/amdtee/call.c
> > @@ -122,7 +122,7 @@ static int amd_params_to_tee_params(struct tee_param *tee, u32 count,
> >  }
> >
> >  static DEFINE_MUTEX(ta_refcount_mutex);
> > -static struct list_head ta_list = LIST_HEAD_INIT(ta_list);
> > +static LIST_HEAD(ta_list);
> >
>
> Reviewed-by: Rijo Thomas <Rijo-john.Thomas@amd.com>

I'm picking up this.

Thanks,
Jens

>
> Thanks,
> Rijo
>
> >  static u32 get_ta_refcount(u32 ta_handle)
> >  {
> >