Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Haiyue" <haiyue.wang@intel.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Jeroen de Borst <jeroendb@google.com>,
        Catherine Sullivan <csully@google.com>,
        "David Awogbemila" <awogbemila@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Willem de Bruijn <willemb@google.com>,
        "Forrest, Bailey" <bcf@google.com>, Tao Liu <xliutaox@google.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        John Fraker <jfraker@google.com>,
        "Yangchun Fu" <yangchun@google.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1] gve: fix zero size queue page list allocation
Thread-Topic: [PATCH v1] gve: fix zero size queue page list allocation
Thread-Index: AQHYIVEt5rY3o3cDa06/TofCdTpoOKyUFSsAgAAAT1A=
Date:   Tue, 15 Feb 2022 05:25:49 +0000
Message-ID: <BYAPR11MB34959983354A8C81B065AB5EF7349@BYAPR11MB3495.namprd11.prod.outlook.com>
References: <20220214024134.223939-1-haiyue.wang@intel.com>
 <20220214212136.71e5b4c6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20220214212136.71e5b4c6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.200.16
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XthrZzAdSSPy26seX6oRtbQYxiby3FbvHD5oBT3eA4eW5waVudMudL2VFmtA?=
 =?us-ascii?Q?AqqyriyzfM4xty4Ec47qJi+bqQ2B/LWA1HkzYTyMfCSzd7yRe5lxS06ktms8?=
 =?us-ascii?Q?w/XDqNsvtu94R6hy0GthIu0Psf+DMxIghdD0i9IdkJjPVFcW8Y6oKDS88d3i?=
 =?us-ascii?Q?FI4NTD7dkJCd2kF0mQofLo3iInPWEEfTBDCeSG7TTWSG7AzkCf6oHhrUiCFE?=
 =?us-ascii?Q?Y//RxQDltN6zqkTx4Qc67uMXjJcsWoDd4hhYdMzvVJCwQUPIBGr1TGJmazr3?=
 =?us-ascii?Q?IYeL1OE/KclelXs1Y/zYKPIUIBSVC0ZY9sUED1fOKldeOwLRmcCbmLFKJAz+?=
 =?us-ascii?Q?yaopb+9VAybG5XKhnC9o6SiIxoITCrCUaFBu1oeO2OR61bAjlGwEz+U+8TUU?=
 =?us-ascii?Q?LxHGS17hrRoa2aVWaPDhiMh/Vsm43IId1K9osniZLa2uX+Z1LohVc+Ogq7qE?=
 =?us-ascii?Q?bERm5KFovVDtElqAjbrTbHU9Jh6v1+FjSq4GcSDi4AEzN/ZIwybko7HYMs5l?=
 =?us-ascii?Q?P0Y1ACdFy10WtagnPM+H2pFCDtxhpseJSyLNaHtUYO7WHOVU/Dp01WXmZFQW?=
 =?us-ascii?Q?Pq92R9p1lKMvlpfDq6Vys/DF9m4Dud74+g/z0Rx29TXnMTR+MBiNbAMfGX87?=
 =?us-ascii?Q?iEdSohiJtonvdu1qCxpfK+FRpqdbNvLYtYo7nW+SYpbtiywE3URS+OOhIpT+?=
 =?us-ascii?Q?fCqB/+wgDoaKayBJZQ7naC7nfrmDTKVz3Uc5pIBh0It6b0ejuF0qkocjVlzk?=
 =?us-ascii?Q?fWF7hfL/6XX1es3zoOgwVur2palG8jEwHPEawaPukvNutv7qjFdSd9DKpeKB?=
 =?us-ascii?Q?oOdf231cawdQ9pfpIl0NjCrkOsXQ7oWcMe6tgejs2ExPlVyuyLS06GR6+eGk?=
 =?us-ascii?Q?iQWHRA3DvfrkZSR/q70r9pdXHTjgXjueHTQ99WXndqpwA/TdWwEhWyZTHyut?=
 =?us-ascii?Q?pUzvy/ihFuAh8V6zuT0stvxYJw6IRBdylW8hQCOB6e/j2hzYBXvWnQCQpWHq?=
 =?us-ascii?Q?sZMwpS1VVaeWNZbx5q/RIdvbzLB2VgIPjz1qPE9/mH/ALzuh3RZIlkvzdFmP?=
 =?us-ascii?Q?Orlgjg+Mq2IkZYXfM2qA+tKhaNNbJ5hgjmY9rmzdt7h1kJDZeO3jsZiTbfuL?=
 =?us-ascii?Q?gGnLB5zWuYvj0fbpkv+g1TtUM7/urG9ZZPaoLlRnuUi4grfaQ6IZwzntQMe9?=
 =?us-ascii?Q?rI6GkIfPEHA+ki/ueC15ko8vCe1wR5s5DTZIYvnK2Cv3oJwISGSjsBDPv+50?=
 =?us-ascii?Q?VRP10ifzn4LWPWzbNSO0hfxx7hcnt+kfwYphDSo6mXDGGKoRf3BW6d4kxXo/?=
 =?us-ascii?Q?4ljhb0CdDCEada7mrQKlr/2A6QZf7Kwbm8BMv88PE2cEQRTpXwwL7IRPN1Up?=
 =?us-ascii?Q?eOGOL9+uO5fguSpw6GekVIsii1pBz+rMEl+fM4D0EKy+wyzcPJmGLODvB3IV?=
 =?us-ascii?Q?BvDynbSysoRf1JoxexZiIy5yLH6CnQ6ghGGLNXRgu68kRmLXIRGskXhfAoIU?=
 =?us-ascii?Q?g1x6fzWj4KOadcVEZuzt0KIqQKd/Nl/On7MMtqEkdmX6dLwQvdPgGWlu8e7w?=
 =?us-ascii?Q?pyxyqJN81oVzNAU17UDPYqesN7ZT0v9aHGUR7X1FmCJcQ7kjkHO0DIawI2Y5?=
 =?us-ascii?Q?GQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b18702c-2c8e-47aa-6538-08d9f043a0be
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 05:25:49.9162
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UNv+N7g4FjhmWagFyCwRGr1CH0MMi9NqSvvfbKjvBl+StO2hREllncA58Cq0yhR0ttqpyJeLnNZKaiTmzG1HYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2998
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM,
        HK_RANDOM_FROM,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, February 15, 2022 13:22
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: netdev@vger.kernel.org; Jeroen de Borst <jeroendb@google.com>; Cather=
ine Sullivan
> <csully@google.com>; David Awogbemila <awogbemila@google.com>; David S. M=
iller <davem@davemloft.net>;
> Willem de Bruijn <willemb@google.com>; Forrest, Bailey <bcf@google.com>; =
Tao Liu <xliutaox@google.com>;
> Christophe JAILLET <christophe.jaillet@wanadoo.fr>; John Fraker <jfraker@=
google.com>; Yangchun Fu
> <yangchun@google.com>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH v1] gve: fix zero size queue page list allocation
>=20
> On Mon, 14 Feb 2022 10:41:29 +0800 Haiyue Wang wrote:
> > According to the two functions 'gve_num_tx/rx_qpls', only the queue wit=
h
> > GVE_GQI_QPL_FORMAT format has queue page list.
> >
> > The 'queue_format =3D=3D GVE_GQI_RDA_FORMAT' may lead to request zero s=
ized
> > memory allocation, like if the queue format is GVE_DQO_RDA_FORMAT.
> >
> > The kernel memory subsystem will return ZERO_SIZE_PTR, which is not NUL=
L
> > address, so the driver can run successfully. Also the code still checks
> > the queue page list number firstly, then accesses the allocated memory,
> > so zero number queue page list allocation will not lead to access fault=
.
> >
> > Use the queue page list number to detect no QPLs, it can avoid zero siz=
e
> > queue page list memory allocation.
>=20
> There's no bug here, strictly speaking, the driver will function
> correctly? In that case please repost without the Fixes tag and

Code design bug, the 'queue_format =3D=3D GVE_GQI_RDA_FORMAT' is not correc=
t. But,
yes, it works. So still need to remove the tag ?

> with [PATCH net-next] in the subject.
>=20
> > Fixes: a5886ef4f4bf ("gve: Introduce per netdev `enum gve_queue_format`=
")
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>