Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <db6c18cd-73ca-f7b3-d5b6-fad9b3733d41@suse.com>
Date:   Tue, 15 Feb 2022 10:43:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] xhci: reduce xhci_handshake timeout in xhci_reset
Content-Language: en-US
To:     Jung Daehwan <dh10.jung@samsung.com>,
        Pavan Kondeti <quic_pkondeti@quicinc.com>
CC:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_ugoswami@quicinc.com
References: <1644836663-29220-1-git-send-email-quic_pkondeti@quicinc.com>
 <1644841216-1468-1-git-send-email-quic_pkondeti@quicinc.com>
 <d82746d2-4096-1477-42dd-fd393e0ff827@linux.intel.com>
 <CGME20220214135321epcas2p19dc7b60c27304181a8863248103e7493@epcas2p1.samsung.com>
 <20220214135310.GC31021@hu-pkondeti-hyd.qualcomm.com>
 <20220215085108.GH144890@ubuntu>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220215085108.GH144890@ubuntu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YwvjIlZB4fL4Nu0HmG/C7dn5zFSEFRHP7IkuwnF+ZzLy4t/rKNuGJFWKmoUz?=
 =?us-ascii?Q?FawXZz73Yxqr8sgj2FLf9A14ZySLbZCR3x85nuFFxlGonPuiHmZYfzToPVkf?=
 =?us-ascii?Q?UvfIdiKbMUEK8dXI9PN6l0SiOyJz4koa8WxNzGFDeRh0s6PN/nuyahcNaYdF?=
 =?us-ascii?Q?WtkB5oXEk52bRVy/kqmj5firH6CkOXCnTEF8INhUF9zUHQHfz3q9YMlHqlnZ?=
 =?us-ascii?Q?/PBMxhGtpLyqmWCvwA3CTa2mRe8WEpRXnhDZ/0sQtP+WnHFRzPxibPyXu5C3?=
 =?us-ascii?Q?JaNI+kolLr2q5+RbJX5D4hmhLxzsvbTOC40W0SGnjWsmLQ+jHN9ka21hJqbs?=
 =?us-ascii?Q?Dx4sZy7BToBkPk7eZuSBdjbY6tNKwDvh+uy9RIF7V3Lr+TMnIgfGKbcLc9CB?=
 =?us-ascii?Q?c3vD+YXZyiBD/w1zw338NlwHz9rypQvwGTaPXpjJZL4F4DjpsNI63jlL2jZ1?=
 =?us-ascii?Q?egAtAGNmExh1FLzmm13oQSRgi8PZO9LQAr4E6UagN/GA5Cz7SspU9cK7KJk8?=
 =?us-ascii?Q?5S+CtKsvrhmhbRDfcapsJ5fMLo/So3ZwE4D85INYRrOrdGgkQVrVSKWItld3?=
 =?us-ascii?Q?Y41M8kPCpMg3pobUWWPdDjqFkANX3uCpZGCuRFX5YDZc2l8pa4jjSzzvCmsV?=
 =?us-ascii?Q?E6CLfRGfvyS34mPibGrxKsWszYJFd6RDKjFmMvQlgYAgOKng9/zvP0mPjdmh?=
 =?us-ascii?Q?LzdEA2bISrLLOuh/iqpXmcHrj4qfwAItBwjmIUe1hMPEKhw2AELQ9FlNlFA+?=
 =?us-ascii?Q?GzZjd9jOuuSyFhGpyS6zX5tQ6FSF9HVnyIgLuFD7xpqYF6ulNl2pITcoqj24?=
 =?us-ascii?Q?c549VmK04EpmXDEGmJT38N++WzJHFao32H7fh0dVOE6MVr6jjyoyKqBC1MhN?=
 =?us-ascii?Q?IByXZL+E/PDSGF6tLMjEDRro3pZAJC9vBXbbLzMbufVESedMH2+fcGRNtXMR?=
 =?us-ascii?Q?v+Ud1Yy7HIJnabAuDcRYi5hpUyIiwp+dGHTITcnoPJLi3ipx1FvJ7+Ch3L7E?=
 =?us-ascii?Q?I8XMfXooIB878afuIVROqGOTVUXBDeCsbmlxmev1VqaOmRMzyJzv/R9l0W3w?=
 =?us-ascii?Q?35uWM5nOqyY2FIRdz5l/RaJMEuoEpkWNAoaEt0l+c46qHjpCsYO78551jAJd?=
 =?us-ascii?Q?3+mB9wvCJp12iVWa6UryatVYaxs0gXZAt1GII0pmnPkcKhXnOFMas5Ti+TGt?=
 =?us-ascii?Q?BDPTRfqp5nGY/sFOPsuYlnFWIUImFJPE1H+pCuNuKO2WdHRteN3434oP4W4J?=
 =?us-ascii?Q?7I/DGzYo3IZtAPv1zTeoS1r1+oiWFjqYHgt94YJNdnbFD6oyFS48s2ryGor3?=
 =?us-ascii?Q?5/6LJX+OTvtjjBiND2JAlR2/oose+GpTbq8XuuMZRwokZQQzxW4kYPsHYkl3?=
 =?us-ascii?Q?5548thuuDbJ+GOFDsDAUnf9PvP0bNssxUaev0DHppi0xrpfc1paQoxWQg3tu?=
 =?us-ascii?Q?ONVRYBxPXRP7zjInx0PxQpG9TBs1QeWX1zTG3VQfViWtrwbFko4S/lc2zSHs?=
 =?us-ascii?Q?JYmlpVfqX3PXb5trQcrnPEUhAS1h3Jc1eFiFxkFIGwm/tkvja+WtMpKw3xCK?=
 =?us-ascii?Q?PCFLR9k5980l8hgvG9LcKoHtFJLPPjt758cFDit/wgo0N2+BkNRqjQg5Hw8h?=
 =?us-ascii?Q?GxyBCWEbOx9ZjqBkJQbZQyE1YFCMHn0fLf9OizR6j5MwQyWums5JBLsorEHq?=
 =?us-ascii?Q?uNMhvHRSABNm9SdNldDmVsf4z34=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f264b86-0c3d-447b-6dc4-08d9f067a3aa
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5050.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 09:43:37.0288
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qwVI25x6Ra2d/x/0jTaNpseTD8dTgYdt8xoFQ1/yTZ3tvzQtaGab3tc9dnQO1W6lJ6hzvf+dX8o2EIYsQN2bXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5566
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 15.02.22 09:51, Jung Daehwan wrote:
>
> I also think it doesn't make sense 10 secs timeout with irqs disabled.
> It could cause critical system problem as Pavan said. How about adding
> new quirk for different timeout value?
>
Hi,

I am afraid this amounts to putting bandages onto a fundamental
flaw. We need a version of xhci_reset() that can sleep and if
you need interrupts to be off to reset the HC, you are doing a bad design.

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver