Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 09:13:24 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc:     netdev@vger.kernel.org, linux-can@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Maximilian Schneider <max@schneidersoft.net>
Subject: Re: [RFC PATCH v1] can: gs_usb: change active_channels's type from
 atomic_t to u8
Message-ID: <20220215081324.gkrut2pa3l324rnu@pengutronix.de>
References: <20220214234814.1321599-1-mailhol.vincent@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="z4gra5dh4uqv6g3s"
Content-Disposition: inline
In-Reply-To: <20220214234814.1321599-1-mailhol.vincent@wanadoo.fr>
Precedence: bulk


--z4gra5dh4uqv6g3s
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 15.02.2022 08:48:14, Vincent Mailhol wrote:
> The driver uses an atomic_t variable: gs_usb:active_channels to keep
> track of the number of opened channels in order to only allocate
> memory for the URBs when this count changes from zero to one.
>=20
> However, the driver does not decrement the counter when an error
> occurs in gs_can_open(). This issue is fixed by changing the type from
> atomic_t to u8 and by simplifying the logic accordingly.
>=20
> It is safe to use an u8 here because the network stack big kernel lock
> (a.k.a. rtnl_mutex) is being hold. For details, please refer to [1].
>=20
> [1] https://lore.kernel.org/linux-can/CAMZ6Rq+sHpiw34ijPsmp7vbUpDtJwvVtdV=
7CvRZJsLixjAFfrg@mail.gmail.com/T/#t
>=20
> Fixes: d08e973a77d1 ("can: gs_usb: Added support for the GS_USB CAN
> devices")
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

Looks good to me, added to linux-can/testing.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--z4gra5dh4uqv6g3s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmILYKEACgkQrX5LkNig
013hGwgAlFjf104cx/rCg+L2FHCMMDuztd+6XhCPSU1in2Q2GNXL+HJE4qPPhDPN
VfwENmcf2yH2ecW/kIEducOGt8gl26gC9EzeCIEoiflepU9qfDJ/cqcgqPlP4gcG
kcbm+fAomoIrPCTI/UvLUFLX88Oiza1L3x4VaQqGZxevcmPWXzYNQGKosD0F3Oz1
FodizylGOSIBy+1g2xvAXc51Vhnkwo+5rRfZHJhbRzLFGrS9Fbim+QOOib0/hVLJ
cAbtI6TQ3CDqU2TBa1kN/BUbCrhzb2C0rOL1nPuTrvxyDF8pgxSeAqJsTJ/g+QGS
rOpyugIMCxyvPzjOtbz5oUao6I0NIA==
=tkn1
-----END PGP SIGNATURE-----

--z4gra5dh4uqv6g3s--