Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220126144400.130797-1-lzampier@redhat.com> <CAO-hwJ+KyV+Ks38DDF8EuT9kEc9jd9SvNn=nGyTwjkD3GOQ+RA@mail.gmail.com>
 <15ef80cc2ecdcc993043aa0c1d5ea88f41f9b67b.camel@riseup.net>
In-Reply-To: <15ef80cc2ecdcc993043aa0c1d5ea88f41f9b67b.camel@riseup.net>
From:   Nestor Lopez Casado <nlopezcasad@logitech.com>
Date:   Tue, 15 Feb 2022 10:00:42 +0100
Message-ID: <CAE7qMro-ies_7DXhvqWE=aNhGcZKTFGxj9xmU38w12jHTOWbmA@mail.gmail.com>
Subject: Re: [PATCH] HID: logitech-dj: add new lightspeed receiver id
To:     =?UTF-8?Q?Filipe_La=C3=ADns?= <lains@riseup.net>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Lucas Zampieri <lzampier@redhat.com>,
        Jiri Kosina <jikos@kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jan 26, 2022 at 3:55 PM Filipe La=C3=ADns <lains@riseup.net> wrote:
>
> On Wed, 2022-01-26 at 15:47 +0100, Benjamin Tissoires wrote:
> > On Wed, Jan 26, 2022 at 3:44 PM Lucas Zampieri <lzampier@redhat.com> wr=
ote:
> > >
> > > As of logitech lightspeed receiver fw version 04.02.B0009,
> > > HIDPP_PARAM_DEVICE_INFO is being reported as 0x11.
> > >
> > > With patch "HID: logitech-dj: add support for the new lightspeed rece=
iver
> > > iteration", the mouse starts to error out with:
> > >   logitech-djreceiver: unusable device of type UNKNOWN (0x011) connec=
ted on
> > >   slot 1
> > > and becomes unusable.
> > >
> > > This has been noticed on a Logitech G Pro X Superlight fw MPM 25.01.B=
0018.
> >
> > The patch looks good to me.
> >
> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >
> > Ideally, Nestor, can you confirm this is expected and that we won't
> > have any bad surprises there?
Yes, I confirm this matches our specifications, this is an iteration
of Lightspeed 1.2
No objections on my side.

> >
> > I think we probably want this to be Cc-ed to stable once it gets
> > merged (we can add the tag as we merge it).
> >
> > Cheers,
> > Benjamin
>
> This is likely a different connection type, so it should probably get its=
 own
> case statement, but let's let Nestor confirm :)
>
> Cheers,
> Filipe La=C3=ADns
best,
-nestor