Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 17:20:04 +0900
From:   Jung Daehwan <dh10.jung@samsung.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>,
        quic_wcheng@quicinc.com, quic_jackp@quicinc.com,
        Thinh.Nguyen@synopsys.com
Subject: Re: [PATCH v2 1/2] usb: dwc3: Not set DWC3_EP_END_TRANSFER_PENDING
 in ep cmd fails
Message-ID: <20220215082004.GG144890@ubuntu>
MIME-Version: 1.0
In-Reply-To: <YgtYJ544YsvKTaxS@kroah.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Content-Type: multipart/mixed;
        boundary="----.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_e9aa7_"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <1644836933-141376-1-git-send-email-dh10.jung@samsung.com>
        <CGME20220214111149epcas2p1a1faeda037991885fd6f2f026fa44ec5@epcas2p1.samsung.com>
        <1644836933-141376-2-git-send-email-dh10.jung@samsung.com>
        <Ygo9LZg8lxitTE8J@kroah.com> <20220215065826.GD144890@ubuntu>
        <YgtYJ544YsvKTaxS@kroah.com>
Precedence: bulk

------.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_e9aa7_
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Tue, Feb 15, 2022 at 08:37:11AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Feb 15, 2022 at 03:58:26PM +0900, Jung Daehwan wrote:
> > On Mon, Feb 14, 2022 at 12:29:49PM +0100, Greg Kroah-Hartman wrote:
> > > On Mon, Feb 14, 2022 at 08:08:52PM +0900, Daehwan Jung wrote:
> > > > It always sets DWC3_EP_END_TRANSFER_PENDING in dwc3_stop_active_transfer
> > > > even if dwc3_send_gadget_ep_cmd fails. It can cause some problems like
> > > > skipping clear stall commmand or giveback from dequeue. We fix to set it
> > > > only when ep cmd success. Additionally, We clear DWC3_EP_TRANSFER_STARTED
> > > > for next trb to start transfer not update transfer.
> > > 
> > > So is this two different changes?
> > > 
> > > > 
> > > > Signed-off-by: Daehwan Jung <dh10.jung@samsung.com>
> > > 
> > > What commit id does this fix?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > > 
> > 
> > Hi greg,
> > 
> > Below is commit id to fix.
> > 
> > commit c58d8bfc77a2c7f6ff6339b58c9fca7ae6f57e70
> > Author: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> > Date:   Wed Dec 18 18:14:44 2019 -0800
> 
> <snip>
> 
> Then please properly put that as a "Fixes:" tag in the signed-off-by
> area when you resubmit this.
> 
> thanks,
> 
> greg k-h
> 

I got it. Thanks.

Best Regards,
Jung Daehwan

------.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_e9aa7_
Content-Type: text/plain; charset="utf-8"


------.rW42XXn7_Ji6OxwuAF4RAMbP.qed.OeqKlvEhSLhB3noATS=_e9aa7_--