Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Alexey Khoroshilov <khoroshilov@ispras.ru>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.10 073/116] net: dsa: lantiq_gswip: dont use devres for
 mdiobus
Thread-Topic: [PATCH 5.10 073/116] net: dsa: lantiq_gswip: dont use devres for
 mdiobus
Thread-Index: AQHYIYdYZ2ltgIxviEy60n8vo49ImqyUW8AAgAAC0YA=
Date:   Tue, 15 Feb 2022 09:45:50 +0000
Message-ID: <20220215094549.7no3e2repjvpunyk@skbuf>
References: <20220214092458.668376521@linuxfoundation.org>
 <20220214092501.284425363@linuxfoundation.org>
 <1e75b66a-295b-02bc-b4c5-421aec2cae96@ispras.ru>
In-Reply-To: <1e75b66a-295b-02bc-b4c5-421aec2cae96@ispras.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5oZ1InNrhcsM3Ye11154ot+SNjsBU/JdRYWdxBu1qXfFr9gkLqskgR+ivFyH?=
 =?us-ascii?Q?B6mtBr69qPp1c61PzVPgATgrEWkEeG9tuB0kJiwQiEeRhUgaGPpVBdPpCIl9?=
 =?us-ascii?Q?j2HJaPqfoVWzN+yHexcAmEKgiiuMalsWXqdgHvivAH0XfFcEpJdbsvYmccsa?=
 =?us-ascii?Q?AZq25in8B7KyFRzL1pC1c1TL9NigfsKHy9HS2vaSbkcjKwTq1p3xx65/Xin9?=
 =?us-ascii?Q?5VfOs8fCQrX0YH6RYQQzGHy5mLUHjmB8ZOvVeCohAzOih65ENJgbzO8o+Ea8?=
 =?us-ascii?Q?AgUUGmj9k5EEUPP7OqpIaC0iinWys4QEvKa/zNDiL+v2kN7kO/LtL4FN0dVI?=
 =?us-ascii?Q?j1u+EHRCnxCBFYgbf/FOz3CXCxrdkyW521WUt1h7xnjt4ZLQ3X00Zy39CP1Y?=
 =?us-ascii?Q?xikdnbE8DKXaXd0TxurvDQQnJxgJSt0I3hKpzg1aXfMeRnK/6hvgXhyeD8xD?=
 =?us-ascii?Q?obY/NifNRWl3jQ85DXwlpZKvZNtsZtA5kvCPLb8VMR3+6EdAs00RLohggcUO?=
 =?us-ascii?Q?j3ftVzrTbTLJntDG3xadtbCIfIMX9SKBTu3j/iVbQRy3fy/IjxL2REJRE8w0?=
 =?us-ascii?Q?eCA/A4vrbm2/NweFtteuigZjx5MKzlqTOOu75j89X+lwQKVba1Hy5h+B0w60?=
 =?us-ascii?Q?aUt8xxIq6tSNpCIEC7OCb5H/9bNb4yz0dVR4SBh3xHPatzlo0mlQPIG2r5wu?=
 =?us-ascii?Q?11q+hiM69LfOH36YnTGFGe9pYNnJG08VR5KMkTHS0+eA/EwbgvvYuIZ5FPQs?=
 =?us-ascii?Q?B6iUZmIQ+yPj5GzJ8z0/Uhj5nbK2sTB34s9lCylSdr3BAjBmMfU3GZ5dRod5?=
 =?us-ascii?Q?Qjhn7vGk/tgKhm0qJIu8xGNkhIpVLV1xRSoXj/JkbdeBZgJB8+Ewm8ifRDrS?=
 =?us-ascii?Q?BmYo6Mhd4kqtqglD5AcDDhuRDGJIkM5hrH5tckDOtyncInOf8vzuUCdVRmnR?=
 =?us-ascii?Q?D+UYb+virWs5gxwyKcNWOEYBVPvTGQKP+VjwNtpW9i3DV25rJ3csdrFzByOK?=
 =?us-ascii?Q?GjQlpeL36YYpdYF1SiPwTpusDH7bARqELKoU1UQacQblh/cjHl3zWVjt+/iq?=
 =?us-ascii?Q?gHnpo4OxP/PwDrcYP/F7bvs/fviFHgHZAAT8PgtyMKUfboyF5OiOxvU6L14/?=
 =?us-ascii?Q?mWpIH7yysriTL4zBnys2tx+M3uCjGgR/25I4JgLM5V2DMYkyQTdk0mm4JHI8?=
 =?us-ascii?Q?XrIKBIKW2THGhitMnaqP6cJGbiNX6FcbHFF6DwEUpoVQuebEOiE9kmjgi7dr?=
 =?us-ascii?Q?hyO7xMDbu1uleH/JJyUEO71OKus7ogGImVzXGFGooQgJvz031Eo85ou5dRQy?=
 =?us-ascii?Q?5Huf9rlUvcXE8kan8iIQ3mEV0V8U/+Y3I19IdNTZezhRGSUehEwLRqvYfaXn?=
 =?us-ascii?Q?UlxaQE0Kr5fqCYS8XURcQXbVgZwHm4LCfr7SGbx5J1oBc4HmhATrs0a2n8WS?=
 =?us-ascii?Q?jKnydscjMGU6OmESaouwzcGmns3e7RXm8ZMqR5xMTRxm0bV8vFZxG0kuUKGg?=
 =?us-ascii?Q?CxJZHXgnkL42YvizCAFsUCTXpvHExXuB2tcJj9XWNkzbd7++Y+048HZ05jrY?=
 =?us-ascii?Q?/pP4GoEUbzab80hmOmYZaVj5llYFcndlrc6n6Zd4LKHvg9grJGHdLkGMzLxZ?=
 =?us-ascii?Q?y6hXIyqEFOoIt6gATyEqqXI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <437CCBA312A88046BB0AE03F915423BE@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 45108298-a6e5-48bb-1b9f-08d9f067f341
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 09:45:50.1657
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: E87Lm12gtTW+QNVOEzZf+GbkG4EPyqAAqBfXxRlJ5RE7IoHi6BWRrv8Q6z7GzgshnOT2p1QxAcXEY0IHuk3lxg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5522
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 15, 2022 at 12:35:44PM +0300, Alexey Khoroshilov wrote:
> >  	if (priv->ds->slave_mii_bus) {
> >  		mdiobus_unregister(priv->ds->slave_mii_bus);
> > +		mdiobus_free(priv->ds->slave_mii_bus);
> >  		of_node_put(priv->ds->slave_mii_bus->dev.of_node);
> >  	}
>=20
>=20
> Should
>   of_node_put(priv->ds->slave_mii_bus->dev.of_node);
> be here before
>   mdiobus_free(priv->ds->slave_mii_bus);
> ?

Thanks for noticing. Yes, this would avoid a use-after-free.
Do you mind sending a patch to correct this?=