Received: by 2002:a05:6a10:1a4d:0:0:0:0 with SMTP id nk13csp19064pxb; Tue, 15 Feb 2022 04:47:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJydArqZYqY5IQHuijbyPEqmZE1Jq2wzjTJIQcQP7y8ZkxBw7LLgQv8ik1fz10r+ep20ckBu X-Received: by 2002:a17:906:2ed0:: with SMTP id s16mr2789015eji.327.1644929264133; Tue, 15 Feb 2022 04:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644929264; cv=none; d=google.com; s=arc-20160816; b=ben4SRKgOLo8JBIjwlcNnQUegtMxHqTCbvhiX4O28nfWGQVrg1uxVHTnDQ9dldJu9s 5BaDOA1mUdDyVnS2cAyAqTuk5QbsJPSsm5w0Gfl8+FmaWrS7j0mDUUxjeN6dsq8p5vF7 QrDqEThQ7SiqiapYhpBQvNYx/9E8AqCca0+kihMclTlZ7FP6wwDAHvFrH4y0PdtbTcaC /BRiVFprebIfc/t0epToATfRfux+VsrBi8ikhFwoMC6uVZf5ltfK8U+504iijaViOcpN DrfMtLaoFzvPctSR1XLKwz8a6nHTcjfumRHXiWnfFj6xakq0/Jme7Q5amz3HRK26Sppz dHnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=1ycPctm9A6lSfmcbjQ1/PyYYKhdBq9cg/snbRZEnerU=; b=I92ricWCHue7uVEbs6yqee4sBgNtJYuAr7QZeWKCcAzRgqvhtWg8cldvLa304fwpGv npO+n6KG80SBG7nVnXLdWto1Aeau0D/0s7eyRiD82We9rqEWhEPAcy4NRpf21/aO74LI OTU4ytTHSjt6aIQzae9kx4SuCZpSHuXKslYDjTn7R0rksL+UuDwisDhbuwQDM1+tdiwg iWIkgDGYifzOrCE715fG4ILoLMWXzwGKNpJAdYeMRNekt+icXvZd3ESrYp8eheZvsqdE OeU5urYTfkA9Vio2ukgdUdio8gOkh8Btn8s3Zjppy26ymAgyInMUm1Dk3EuwXQt2qvSD ErEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw2si6738932ejc.708.2022.02.15.04.47.19; Tue, 15 Feb 2022 04:47:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234684AbiBOJRr (ORCPT + 99 others); Tue, 15 Feb 2022 04:17:47 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234357AbiBOJRq (ORCPT ); Tue, 15 Feb 2022 04:17:46 -0500 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E1E1BCAC for ; Tue, 15 Feb 2022 01:17:35 -0800 (PST) Received: by theia.8bytes.org (Postfix, from userid 1000) id 0760136D; Tue, 15 Feb 2022 10:17:33 +0100 (CET) Date: Tue, 15 Feb 2022 10:17:32 +0100 From: Joerg Roedel To: Lu Baolu Cc: Jason Gunthorpe , Christoph Hellwig , Ben Skeggs , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Alex Williamson , Eric Auger , Liu Yi L , Jacob jun Pan , David Airlie , Daniel Vetter , Thierry Reding , Jonathan Hunter , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 00/10] iommu cleanup and refactoring Message-ID: References: <20220214015538.2828933-1-baolu.lu@linux.intel.com> <1d817995-f89b-a1de-6aff-9a2bfe91367f@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d817995-f89b-a1de-6aff-9a2bfe91367f@linux.intel.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Baolu, On Tue, Feb 15, 2022 at 10:05:42AM +0800, Lu Baolu wrote: > Do you want me to send a new version with below changes: > > - Remove WARN_ON() in dev_iommu_ops(); > - Merge above two patches. > > Or, you can change above yourself? Please make the changes and send a new version. I will apply it to the iommu core branch then. The build-tests with this patch-set went well and I havn't spotted anything else in my review, so I think it is in good shape for linux-next testing. Regards, Joerg