Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a9a4bb87-2189-8c0a-8a94-6c6069fec7f7@linux.ibm.com>
Date:   Tue, 15 Feb 2022 11:03:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] selftests: kvm: Check whether SIDA memop fails for normal
 guests
Content-Language: en-US
To:     Thomas Huth <thuth@redhat.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc:     David Hildenbrand <david@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220215074824.188440-1-thuth@redhat.com>
 <801aa4ea-ca26-7561-95f3-162b0f680929@linux.ibm.com>
 <c01824a7-9d15-1356-2530-04c6112ace65@redhat.com>
From:   Janis Schoetterl-Glausch <scgl@linux.ibm.com>
In-Reply-To: <c01824a7-9d15-1356-2530-04c6112ace65@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2/15/22 10:59, Thomas Huth wrote:
> On 15/02/2022 10.54, Janis Schoetterl-Glausch wrote:
>> On 2/15/22 08:48, Thomas Huth wrote:
>>> Commit 2c212e1baedc ("KVM: s390: Return error on SIDA memop on normal
>>> guest") fixed the behavior of the SIDA memops for normal guests. It
>>> would be nice to have a way to test whether the current kernel has
>>> the fix applied or not. Thus add a check to the KVM selftests for
>>> these two memops.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>   tools/testing/selftests/kvm/s390x/memop.c | 15 +++++++++++++++
>>>   1 file changed, 15 insertions(+)
>>>
>>> diff --git a/tools/testing/selftests/kvm/s390x/memop.c b/tools/testing/selftests/kvm/s390x/memop.c
>>> index 9f49ead380ab..d19c3ffdea3f 100644
>>> --- a/tools/testing/selftests/kvm/s390x/memop.c
>>> +++ b/tools/testing/selftests/kvm/s390x/memop.c
>>> @@ -160,6 +160,21 @@ int main(int argc, char *argv[])
>>>       run->psw_mask &= ~(3UL << (63 - 17));   /* Disable AR mode */
>>>       vcpu_run(vm, VCPU_ID);                  /* Run to sync new state */
>>>
>>> +    /* Check that the SIDA calls are rejected for non-protected guests */
>>> +    ksmo.gaddr = 0;
>>> +    ksmo.flags = 0;
>>> +    ksmo.size = 8;
>>> +    ksmo.op = KVM_S390_MEMOP_SIDA_READ;
>>> +    ksmo.buf = (uintptr_t)mem1;
>>> +    ksmo.sida_offset = 0x1c0;
>>
>> What is the rational for that constant?
>> Any would do, as long as size + offset < PAGE_SIZE, correct?
> 
> Right, it's rather a random value.

Ah, ok.

Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
> 
>  Thomas
>