Received: by 2002:a05:6512:23a5:0:0:0:0 with SMTP id c37csp503590lfv; Tue, 15 Feb 2022 07:34:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJwakQD+sdFm8bClIaEZ98hCwxEdc00LUrCaKEeGLactQFXLdu2fmOKhNN450Pe9tBSR+ID7 X-Received: by 2002:a17:907:1623:: with SMTP id hb35mr3469850ejc.556.1644939260856; Tue, 15 Feb 2022 07:34:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644939260; cv=none; d=google.com; s=arc-20160816; b=pXPqT/MSuFXrTecyv/SmNPi3qNltjcdv/pJkI5heMGqruMZ/6IOzqfzLjvX+86TQJN 2pC61X2ptcpvBwHOsdFHiJ3H50BBuI7ijjhXO1vabLHb44Y32Ad0I9fiNzKgNwrT9Vrp bQ9kKlSE6LHS3tXzBBY+fjsHJTo6tiLK4mgJEcs462uphm6BUUbopkasSvhUqaJEKjDu bQHrFdRjhoCgy0df1P7Mevr+vgN3YR4O8FVXXlkx3X/aDsixTTG98IVf9EJy00vK1fGr IITnMAiIaNKUd+WqT5gXEtn3aI+uqH9KbLaKx5J65oKxpSc3c260jINUCwUhKzsBmEvU m92A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=wTlync2n9gKIDKrIGdHiP6wHFx1Oi4kdKMvDLvo0eYY=; b=Ad5M5U7j8Dl2+gJjWB6ymhvt+y17uxYKoq+thVuvwuUlj8odiW6PglHRhjtA1+HgqY QQcHZHelfgezd/t2IGZDN8GtUIrP0kJ2Edr+f7qhDhCF14MOHRv1421wa79q1+GNKzJA YIQ1s1DR/VlPCM/IpKP6kE/2C4sn0Pk9wmt3O0YSUht1UZzwF3ZxWZAYrek/UvzhjlHM cN2FL+rZnoSyynHt0hY5YyWw8AnBmYnaB7e8JZR05fJvxMeyS4e4dWSP5Z+/DBmIU9Sb La2G3+uaEwTPv1xJR7SzmNP273nxLRZRuFZoAPkF9bJusaFB0cryyHZMcSRLodthC8pO FPGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="m8K/c3As"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11si61684edm.372.2022.02.15.07.33.57; Tue, 15 Feb 2022 07:34:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="m8K/c3As"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239513AbiBOPAd (ORCPT + 99 others); Tue, 15 Feb 2022 10:00:33 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239486AbiBOPAX (ORCPT ); Tue, 15 Feb 2022 10:00:23 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C56F96517C; Tue, 15 Feb 2022 07:00:13 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7E5D6B81ABD; Tue, 15 Feb 2022 15:00:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 27493C340F2; Tue, 15 Feb 2022 15:00:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644937211; bh=nGCeJwddwcrOgxUdguUA+7IGx/+e9mVPmupofSCfSOs=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=m8K/c3AsmMzfRh2ZnGyzPqyCP/2bgN2mZTGR+0q/g794oybul8RXG1rDU3t1v8pwN OBllcD1OP+862nyanc+7JowNAE9cKfV5SdDjpbI+5JWCZaayUoAA9x0uwGRPjWolbk ZeEPZ17Og1apCIRdwbN4/+SJl8uqXZKRsPS82l91PeAJnd263bInRyS3kUlH6hFZd+ fA64wy0+FdIlRElkqIuXaKfFzSPIF1TX0AUwuC++oWsUbGw27qxUqnrUmv/YvRWW6W z/4pJkhQADOX1W+gi0f9qmkEZL4ZdOJWDYWKadhTCXRxgLXztzp3DRZhloaG3a/rtH DOg8HmM2Xiexw== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 0F0DEE6BBD2; Tue, 15 Feb 2022 15:00:11 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] mctp: fix use after free From: patchwork-bot+netdevbpf@kernel.org Message-Id: <164493721105.12867.12615995983107309370.git-patchwork-notify@kernel.org> Date: Tue, 15 Feb 2022 15:00:11 +0000 References: <20220215020541.2944949-1-trix@redhat.com> In-Reply-To: <20220215020541.2944949-1-trix@redhat.com> To: Tom Rix Cc: jk@codeconstruct.com.au, matt@codeconstruct.com.au, davem@davemloft.net, kuba@kernel.org, nathan@kernel.org, ndesaulniers@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by David S. Miller : On Mon, 14 Feb 2022 18:05:41 -0800 you wrote: > From: Tom Rix > > Clang static analysis reports this problem > route.c:425:4: warning: Use of memory after it is freed > trace_mctp_key_acquire(key); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > When mctp_key_add() fails, key is freed but then is later > used in trace_mctp_key_acquire(). Add an else statement > to use the key only when mctp_key_add() is successful. > > [...] Here is the summary with links: - [v2] mctp: fix use after free https://git.kernel.org/netdev/net/c/7e5b6a5c8c44 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html