Received: by 2002:ac2:4468:0:0:0:0:0 with SMTP id y8csp443627lfl; Tue, 15 Feb 2022 07:38:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJw30MHhVZGI0xlCUkRqHgdFhfHUzsLCjVP0qT7+fEckB8MFWPkLTgnIljqrNVdCxOhpAKUd X-Received: by 2002:a17:906:7381:: with SMTP id f1mr3296249ejl.181.1644939501120; Tue, 15 Feb 2022 07:38:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644939501; cv=none; d=google.com; s=arc-20160816; b=V7hwVBhpF1yIBdn7MbxsAbObL1nxDny34BxB1p8euRMGN79B4uC8S+WhxhyZsCaVcM pjxRthmMVgbc+0rEtvsaqjBXhzVq3ywJA/fB9IEbT0auGoFjAmgOOjhsDqnPVCQ2WdJE PxmgDRu7ajkfPTggzAzKTgQjGkrYAbRM8vA4hTnxCChHsIgYrqomqiUqhXU2GVO361g9 UJfGDQW7e7kuZNf227Iz74bO3C96wtg4h2Yy5qhzhebJlKFfw8UhN+4D7Lbom0O5Y4Oj /owI/Ee1+U4mlwYNAgCH6G5ZuJQj4EovOVGoATTk9zpmSoyLq+DGR/I6QD/sm5JmCjfk h/jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=2bjEo/l1VuKsDDnpXHRYc8XcSJyXSTPJfQq6nV/jw5E=; b=M0c9gcrFXY0ULocBx+TPQFTj3TU+ZFqMBQXbgr3DZQjs4MoL1pXfb8f3xe0114vwWD Jipti7mxqwBWee9Muyjm78Q4dgZmmnK5aNH0+sfQoZmoXMV1pX+ooN2CbEM1ElKdLHh4 yAyIhrmpXLyl7PBvScGAKFkPeti8tzfuIdZOVlYVe3LMdgnjVnW+Ta2pjDhnnoXZHJj6 +y4YpZPPhHATVwCqU22rB5zkhhlESsNsBknppuuNUJoYf4j8CRHQMOkDMiCOliFqJMN8 e5U4EXkbcgt8SgjAM+hHmKpeNbvKCah+roAY9ssbnnh8AoOcMA3F4ee1HC3XuLvBoqJN jdCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=M5vUQHwI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 23si21356213eje.318.2022.02.15.07.37.57; Tue, 15 Feb 2022 07:38:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=M5vUQHwI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237062AbiBOL1Q (ORCPT + 99 others); Tue, 15 Feb 2022 06:27:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234913AbiBOL1P (ORCPT ); Tue, 15 Feb 2022 06:27:15 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A9C210D9 for ; Tue, 15 Feb 2022 03:27:04 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Jyf1z0Wlgz4xcY; Tue, 15 Feb 2022 22:27:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1644924423; bh=2bjEo/l1VuKsDDnpXHRYc8XcSJyXSTPJfQq6nV/jw5E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=M5vUQHwI7ONB8kQMJ2wuRbKHkhWQnv9vfiQPxHQjVjnkycLnHlI60AS+hKyV0yFO9 a/JDvNI9HrfJb/XGRVYj8rYKZZ/oUnBgy3sDzTxpuFxk2LHP7dReNi0dbOQ06aNMKZ BCxeS8wb2bhs3FOz6CvIS2a6TgbRPXtbuHY0YGWsoeWokXouX3GAIOWlUdjse87WrN W7EL7hEB14XBpCq8wvmtkT/d7butip3fEdhlj4X3Vsk3nqJSkJUNE95w/FHY3dPKao CoJR36nYvgRQGtHj5UaAmRA2bx2lE7yJ1c4QHG54XUPkZwaGTsYgIu0Tvhdc2GbryG 3YwasqFGBQRuQ== From: Michael Ellerman To: Wedson Almeida Filho Cc: benh@kernel.crashing.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel Subject: Re: [PATCH] powerpc/module_64: use module_init_section instead of patching names In-Reply-To: References: <20220202055123.2144842-1-wedsonaf@google.com> Date: Tue, 15 Feb 2022 22:27:02 +1100 Message-ID: <8735kknzeh.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wedson Almeida Filho writes: > Hi Michael, > > On Wed, 2 Feb 2022 at 05:53, Wedson Almeida Filho wrote: >> >> Without this patch, module init sections are disabled by patching their >> names in arch-specific code when they're loaded (which prevents code in >> layout_sections from finding init sections). This patch uses the new >> arch-specific module_init_section instead. >> >> This allows modules that have .init_array sections to have the >> initialisers properly called (on load, before init). Without this patch, >> the initialisers are not called because .init_array is renamed to >> _init_array, and thus isn't found by code in find_module_sections(). >> >> Signed-off-by: Wedson Almeida Filho >> --- >> arch/powerpc/kernel/module_64.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) ... > > Would any additional clarification from my part be helpful here? Just more patience ;) > I got an email saying it was under review (and checks passed) but > nothing appears to have happened since. I actually put it in next late last week, but the emails got delayed due to various gremlins. cheers