Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d4087e25-5cd0-71fe-f9b7-a7dc03b813cf@amd.com>
Date:   Tue, 15 Feb 2022 10:21:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] drm/amdkfd: Replace zero-length array with flexible-array
 member
Content-Language: en-US
To:     cgel.zte@gmail.com, Felix.Kuehling@amd.com
Cc:     alexander.deucher@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220215091142.1775600-1-deng.changcheng@zte.com.cn>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220215091142.1775600-1-deng.changcheng@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0VhM1FVc3dLU1NrSnlUMkVMdm5leGJGb3RJcXpUWGJWakJZeDE4TlpYcTlR?=
 =?utf-8?B?ME5PZzEzakN5VFZkb0hBUmRTbEl5eFZRb1c3UHF5VnFYWWkyK0NXcWtqbnNa?=
 =?utf-8?B?MHJMb2xFSG5YUzBuU2V1UUcvN0ZVdndVNmU1WTdnc1FMTWVWNXB2c3YxTWNS?=
 =?utf-8?B?dEd0YXRsMnZpb2tOTUdodlNxK3c1N1Y4UWVaVzlmNDVCSVZJcTQvV0h5elBV?=
 =?utf-8?B?MkJ6bnhPUzNiQnNJT3ZrSDY5ajRBRThEVkJidlVXSnREQUthOUxwWkZpbG9P?=
 =?utf-8?B?eUlJMW9aaW4yRUpYd05oeWhrMEFRcFJHSndaaWxPeDZHZDhpVWt0SE1jcG10?=
 =?utf-8?B?RUhOYmNhVExPeVprMSs4eHZRTXJmbHhNZ0ZKeGZOdEsxMDVobEdWeUc3aU53?=
 =?utf-8?B?cXJtM2lENE5MNjJuOHlqUTJpcm9mSGZ1YldTOHhSYjhSQXdWVWFkMVdBa2Ju?=
 =?utf-8?B?UVFyQTc4UmJpcnlwYXdCNkg5cDY4L3Y0azZnNUNSMWFPRDMzclVtdm55Uzg1?=
 =?utf-8?B?bGFsRFhJcy9rV0lUQldqbTFIc3ZBdVkxSDFWdDhQbzNtZ3NJQndIN0FHRlNx?=
 =?utf-8?B?T0pDa2lRbGxDQWhuNkZVakNtMkp6L21SdS9TRGtLOWlFV3FPNTlDa0R3N3ZH?=
 =?utf-8?B?ZDgzTE1mSWdxbmtYaEo2UC9rL2JBMUN2YUl4SUM5NnI4aTg3cE5DL1poSU9r?=
 =?utf-8?B?Ym5EMlVmR3RoQWE5TFdkdXg1Z2o4eEU5dk5VaDMycVgyaC9qYzJrdGhqVDhw?=
 =?utf-8?B?UzJjYXF6RW82N2VGclVCZVBnUXRBaUxNMVljZlV6V0thbEZ6b1V2K3k1YTVP?=
 =?utf-8?B?SUU1WlVHRzlmRWlneXFWL0dHNFRpRDU0VXVZRnJiSEdydm96cHRDUUNmNnFF?=
 =?utf-8?B?RWltdW5mWmtyUkkvYi92QlNDMFQ0NU1IY2p5ZEFoRjdCV2tGUFlpSW5ZbGpW?=
 =?utf-8?B?Mkw1eGVMSFE2NkkzS1FvbGZYUGxWMklBeVc2eGdoeEs0d05BUFN4WGJ5R0kz?=
 =?utf-8?B?QTdiaW8wM0wrNkkwdzdaQ2FBYk44dVUzekxMTmNtWlpieVZRSGp4UFdqeUht?=
 =?utf-8?B?bkJ5VDA0NDQ1VGozRkhyb1dRdWIxb3IzdDZTbHlHRnNmQ2VKdWo3ZjJhRDVl?=
 =?utf-8?B?S0pkbk83MStrbncvWEJzbDd5WGE1dDU1MXFHa05YK1g1akplWGMxTnFHNTFR?=
 =?utf-8?B?eENpUWZ2MU1NQXhjRGFXeGNYRGxpd2NObjFoblpLQmRqaWozSko1dEJObmZP?=
 =?utf-8?B?OXNlTm0rWWMzVmRZTTBTR0VIWGZjLy9naHUvY0RHTDZ0cDM3RlNDUkUwUDBM?=
 =?utf-8?B?VjdqeWp2UW9wVmNwWEE4RmkwMjVyZjcyVXFoSzRNVUplNzNwK1NLV3hpZjV5?=
 =?utf-8?B?REp5RkJ0VXNFSmlMV3J1UUJBYjRrQVhOM2RNalM5NlZhM0ZIVG5QR0I1TVFX?=
 =?utf-8?B?cHh1aWZDVk9Tb1BlK2RaMS8rTTZveWNQL3A3ZlJhSVAvU2FQSlJ4bERNdmhK?=
 =?utf-8?B?b1Z1MVFUT1pjaUYxMGhSL085d1dXdmJUUWQ4NG5TU2RGUWhKYkpQOEJXNTdo?=
 =?utf-8?B?dExDZHo4OUJDcnpVSHg5MHR4NlBETTBFMHJ3SFBoZkEvWXVYaHUzZGt4NTJk?=
 =?utf-8?B?NXRoRkJma3F1WmhIamZWMTlveGpwVUg5SXZQOHF1eXBIYmtzVFFWWjBWU1Fj?=
 =?utf-8?B?cjZJSjlFa0lidDFTMmxBYVJIeVhYbzhWMlRzUTBGdXZuM1NHNUVvSSt6cSt4?=
 =?utf-8?B?aTZsZ1F6N1FjOC9aTkV5eHdKUFlEcDFJdTJ3a2RFQUF6N3FjNjYrQ1JYaWVY?=
 =?utf-8?B?QURIcmdKaVA1MjFhZEJBMWwvN0pTUTcvU25FMHFEY0JoUTZCR1I2ZEJReW9i?=
 =?utf-8?B?enhnV3o1WE1jZGttdlhmczBjRUNEZWdLREZCQnpXMW85Y3RpN0lBS1BOMUIy?=
 =?utf-8?B?eVovTlE1ZTVSY1YwcXlyeFg4VWFOcFppK2lUQmlRZ0N1S3B2WU9GZUxDYmFn?=
 =?utf-8?B?Qkt5SEVrZnRFYXd6TVhXemdxWWNIbVY3TXFQajFPUlNoRHBOSnFkWjJ5Umlt?=
 =?utf-8?B?OVVlRjY1andlcjE1dHZ4N1BJelJ0S3ZvY2tkMXhIWG1DMGlNU3FISjQzWFNJ?=
 =?utf-8?B?Q29BaXlhUGlMTDRWZVJxWVk1L25zbGtuMlRSNU15WDJTekxTRnlyaXJ1alln?=
 =?utf-8?Q?ooHIv7ZO/g6wQ0RvUm/SvJg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dac79886-2221-4d77-cbc8-08d9f0649f0b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 09:22:00.7569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q0Mkc2uvo4n/+EMxOEjtJGx2jLDzyJqOKJyYLqtzX00+TkeMGuBowBM20SwaKqL4
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3559
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 15.02.22 um 10:11 schrieb cgel.zte@gmail.com:
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> There is a regular need in the kernel to provide a way to declare having
> a dynamically sized set of trailing elements in a structure. Kernel code
> should always use "flexible array members" for these cases. The older
> style of one-element or zero-length arrays should no longer be used.
> Reference:
> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays

I think you should harden the wording here into "must" no longer be used.

We had so many problems with that and certain gcc versions that we 
should have this automatically checked somehow.

>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> index e54a52785690..7d39191d13f6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
> @@ -1084,7 +1084,7 @@ struct kfd_criu_svm_range_priv_data {
>   	uint64_t start_addr;
>   	uint64_t size;
>   	/* Variable length array of attributes */
> -	struct kfd_ioctl_svm_attribute attrs[0];
> +	struct kfd_ioctl_svm_attribute attrs[];
>   };
>   
>   struct kfd_criu_queue_priv_data {