Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 11:54:49 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jiri Slaby <jirislaby@kernel.org>
Cc:     Qing Wang <wangqing@vivo.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: 8250: add missing pci_dev_put() before
 return
Message-ID: <Ygt4aUMVKM8ZcW/5@smile.fi.intel.com>
References: <1644890454-65258-1-git-send-email-wangqing@vivo.com>
 <67ace5d3-02b3-034d-969f-9a05bbdd8e30@kernel.org>
 <621e2079-567c-6954-9744-c51748dd48dd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <621e2079-567c-6954-9744-c51748dd48dd@kernel.org>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Feb 15, 2022 at 07:02:57AM +0100, Jiri Slaby wrote:
> On 15. 02. 22, 6:55, Jiri Slaby wrote:
> > On 15. 02. 22, 3:00, Qing Wang wrote:
> > > From: Wang Qing <wangqing@vivo.com>
> > > 
> > > pci_get_slot() increases its reference count, the caller must
> > > decrement the reference count by calling pci_dev_put()

Wang, thank you for the report!

...

> > What about the "return -ENODEV" few lines above?
> 
> On the top of that, the code stores the pointer to the dev:
> param->dma_dev = &dma_dev->dev;
> 
> So we should likely put the device in ->exit(), not ->setup().

I think I may fix all these and send a new version.

-- 
With Best Regards,
Andy Shevchenko