Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp82406pxb; Tue, 15 Feb 2022 08:52:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlnHZM661EeGBbEUhf4nCKfKqUUtLVbd9NqSogcvCgzbY+YWzM89nzImTimSb1BX3rQ7fB X-Received: by 2002:a05:6402:34c7:: with SMTP id w7mr4789055edc.397.1644943931825; Tue, 15 Feb 2022 08:52:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644943931; cv=none; d=google.com; s=arc-20160816; b=d93U+b/0DwtOMWJKWoaiosIJBjZOvh5j2Bnfuo0iXoF5xAsttl2Z6aoEm1xSVhczmk gPlzlj6n1SiFYOWbH6vBkhJuWLj9NNHYnOLXp3xPpg6gtA/Vu04EomOTEJwoPECL/uRv y45/L1J4WxQDMx+MlZbMhhclNXMwUnrUy2E/uNGB85UhS6iImo6yKdVhHE61417mEw8/ VJ78mXNuqATPQ/FzjN13s3DzJ7R6PkXBHSFxZKa84QwxElzB+Rb/kdI3NpjpIrRwyz/M LJz0DBKFn57sQrNznRrgAcK7ZZjOThDPD3QOiRjLh/eAbuTFEX7Zq/UTpbgaBpu4rIuN wccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lpJF0DPW1QUFslGQlkPrAV/yjkWVm5bvn5fjtUyMI5I=; b=BEqhYyO2CvvSYZpvwjKBl8QmfwPI6E9d2MofERDBWQ/kU+VV21erp79ApMrF3nuz1m L3XUO+I7yXzOmQ15i+QnW4tH7GBdUBOB1FlS9yqgcyFdRGfYXfjV+rvQPSLfa+np9QoX /adUDyBPQAWDKwrBqSqChROMeLHQPsqoMOSNGRhxyfKOhbkjcmPtgWSx6O3jNvro4deF nDYMK45HBNesu/q5BSPpR8mQsklELXn7xckjGz6cZCK3vxU5eL/gxJmaoswlOf41XP0d HxaUCMM6g1+t/xCMgGnS+tIeggg+Ei6K/SZ1FDZVbi3owuQfu2LZSey7fNvwOxoHE/uq mS3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="hPdzK/P8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ss28si3182246ejc.83.2022.02.15.08.51.39; Tue, 15 Feb 2022 08:52:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="hPdzK/P8"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237972AbiBOMzD (ORCPT + 99 others); Tue, 15 Feb 2022 07:55:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232760AbiBOMzC (ORCPT ); Tue, 15 Feb 2022 07:55:02 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47B6F434A2; Tue, 15 Feb 2022 04:54:52 -0800 (PST) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B93571EC0535; Tue, 15 Feb 2022 13:54:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1644929686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=lpJF0DPW1QUFslGQlkPrAV/yjkWVm5bvn5fjtUyMI5I=; b=hPdzK/P8wr/BQRHcNE7GCCG73SydOg0ztOwVWavDyYXP1xHLStzPoPF9L7G1/xyKJb03rd XQccaz/cSgNE76wjLP5r28HUq3WX/Wn3loTq/NL5I5SeP/lnt6u3H+pBlrNdIsElFhr/GB zzZ7ZiihZWxpZpJEaEE33jXMPf+JrV0= Date: Tue, 15 Feb 2022 13:54:48 +0100 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: Brijesh Singh , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v10 21/45] x86/mm: Add support to validate memory when changing C-bit Message-ID: References: <20220209181039.1262882-1-brijesh.singh@amd.com> <20220209181039.1262882-22-brijesh.singh@amd.com> <0242e383-5406-7504-ff3d-cf2e8dfaf8a3@amd.com> <20220215124331.i4vgww733fv5owrx@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220215124331.i4vgww733fv5owrx@box.shutemov.name> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 15, 2022 at 03:43:31PM +0300, Kirill A. Shutemov wrote: > I don't think it works. TDX and SME/SEV has opposite polarity of the mask. > SME/SEV has to clear the mask to share the page. TDX has to set it. > > Making a single global mask only increases confusion. Didn't you read the rest of the thread with Tom's suggestion? I think there's a merit in having a cc_vendor or so which explicitly states what type of HV the kernel runs on... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette