Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 15:49:25 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Naveen Krishna Chatradhi <nchatrad@amd.com>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, mingo@redhat.com,
        mchehab@kernel.org, Muralidhara M K <muralimk@amd.com>
Subject: Re: [PATCH v7 05/12] EDAC/amd64: Define dynamic family ops routines
Message-ID: <YgvLhXVOX+upsE3a@yaz-ubuntu>
References: <20220203174942.31630-1-nchatrad@amd.com>
 <20220203174942.31630-6-nchatrad@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220203174942.31630-6-nchatrad@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?M5Eaea+/WNYZX5jYBzLlBSmDTJHwrKL/EaPT+sq4WZ7SyZGkP3rju/+pKjLb?=
 =?us-ascii?Q?lLMrYvAN/EdaXHPu/jF3pKUzFc53ndu/oRkLC6EdrchrxQ+K9sVQrUBs7c5u?=
 =?us-ascii?Q?iEJEeWfs84i6mf+e+XwNYf52tpf31DV57anYvs5zuxjTmkM+YwaQfaw3huPT?=
 =?us-ascii?Q?Zs3Ws00ARUCtjVHKZk++FrNCXy8ovAmokyd0M3Bkun6BcWs/yGXsfp6DGdnE?=
 =?us-ascii?Q?/LNy9YTQpqPrSLIGLkw6dxsAomJOdYGpZZjgAx71Ja+DV03M0GBUPs6WNTT+?=
 =?us-ascii?Q?G7xYjwaOf7F1mVXx3/Jh24+9jdllbXH9Csswl3F9L8YkdBO0j4tT4BHVhri6?=
 =?us-ascii?Q?HqHudMg6aWnGCqMgWXgclWbCh17gSzgI3v6FS+qKW1vX30ebpDmFa5T7nDH3?=
 =?us-ascii?Q?5rfIX83jl2UHOmjk3zRbYib8qkzq0gzUQQVnl0FdZYfx1FpPH8c3lcIkgYBC?=
 =?us-ascii?Q?/cY/GcX8RUfrAURA9AKAXsDjckD26zoXQ+biS4lFIaUnvisx4DPRMlUAZpgB?=
 =?us-ascii?Q?fflM37hgyCcErAIJVRCi4EdaEKCTW/5stQR/+KuOpk4apnz3ikpBZwhdXR0h?=
 =?us-ascii?Q?rX6C1F3JriStzFjWIISWvQ/sL+hJoFT7saSW75K8yqFs+7emZxbBVhVxysEW?=
 =?us-ascii?Q?eseQc+ng+/WCVxSLepMdGnJl7d6AwTGq4b6BJiOk6utDXeXqxfTw1g4CXnkq?=
 =?us-ascii?Q?pdEtexbmwgcNXsFDIzDHs/8zQ36TFowqr92mns+kgiaJpS5fJD9NPknbjzmh?=
 =?us-ascii?Q?fKIPEuSAhGN/dbn4X7xTJXKpHOoZP5vCRyuswzT0+jxGRtCqKN6NOdMo/1E0?=
 =?us-ascii?Q?lddsX494YZjKfqm89LgKiuX1ZWyZ8YDzukYk6g7d8tqp0a7//BAgrmvTmBqj?=
 =?us-ascii?Q?P5CxRuw13bn7C9JtE12tJIF4Dc0tCUntmhjfY1CYhfToUssXksAP1Z6JNcP6?=
 =?us-ascii?Q?bQpLzhnwrDrDGt3FLvOl4yg+BhPOe7xYKAURtlU9FEj+kQJEvRQwulJ62KEI?=
 =?us-ascii?Q?zQR48v/NZ0tROOhjRmGlZV7GHv7HUIgByszR+oEKFNDVMS4o2zCCavXtZhbQ?=
 =?us-ascii?Q?NsR1Tz0A8WUZtCEam9OTZrMaXxsJqcKvKFCa/jsfINLMqRpRkvnsjltYAEVM?=
 =?us-ascii?Q?ZvSnwAxb4C3pjqhkrg0gocTm4zZyyEB/YU68uRlClMo8Y6Bggkpa5oD2bynO?=
 =?us-ascii?Q?hdaQ4OENDpvzsKYi48MDErzEdlmrr8BGJ/RywWxljV7c3BU5BbRdWZBTfhbq?=
 =?us-ascii?Q?HLFDwxgcr7eDg5Y31kgqe1plDO7Q8IxNg0DvVwy9Q8VbHGNDD+SZ9hZyiotV?=
 =?us-ascii?Q?2KzJsv9F7H13/LylXxk3esHKj8TK9h8VKGGY92Xeh1a9RHyhojxeErPT5Ztq?=
 =?us-ascii?Q?MSspPWTNhR8MjzM5L8AtvszEjN4s9rBuSjJvQQ+7uKn1zBcZoj5Dkq7cqmSy?=
 =?us-ascii?Q?lurzGHyhyzA9oo89q0hRdUoeuKzpLMTY04Cx+K8LErAInHMSETqTiTkPOAVL?=
 =?us-ascii?Q?/t3nTHK2pNXoisYnkhfyAy+lS+pm5C+ctxLEu8fwOoY1mQMjqFalA+YBN6i7?=
 =?us-ascii?Q?XhWw9xX5jy/yfOtpM0k/SHPuH90aUM9WV5jOnMp4bq5s7So6KAJJP+GZ3PPA?=
 =?us-ascii?Q?rDsTEIBHylz2KrydvLno6oc=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 01689294-5d72-4a28-a8cd-08d9f09abfc6
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 15:49:28.3826
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ba4DYBLLOIoB4Is73he7gDb1oLTJ67ObiMjmwvqx3F12BfblME2dmUkhOMvXYb1Y0z+Yi3rRJikSe872m5bMBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5151
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 03, 2022 at 11:49:35AM -0600, Naveen Krishna Chatradhi wrote:
> From: Muralidhara M K <muralimk@amd.com>
> 
> Extending family-specific assignments dynamic.

The commit message doesn't clearly describe what the patch is about.

> This would simplify adding support for future platforms.
> 
> Signed-off-by: Muralidhara M K <muralimk@amd.com>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> ---

...

> --- a/drivers/edac/amd64_edac.h
> +++ b/drivers/edac/amd64_edac.h
> @@ -481,6 +481,19 @@ struct low_ops {
>  				     struct err_info *err);
>  	int  (*dbam_to_cs)(struct amd64_pvt *pvt, u8 dct,
>  			   unsigned int cs_mode, int cs_mask_nr);
> +	void (*prep_chip_selects)(struct amd64_pvt *pvt);
> +	void (*determine_memory_type)(struct amd64_pvt *pvt);
> +	void (*determine_ecc_sym_sz)(struct amd64_pvt *pvt);
> +	bool (*ecc_enabled)(struct amd64_pvt *pvt);
> +	void (*determine_edac_ctl_cap)(struct mem_ctl_info *mci, struct amd64_pvt *pvt);
> +	unsigned long (*determine_edac_cap)(struct amd64_pvt *pvt);
> +	int  (*get_cs_mode)(int dimm, u8 ctrl, struct amd64_pvt *pvt);
> +	void (*get_base_mask)(struct amd64_pvt *pvt);
> +	void (*dump_misc_regs)(struct amd64_pvt *pvt);
> +	void (*get_mc_regs)(struct amd64_pvt *pvt);
> +	void (*setup_mci_misc_attrs)(struct mem_ctl_info *mci);
> +	int  (*populate_csrows)(struct mem_ctl_info *mci);
> +	void (*get_umc_err_info)(struct mce *m, struct err_info *err);
>  };

I think there should be a patch for breaking out each of these functions.

Thanks,
Yazen