Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 16:43:47 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Naveen Krishna Chatradhi <nchatrad@amd.com>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, mingo@redhat.com,
        mchehab@kernel.org, Muralidhara M K <muralimk@amd.com>
Subject: Re: [PATCH v7 08/12] EDAC/amd64: Add Family ops to update GPU csrow
 and channel info
Message-ID: <YgvYQ5RKpx5hZAAN@yaz-ubuntu>
References: <20220203174942.31630-1-nchatrad@amd.com>
 <20220203174942.31630-9-nchatrad@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220203174942.31630-9-nchatrad@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EItWL2Gw+d7+VQ3iFlGCM4nJQo6F0zI+6+p9EANuHK5uFN47CXtdFDzx/hgh?=
 =?us-ascii?Q?EuvVldNXnGfVLi89Y3kvfa2Ccqcn22V8kG1cKrua6pHFjOSIuBSVyluOcUmA?=
 =?us-ascii?Q?uC5SD9x2n0/K4uSioQXF5ecCr8YVC+Q0makEPKUgLRU/F9yKp8DPLc9DaiIU?=
 =?us-ascii?Q?uDrexwQ03Z4C8r+KzKFqMAQ8Hswndv30zyT9nB1p7uc2DQil4Rv8ygOyfJzc?=
 =?us-ascii?Q?MAzMBG14xjQl2XYmjixTSl+ly6FE/twcVfPHHndl8WsCF5LGss+yWvqM4W3L?=
 =?us-ascii?Q?S1RHEHajkFKr5q8/SDr2zZACB/91kkdzWl4yqOOkhoosLPzOOiJElOHq13R/?=
 =?us-ascii?Q?FexlFCGZvOQBr9Tk1hnP6aqmAqS/d5g/cE2wm8e5FBKYDPzpEQ6NbFzs3LRc?=
 =?us-ascii?Q?AXRBK8SLFoMG6kbNL3ISrplAGbZK8TAqXlgHm4GqhmqKL6cRWuIiQO0RTBN8?=
 =?us-ascii?Q?yowk1NO7PFvyKp1t2ZbUvLq7vc0Vu6TRN9hHbomZQnvLjQiMXcEZDLUkyDt+?=
 =?us-ascii?Q?KaF361IFVQZ85KSAY+grma6tUEffKZwlBe0xp5IDWWu/tnBlVSfm+HKETXaR?=
 =?us-ascii?Q?X/uB25GU+s0YAKmX9aNj3G9NML+B3LVJ6gj5Pv3ofkvCAFYihDeCskbAXXnN?=
 =?us-ascii?Q?NueV6joa9CVXW5OEshbbJVowrmik4+6EHRvuLmd3rt4peYTpf+wii7Wje8At?=
 =?us-ascii?Q?nK/0G8C3APvzSANjomN660GySasGsKSQ7CcCRIxwl6ibT44e95spmUpSEXrH?=
 =?us-ascii?Q?3HAgrl2IHlPWxtDwdGmv3EeIyw0XaQfQuanxWqp6YZvBbK4blvjSkXRa0v7L?=
 =?us-ascii?Q?bhcC8Ky5zTnYfcwKpzJWvS9NGzoDDxtRj1/5nrpAQ/cXz6UikVCTTyIa6VWs?=
 =?us-ascii?Q?i4iK1wPW+Edd/KnssIVOSqPEniNJDCHsRDihkr3JwF6HGmRHP7CgJjzGqjk/?=
 =?us-ascii?Q?1U19TL67URfxTkr8uPVv4YFvhkJ9L7AB+fIs03Ma26kUiIwsid7Toah3j++z?=
 =?us-ascii?Q?FB7Ar5289Uie1ZmF+JHVA7xg19MdMbooooOYv5bP6XCpA5fNHVvi8aPZL8sT?=
 =?us-ascii?Q?jpXCMT9DQ6VUg3sLP9Ls1uAVxajAorJ5xyaOt3kJWWE1MUoOCEnLdz/O56LQ?=
 =?us-ascii?Q?aGJLCJti5s7mZTow/MOjjrNoifdk70//yssZSJkoutuSV+dgcWaHrF42c5nY?=
 =?us-ascii?Q?1YoUU/thTCoXOcEMDDdaKUQXR6ltrXaajQZeNaL6totMxo99Ued2gdSA+dFa?=
 =?us-ascii?Q?XI9HJJTJ9KXNGMo0PCYBsgefZByDFdk+7t5RBfa1Jsytv/w/IAOaz3yD0PS2?=
 =?us-ascii?Q?2M0xAi+iPfJ1RgI0HSk3jd+BpwQ49lkVKf4VOjCjDWjpD5b3F0JlF9xfP/rY?=
 =?us-ascii?Q?/0kjWYzLoPEMEH349OO+hb6wgk9JUs6hV/4xJKhZq7acybNv7PN+PfDUeKXC?=
 =?us-ascii?Q?FML/67pJW7AENVibVVL6wi/hHZEZuL4D3iIDTXxuqgya7erziWvUh61XK9km?=
 =?us-ascii?Q?fTVuY4HW5TwoKWrrnSRJ8Jhtw5K5Zgde3/5hBF3TQda9Dlf2xhn1/1Y5hR+8?=
 =?us-ascii?Q?8f0l6hQT0jEBqOW7mOacNdRoi8ISPhRq/kOXINVn6c4UasVFTdhqYzPnJnOp?=
 =?us-ascii?Q?4lpUAg/LfH3kbpphOFZyM5g=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d70b3773-47a9-4737-fcca-08d9f0a258c5
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 16:43:51.7186
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KnoMgrcCMcD4jidBvqrLRNVQGaqeMjb4rrd6ecZHfiC+ByIx4MfR4ZoC1bj61ZxCVBrU9ZIG+uQhC6w4I8Cp6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2791
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 03, 2022 at 11:49:38AM -0600, Naveen Krishna Chatradhi wrote:
> GPU node has 'X' number of PHYs and 'Y' number of channels.
> This results in 'X*Y' number of instances in the Data Fabric.
> Therefore the Data Fabric ID of an instance in GPU as below:
>   df_inst_id = 'X' * number of channels per PHY + 'Y'
> 
> On CPUs the Data Fabric ID of an instance on a CPU is equal to the
> UMC number. since the UMC number and channel are equal in CPU nodes,
> the channel can be used as the Data Fabric ID of the instance.
> 
> Cc: Yazen Ghannam <yazen.ghannam@amd.com>
> Co-developed-by: Muralidhara M K <muralimk@amd.com>
> Signed-off-by: Muralidhara M K <muralimk@amd.com>
> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> ---
> v1->v7:
> * New change in v7
> 
>  drivers/edac/amd64_edac.c | 60 +++++++++++++++++++++++++++++++++++++--
>  drivers/edac/amd64_edac.h |  2 ++
>  2 files changed, 60 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 10efe726a959..241419a0be93 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -3653,6 +3653,30 @@ static inline void decode_bus_error(int node_id, struct mce *m)
>  	__log_ecc_error(mci, &err, ecc_type);
>  }
>  
> +/*
> + * On CPUs, The Data Fabric ID of an instance is equal to the UMC number.
> + * And since the UMC number and channel are equal in CPU nodes, the channel can be used
> + * as the Data Fabric ID of the instance.
> + */
> +static int f17_df_inst_id(struct mem_ctl_info *mci, struct amd64_pvt *pvt,
> +			  struct err_info *err)
> +{
> +	return err->channel;
> +}
> +
> +/*
> + * A GPU node has 'X' number of PHYs and 'Y' number of channels.
> + * This results in 'X*Y' number of instances in the Data Fabric.
> + * Therefore the Data Fabric ID of an instance can be found with the following formula:
> + * df_inst_id = 'X' * number of channels per PHY + 'Y'
> + *
> + */
> +static int gpu_df_inst_id(struct mem_ctl_info *mci, struct amd64_pvt *pvt,
> +			  struct err_info *err)
> +{
> +	return (err->csrow * pvt->channel_count / mci->nr_csrows) + err->channel;
> +}
> +

The DF Instance ID needs to get adjusted again later in the translation code
due to the fixed mapping of CSes to UMCs. Can that be done here instead? Also,
I assume that fixed mapping is unique to each product, so that would make it a
good fit for the family/pvt ops.

Thanks,
Yazen