Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <79bcce92-abb2-4c3e-7193-d18e144da8a0@nokia.com>
Date:   Tue, 15 Feb 2022 09:44:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v2] arm64: move efi_reboot to restart handler
Content-Language: en-US
To:     Mark Rutland <mark.rutland@arm.com>,
        Ard Biesheuvel <ardb@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Peter Collingbourne <pcc@google.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Matija Glavinic-Pecotic <matija.glavinic-pecotic.ext@nokia.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Krzysztof Adamski <krzysztof.adamski@nokia.com>,
        linux-efi@vger.kernel.org
References: <YfP0osb45uJldtM9@localhost.localdomain>
 <YfQTZTUNaeGi+8tG@FVFF77S0Q05N> <YfRorCpk0seVGI+5@localhost.localdomain>
 <Yfk8hQB1eon7oeYU@FVFF77S0Q05N>
From:   Alexander Sverdlin <alexander.sverdlin@nokia.com>
In-Reply-To: <Yfk8hQB1eon7oeYU@FVFF77S0Q05N>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUh3cXFvaUxFSlRFR0FnOUpGRnpXVXM5dlMxNFpFN0w2azY1SDh4RTFVZnZY?=
 =?utf-8?B?UGlRT2VXdEJzaloxazB3VjJtcnplZ2hyNU9oUGhVMGVZdEc0M3o5WXhVdWt3?=
 =?utf-8?B?NnhKTXhqeHpKcFBISWxHS0xoMTRGM0tESHZ4MElQM29aQTFJK2Vxam5oN3F4?=
 =?utf-8?B?TE5MNWlnQ1RlcWtoY2RBNVZzN05pd3Znd0YxOHdnOWtURVhBTExpU3VsUEFq?=
 =?utf-8?B?OUt5cnBMaUdoR2lHVFVERjE0N1ZzU3dMeUdnNWkzRWNjQ1IxZkVjTlR3aElQ?=
 =?utf-8?B?Y3p5cEMxZGdUMjIrOVFTN1BmM1RmMDNwUWppSFpwdFViUVV3bzd6Q2tnNWo1?=
 =?utf-8?B?cUs2eUNuS0JDck9zTkZkMGlYNC9BK2xtOGx6djNzOHdYMXRMTDJrN0ZVZ3Zq?=
 =?utf-8?B?dnNzUTNVeXU2MGhLR2VYMVU5OVBCbDR6M1N5aHgwL09GTmhxRUJBeGRjQ2RN?=
 =?utf-8?B?b1RNOFNOYXJWd0FxY0JadUNGN3FoaXVpa2FSTURqQ3h6eUV2SU1HODB1N05H?=
 =?utf-8?B?T2doL1BOZTZWTDB5ZVBZdW9KbXBNeEVoZUF3ZzlvZEIzN2JOTjJqTFMrZXB2?=
 =?utf-8?B?VTRRdmZIOTkvS3NKbERPNnVqbVh5dXJOY1FibGovV0t6bnlIb3V4clZWWWh0?=
 =?utf-8?B?cGV6c0NHakpRdlI5Q2pXSlp1UkZlSFZrZllPS3dUK1NjbW5pVUREbTJmTEdo?=
 =?utf-8?B?cUFkOVFLa1dEbHBFbjdjeS9IcXRtS3FRTU5rb0t1L1dIbnNiTkt0TW5IQUJt?=
 =?utf-8?B?cS9ZWFZkTU00RUt4SUM3QnNKR0QyVHJxMG1uSVV3WWo1RUcrbEh4bGhScW92?=
 =?utf-8?B?Q28yVU9ieUNaNSt4dUhYWXhIR2tlVGZPUG5icklCcHVQMXhDdEV4bFRPRlRx?=
 =?utf-8?B?YStIN3ZTL2ovRTdnenpBNThFbFNWY2xtbmFCRjBuR0tWYS9UeDhJVGEwb05n?=
 =?utf-8?B?ell6SVI4NmpCdHc0QnFBL0Q5OU1zdEFGL3hwMzc0dXNId0s4Vjgxbk41bjNP?=
 =?utf-8?B?UVhWbFZyYXVqU1BPTm9MN1MzeGFlc1RIMDlzVEJaSWs1aEluaEE4NDZsbWN3?=
 =?utf-8?B?S0QyWTJCc2pjUHk1M1M4bnV3Q2YwRGhaQVZYajBrMThGdklNYXhpUlh2UjZ6?=
 =?utf-8?B?QXFHZGt1dHh0c1RieG45VFNGU05VQStQSkEvV21yWTJCQlhCdVF4VTBKS1BV?=
 =?utf-8?B?Qzg2Vy9wdG83RWtyWGJycnNEcTF6ZHkwT2c0YWY5bEs1Y21kSFAvM1R5UC9H?=
 =?utf-8?B?eGEwNDNkZEtzeXhuY0FhcmJBeTAxYmpBUEErVXRmemRmSEhONnNpUG5jUW41?=
 =?utf-8?B?Rk1PNGVpTmdVRFJHTGJUdml6NXVLdVVjUzFHeW1VWGFZQ0pSNzFNbHJteElT?=
 =?utf-8?B?OWRkVnlxOE92aDRzSWNxV2NNWmtxSGR1bnVTM3hQNUt6d3hXRHZHY3E1YlJC?=
 =?utf-8?B?aG5yY1pkbHRnSnFaK0x6eFhSN3lTQVlSbXRhdlBMd090bkM1SGNUbmVaSkE2?=
 =?utf-8?B?V1grRWZnbXJqWjNXNUZaYnNCdTlHSkhGZms4dWJHMlhoeTNQeVowRWxFNW0y?=
 =?utf-8?B?T2I4MmRFN0RRTXRrNFBRVjRjSFA0cStIVEljM3phTDhSVDNkY21oMUVpbmZG?=
 =?utf-8?B?Y3lhYmR0bTBtRm9ZUG1HOHBZTG1EdGV0K0FrYVhEbjZXd1c5OFh4QUpHcUZE?=
 =?utf-8?B?VW5RWUJKQmFUZVUwVURYd0dvcm1UdEdQRXR1dVgvTUkvc1RxblRIMTlDVjEz?=
 =?utf-8?B?dTE5a3pkb2x6ckI0cTg1ZWhYbi8xRmgxcUFjelBkTmFrWUQrQ3J3aHZpTXVl?=
 =?utf-8?B?UlZwS0pVSEI2T0tPSXNJUGhydW4xMG5TSEYwTXA2blZiemFOOHgvTHMxZ2hW?=
 =?utf-8?B?Zk1qTi91M1E2andnM3kyYkY1N3JSbG5FQTVYeGduOHVTL1l3bGkwdTl2VWx2?=
 =?utf-8?B?SXdPc3hNaEEraWFPTG5BQ1cxUlZRSEZ1U24wZlVycnBJRytXTVhLMnRkb0Nn?=
 =?utf-8?B?cUtxR1ZZV0RxUGdwb015d2pvejV4NXhydjAxSkIxZ0ZxSFlBaWVNUGFDVVhG?=
 =?utf-8?B?ZDVpMVU2Y3RzSmc4dXVIT2IrQ01oY085ZTAxQnVvZEtFaGJ5STF0YW40czlV?=
 =?utf-8?B?Q3U0WE1YclhDZ2RRc1ZuNC92SlNLUkNjUTZ6WHEwSWNXMXQ3TE1MbXBtMkEx?=
 =?utf-8?B?MHNUeXZCenJmNnBxdHR0dDh4OWNKa2JvalV6Mmk5aitjcUt1cUpCdVN1bUdu?=
 =?utf-8?B?alUwN1lXTG03RGxiZ2g3Rmk1WjhBPT0=?=
X-OriginatorOrg: nokia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 51193084-7d62-4821-1091-08d9f05f63fa
X-MS-Exchange-CrossTenant-AuthSource: AM0PR07MB4531.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2022 08:44:34.2496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CB8MA2YWjLx12YKaKFFf981o9Ilb9p5QPdAOW0ejLou3AvvqL+L4+KNxeXFheDU4iFxp+yQOb8TF/jGdOL2vmc2mngwcR6xfEz3pN2a7Zxg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR07MB5091
X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Mark, Ard,

On 01/02/2022 14:58, Mark Rutland wrote:
>> You could argue that restart handlers were not created for that but they
>> suit this purpose ideally and it wouldn't make much sense (in my
>> opinion) to add yet another notifier chain that would run before reset
>> notifiers, for code that is not supposed to reset the whole system and
>> this is exacly what I would have to do if efi_reboot() is forced to be
>> called before all handlers.
> 
> As above, I think that's just using the wrong interface, and the reboot
> notifier mechanism *already* exists, so I'm really confused here.
> 
> Have I misunderstood what you're trying to achieve?
> 
> Is there some problem with the reboot notifier mechanism that I am unaware of?
> e.g. do we bypass them in some case where you think they're needed?
> 
> Are you simply unaware of reboot notifiers?

Could you please check the simple case of pwrseq_emmc.c?

While that's currently the only example of this kind upstream I can imagine
further use-cases, especially in storage area like above.

Would you suggest it's illegal usage of register_restart_handler()?
Do we need to fix pwrseq_emmc.c by introducing new atomic notifier chain
which will be called before restart handlers, so that it works on
emergency_restart()?

-- 
Best regards,
Alexander Sverdlin.