Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 21:05:02 +0300
From:   Ivan Bornyakov <i.bornyakov@metrotek.ru>
To:     Moritz Fischer <mdf@kernel.org>
Cc:     Conor Dooley <mail@conchuod.ie>, hao.wu@intel.com,
        yilun.xu@intel.com, trix@redhat.com, linux-kernel@vger.kernel.org,
        linux-fpga@vger.kernel.org, system@metrotek.ru
Subject: Re: [PATCH v2] fpga: microsemi-spi: add Microsemi FPGA manager
Message-ID: <20220215180502.gqcsz7rdxygiva3y@x260>
References: <20220214133835.25097-1-i.bornyakov@metrotek.ru>
 <20220215115853.26491-1-i.bornyakov@metrotek.ru>
 <d0890e09-5d4a-5cce-832d-26e64b74ac54@conchuod.ie>
 <YgvoXgqM65M97qib@epycbox.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgvoXgqM65M97qib@epycbox.lan>
Precedence: bulk

Hello Conor, Moritz

On Tue, Feb 15, 2022 at 09:52:30AM -0800, Moritz Fischer wrote:
> Hi Conor, Ivan,
> 
> On Tue, Feb 15, 2022 at 05:37:04PM +0000, Conor Dooley wrote:
> > Hey Ivan,
> > Firstly thanks for the patch(es), stumbled across them today.
> > As you may know Microsemi has been acquired by Microchip, so
> > s/microsemi/microchip/ please. This would make the correct vendor
> > prefix for compatible strings "microchip". While you've said this is
> > for the PolarFire FPGA, there is prescendent for using "mpfs" for the
> > PolarFire SoC FPGA in the kernel - so if you could change the uses of
> > "polarfire" to "mpf" that'd be great.
> 
> I personally don't have a strong opinion on hte microchip vs microsemi
> here. We have precedent with intel/altera.
> 

Me neither, so I'll do what Conor asked.

> > 
> > The current item on my own todo list is the opposite side of this,
> > reprogramming the FPGA via the system controller acting as a SPI
> > master for PolarFire SoC.
> > I will get back to you when I have a better idea of what (if any) code
> > can be made generic between both modes. In the meantime, I will get
> > together a setup to test SPI slave reprogramming of the PolarFire (SoC)
> > 
> > Thanks,
> > Conor <conor.dooley@microchip.com>
> 
> Thanks for chiming in. Always nice to have vendors help out reviewing.
>

Yeah, that's great, thanks in advance Conor.

> > > Add support to the FPGA manager for programming Microsemi Polarfire
> > > FPGAs over slave SPI interface.
> > >
> > > Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
> > > ---
> > > Changelog:
> > >   v1 -> v2: fix printk formating
> > >
> > >  drivers/fpga/Kconfig         |   9 +
> > >  drivers/fpga/Makefile        |   1 +
> > >  drivers/fpga/microsemi-spi.c | 366 +++++++++++++++++++++++++++++++++++
> > >  3 files changed, 376 insertions(+)
> > >  create mode 100644 drivers/fpga/microsemi-spi.c
> > >
> > --<snip>--
> 
> I'll take a closer look once the bot's complaints are addressed.
> 
> Thanks,
> Moritz

Thanks in advance Moritz.