Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4b739847-0622-c221-33b3-9fe428a52bc0@collabora.com>
Date:   Tue, 15 Feb 2022 23:17:39 +0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Cc:     usama.anjum@collabora.com, Shuah Khan <skhan@linuxfoundation.org>,
        "shuah@kernel.org" <shuah@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        "luto@amacapital.net" <luto@amacapital.net>,
        "wad@chromium.org" <wad@chromium.org>,
        "christian@brauner.io" <christian@brauner.io>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "andrii@kernel.org" <andrii@kernel.org>,
        "kafai@fb.com" <kafai@fb.com>,
        "songliubraving@fb.com" <songliubraving@fb.com>,
        "yhs@fb.com" <yhs@fb.com>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "kpsingh@kernel.org" <kpsingh@kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding
 missing headers
Content-Language: en-US
To:     Sherry Yang <sherry.yang@oracle.com>
References: <20220210203049.67249-1-sherry.yang@oracle.com>
 <755ec9b2-8781-a75a-4fd0-39fb518fc484@collabora.com>
 <85DF69B3-3932-4227-978C-C6DAC7CAE64D@oracle.com>
 <66140ffb-306e-2956-2f6b-c017a38e18f8@collabora.com>
From:   Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <66140ffb-306e-2956-2f6b-c017a38e18f8@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote:
>>> "../../../../usr/include/" directory doesn't have header files if
>>> different output directory is used for kselftests build like "make -C
>>> tools/tests/selftest O=build". Can you try adding recently added
>>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion
>>> easy and correct for other build combinations as well?
>>>
>>>
>>
>> Hi Muhammad,
>>
>> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice 
>> work! I really appreciate you made headers inclusion compatible. However, 
>> my case is a little more complicated. It will throw warnings with -I, using 
>> -isystem can suppress these warnings, more details please refer to 
>> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/
>>
>> According to this case, do you think will it be better to export header path 
>> (KHDR_INCLUDES) without “-I”?
> Well said. I've thought about it and it seems like -isystem is better
> than -I. I've sent a patch:
> https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/
> I'm looking forward to discussion on it.
The patch has been accepted. It should appear in linux-next soon. You
should be able to use KHDR_INCLUDES easily now.

Thanks,
Usama