Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 15 Feb 2022 14:56:22 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Danilo Krummrich <danilokrummrich@dk-develop.de>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linus.walleij@linaro.org
Subject: Re: ps2-gpio: use ktime for IRQ timekeeping
Message-ID: <Ygwvls62iycw12z/@google.com>
References: <20220215160208.34826-1-danilokrummrich@dk-develop.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220215160208.34826-1-danilokrummrich@dk-develop.de>
Precedence: bulk

On Tue, Feb 15, 2022 at 05:02:04PM +0100, Danilo Krummrich wrote:
> Changes since v1
> ================
>   - add patch to refactor struct ps2_gpio_data for clear separation between
>     RX and TX
>   - make all variables for IRQ timekeeping per-port and initialize them in
>     ps2_gpio_open()
> 
> This patch series implements the usage of ktime for IRQ timekeeping to
> overcome:
> 
> (1) The resolution limitations of jiffies.
> (2) Potential spurious IRQs generated by gpio controllers.
> 
> Besides that, based on the newly implemented timekeeping, it fixes a wrongly
> suspected extra clock cycle for TX transfers and a race condition when
> starting an immediate TX transfer based on data received from an RX transfer.
> 
> Danilo Krummrich (4):
>       input: ps2-gpio: refactor struct ps2_gpio_data
>       input: ps2-gpio: use ktime for IRQ timekeeping
>       input: ps2-gpio: remove tx timeout from ps2_gpio_irq_tx()
>       input: ps2-gpio: don't send rx data before the stop bit
> 
>  drivers/input/serio/ps2-gpio.c | 180 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------
>  1 file changed, 116 insertions(+), 64 deletions(-)

Applied the lot, thank you.

-- 
Dmitry