Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Radhey Shyam Pandey <radheys@xilinx.com>
To:     "trix@redhat.com" <trix@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "gary@garyguo.net" <gary@garyguo.net>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "esben@geanix.com" <esben@geanix.com>,
        "huangguangbin2@huawei.com" <huangguangbin2@huawei.com>,
        "michael@walle.cc" <michael@walle.cc>,
        "moyufeng@huawei.com" <moyufeng@huawei.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "chenhao288@hisilicon.com" <chenhao288@hisilicon.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "prabhakar.mahadev-lad.rj@bp.renesas.com" 
        <prabhakar.mahadev-lad.rj@bp.renesas.com>,
        "yuehaibing@huawei.com" <yuehaibing@huawei.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: ethernet: xilinx: cleanup comments
Thread-Topic: [PATCH] net: ethernet: xilinx: cleanup comments
Thread-Index: AQHYIp7xXhjSSzjrMkGFnJCoRpO+AqyVC4Uw
Date:   Tue, 15 Feb 2022 20:12:57 +0000
Message-ID: <SA1PR02MB8560EDD6D9B6B2C26EB1B2A5C7349@SA1PR02MB8560.namprd02.prod.outlook.com>
References: <20220215190447.3030710-1-trix@redhat.com>
In-Reply-To: <20220215190447.3030710-1-trix@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6nthAKMNLrhZwASWsjqwpvIkiYfHTCOtvbU5inB+jHl69hrOrX21d+vzIclS?=
 =?us-ascii?Q?4IJcGYqge8di3JBMDLOv4qEdmCLnpjbFUf8MEJZY81wF/D35voXXIZkXMQOA?=
 =?us-ascii?Q?rRVUvDK3UktgoJmcIxNRIKp8iH8sbKmJNcppoSmowanlnqb35Bw2Bwbaxjdh?=
 =?us-ascii?Q?57vq2yfMcLdtzb2lOuvw4yg7Dd1O6W++syf9hHb2kX+kjLbVFZYF0T5VzvaA?=
 =?us-ascii?Q?EX3GzQTNKndrGtHo1KZor2Xa60w5otN5+Utn+8C2VwHqqTHCRsD5r5RjU0RQ?=
 =?us-ascii?Q?I60oO4EABwMB6+65cANyG/jWeY0MN2i53wwEuKVJXn4NNEewhJOeAWWV/l8+?=
 =?us-ascii?Q?R4MmNyMAug4nKXLhrZLM/Rr1Gk16/WOCuPJik2rNtqoDZDnQYh7LBugHCwDZ?=
 =?us-ascii?Q?6Apta2Tn9unGyMICB6LXY79hYgiDAnuVBhhR7/amNXxHOTfeG+tdApVjqQQ8?=
 =?us-ascii?Q?/KWthTMes+tRQSjQDInGSXI09i6BfQtdbLDY+reamcgvU+ma1ZkrSlRg1KQ5?=
 =?us-ascii?Q?/Aw+oxhO54heDbljnmZN/KLhYbniFjZ2j3SktulRzpwhAaXoTptiOYjfeIFn?=
 =?us-ascii?Q?ZwF6RYQd2WrGvCwmJfaiQ9S5Qem3VKNiP5Ti9tUjV/Cvdop5VfiOREViE8z3?=
 =?us-ascii?Q?mgZkJgJqvFnpE6fZMeSvzZa86OBJd0fMZOgGipFbFZDLRK9rV5w29ca6i0PD?=
 =?us-ascii?Q?5NwR+RGpjmOuo3YvND/E0mlbIuT3FWNTVO+gwEio6VGn1QMbxQs1HESkZlEm?=
 =?us-ascii?Q?jtc0B095RM1H0TnAzHDNyeSWH6eQN/h0PENH2HoA+eo5XQ4UBRWhYGqt+llm?=
 =?us-ascii?Q?0pEBGgDxEK31b4hp5wwW28j33gimCV0ltWA2SlrojNZqTLjKnxF3mWGQd8HJ?=
 =?us-ascii?Q?ELOAWhhaVn0QhXaN78/uVK68aBz5zepisBzb4lQ+uTeWoyOBA0Ah2XhPElBM?=
 =?us-ascii?Q?oz1MwnOGzuiHFE0OLyz2qeqdOA20BKhA7vBUATaxhsWjgnKEaln5cTudu5UF?=
 =?us-ascii?Q?Yx2fl0P7qXc+UFrY8qrJ9AF0bsL70vBJ1Avi1elEaLgIof6rAEjkcrQCs4jW?=
 =?us-ascii?Q?k4EofCG8zEJbx0MSfM8U5KueXwkbL7TgMkD6vXZ+5fh6Hufh/UFlc3fcnWLk?=
 =?us-ascii?Q?WA9gnDdbAZCQid9af4F/2fDf51A8Y9PKmSYXX8MUkCeHWZoT+pcoLw0nsEMd?=
 =?us-ascii?Q?92AyoerfSvlGI+C6enCYQ21AAIJYUKFEC9KViMJRCnkBpG1CnTrVRC9NkV0l?=
 =?us-ascii?Q?mmBhAD0cp3G386EkJefLgaqWSWV92rAfS2cNcYy55M9ge1itrk/iVFh/e+2x?=
 =?us-ascii?Q?YPhSMp3HtkfqHrQWpbjlWDKmkrpZTNZ0hv3b2QPgTRDnvwc/l0pm2MnlA9jM?=
 =?us-ascii?Q?d5HjUMon7JVMjr0evr+NpnEugCXA128cwA8sJMyunymoZHr21rTrO9hWumGk?=
 =?us-ascii?Q?zhxVeR45U6gMuQpf4UxpV6fdpoziEntrf5wObKnG7OVEVoGPYOGf41qRWhSu?=
 =?us-ascii?Q?x8fvau5xG5j8JCBGWseTQDG+lW+XGu5U/YqlHxA/w8CjQVRH+SCL/aWgyi0g?=
 =?us-ascii?Q?8QHAcETjQ+VVEuR8zUoVDeJqkWsWujzO2Gsw4IebJ+M4pchzObE6FPZAALYw?=
 =?us-ascii?Q?zo9pe+4qaFw5pssf7ebA1D4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR02MB8560.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e58c790f-ee81-4fd3-cb9c-08d9f0bf8ed9
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 20:12:57.5068
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OcSAv+UWdODxcotaXn5HBaiZbpHLokFw7+oqcBrVAUn1yuL6pWBazzUSeLun79jpYY7IfFrBVJV8eSvueTu4jg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4200
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Wednesday, February 16, 2022 12:35 AM
> To: davem@davemloft.net; kuba@kernel.org; Michal Simek
> <michals@xilinx.com>; Radhey Shyam Pandey <radheys@xilinx.com>;
> gary@garyguo.net; rdunlap@infradead.org; esben@geanix.com;
> huangguangbin2@huawei.com; michael@walle.cc; moyufeng@huawei.com;
> arnd@arndb.de; chenhao288@hisilicon.com; andrew@lunn.ch;
> prabhakar.mahadev-lad.rj@bp.renesas.com; yuehaibing@huawei.com
> Cc: netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Tom Rix <trix@redhat.com>
> Subject: [PATCH] net: ethernet: xilinx: cleanup comments
>=20
> From: Tom Rix <trix@redhat.com>
>=20
> Remove the second 'the'.
> Replacements:
> endiannes to endianness
> areconnected to are connected
> Mamagement to Management
> undoccumented to undocumented
> Xilink to Xilinx
> strucutre to structure
>=20
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Thanks!

> ---
>  drivers/net/ethernet/xilinx/Kconfig               | 2 +-
>  drivers/net/ethernet/xilinx/ll_temac.h            | 4 ++--
>  drivers/net/ethernet/xilinx/ll_temac_main.c       | 2 +-
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>  drivers/net/ethernet/xilinx/xilinx_emaclite.c     | 2 +-
>  5 files changed, 6 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/xilinx/Kconfig
> b/drivers/net/ethernet/xilinx/Kconfig
> index 911b5ef9e680..0014729b8865 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -1,6 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0-only  # -# Xilink device configuratio=
n
> +# Xilinx device configuration
>  #
>=20
>  config NET_VENDOR_XILINX
> diff --git a/drivers/net/ethernet/xilinx/ll_temac.h
> b/drivers/net/ethernet/xilinx/ll_temac.h
> index 4a73127e10a6..ad8d29f84be6 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac.h
> +++ b/drivers/net/ethernet/xilinx/ll_temac.h
> @@ -271,7 +271,7 @@ This option defaults to enabled (set) */
>=20
>  #define XTE_TIE_OFFSET			0x000003A4 /* Interrupt
> enable */
>=20
> -/**  MII Mamagement Control register (MGTCR) */
> +/**  MII Management Control register (MGTCR) */
>  #define XTE_MGTDR_OFFSET		0x000003B0 /* MII data */
>  #define XTE_MIIMAI_OFFSET		0x000003B4 /* MII control */
>=20
> @@ -283,7 +283,7 @@ This option defaults to enabled (set) */
>=20
>  #define STS_CTRL_APP0_ERR         (1 << 31)
>  #define STS_CTRL_APP0_IRQONEND    (1 << 30)
> -/* undoccumented */
> +/* undocumented */
>  #define STS_CTRL_APP0_STOPONEND   (1 << 29)
>  #define STS_CTRL_APP0_CMPLT       (1 << 28)
>  #define STS_CTRL_APP0_SOP         (1 << 27)
> diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c
> b/drivers/net/ethernet/xilinx/ll_temac_main.c
> index b900ab5aef2a..7171b5cdec26 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac_main.c
> +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
> @@ -1008,7 +1008,7 @@ static void ll_temac_recv(struct net_device *ndev)
>  		    (skb->len > 64)) {
>=20
>  			/* Convert from device endianness (be32) to cpu
> -			 * endiannes, and if necessary swap the bytes
> +			 * endianness, and if necessary swap the bytes
>  			 * (back) for proper IP checksum byte order
>  			 * (be16).
>  			 */
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index de0a6372ae0e..6eeaab77fbe0 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -537,7 +537,7 @@ static int __axienet_device_reset(struct axienet_loca=
l
> *lp)
>   * This function is called to reset and initialize the Axi Ethernet core=
. This
>   * is typically called during initialization. It does a reset of the Axi=
 DMA
>   * Rx/Tx channels and initializes the Axi DMA BDs. Since Axi DMA reset l=
ines
> - * areconnected to Axi Ethernet reset lines, this in turn resets the Axi
> + * are connected to Axi Ethernet reset lines, this in turn resets the
> + Axi
>   * Ethernet core. No separate hardware reset is done for the Axi Etherne=
t
>   * core.
>   * Returns 0 on success or a negative error number otherwise.
> diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> index 519599480b15..f65a638b7239 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
> @@ -498,7 +498,7 @@ static void xemaclite_update_address(struct net_local
> *drvdata,
>   * @dev:	Pointer to the network device instance
>   * @address:	Void pointer to the sockaddr structure
>   *
> - * This function copies the HW address from the sockaddr strucutre to th=
e
> + * This function copies the HW address from the sockaddr structure to
> + the
>   * net_device structure and updates the address in HW.
>   *
>   * Return:	Error if the net device is busy or 0 if the addr is set
> --
> 2.26.3