Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp565434pxb; Tue, 15 Feb 2022 22:15:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJype8/9qGumgMrQBClPQYdpHe3WsaLBk1iWsCm+Vukp7bBUrjHwM1WQmYy/pK6BAHSsLX0D X-Received: by 2002:a63:1601:0:b0:372:c9d1:ea94 with SMTP id w1-20020a631601000000b00372c9d1ea94mr1068924pgl.520.1644992108453; Tue, 15 Feb 2022 22:15:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644992108; cv=none; d=google.com; s=arc-20160816; b=F9fwm79G6v7O5SCr8AEaP4ggE0ioyyFM8yZYN8mKbnEebrmaMMB5mKEL6Id9YcRP+x SrmaYvX5R06+Ejus610xEDrsT/lLWyEfFmajXNzTt5TXfZVcctq8YtIJmM1omjVjiQ8f rxKfC9NFBN6H5KdZyAeAlKtcbjfHHru27eBi3Em+GwE7qpS9tyrfCsz+PCtcY3sllt3A Ng3CVKNwL0EEcT4qQ8jUADFTW4pqcsrrJ+YkY6FGPpEBsLHnZNbsfa8qzwyu9EIlb36a nH3gbTUxX6/bDw4LZ1pt4cFYATXG3ORWe//VmYoM/fW4mrtP4495nLiPZ71775au+fow lLRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dg8Bbqo8xrTURRSZr1gbJA1kXH+dR6Cfw/CPc1vh5OA=; b=RC+MWicZcoUvWAKII6Kp8Y7nEHJi1i/NrodVfwigWMnAgOBCljOscWFs0iBqtY6t+O plZVEexYJSMXjrGv1Z24OT1qxk5WhHLBEsrbOebfuIsmhLTIWjDARDue193tB4Q3HRyR WV0gcYQeYcP+lMS5hqX0ghRap7Y6QRldQfxmFrCSBY/Cv+Mb0QkigYhC8le1KDo+jRbf 1D8zcFLAUJgnR+kNxglLrgTMkn9N7EEuOZXXbPZ09f5wVcvLTv40rYUgtGRhasX/C7Xj xX1uhONJsOuLqa/hp0MjzH8UfsKIOFc1RKCgw4H3uj5k8kvbOggwb2jwmakX4b92qL/3 Rr8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=JWDZBiIv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id e11si13551042plh.240.2022.02.15.22.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 22:15:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@intel-com.20210112.gappssmtp.com header.s=20210112 header.b=JWDZBiIv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 540A219257D; Tue, 15 Feb 2022 22:14:12 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241145AbiBOWMB (ORCPT + 99 others); Tue, 15 Feb 2022 17:12:01 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243913AbiBOWL7 (ORCPT ); Tue, 15 Feb 2022 17:11:59 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2259C26579 for ; Tue, 15 Feb 2022 14:11:49 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id v4so539657pjh.2 for ; Tue, 15 Feb 2022 14:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dg8Bbqo8xrTURRSZr1gbJA1kXH+dR6Cfw/CPc1vh5OA=; b=JWDZBiIvBXJ+xyw/ssMlbLaY+HL0dGj6fRKKopQM/zAdOrPiEpBBbN0hIHBWPjTwv7 phWt006J1z/OGnlE0pZ1IAr4MBG61MAESVtMLCJJLdN03Qgw5ph3ybjNDcm5KLD4H/Bn dWXl2k4tg6j6b6r3iLke/JjQOqtAWGhWjmz+5X/AmIsbrRbdPwocCDW6gnbjWLV+8CGP 6XBgMZj2Vbtv7WovHLG8U9O+XTiFW1Esdpsq5PDNf7YwiqhlubKB9tjZcJrQw+cD3SxG 3OYRHWmQVG+2jcAaW9y66JUIwQHgJwy+IQgpES3zBB50Hn7Ps4/BtqJ1QikahSxmXMbV ZLTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dg8Bbqo8xrTURRSZr1gbJA1kXH+dR6Cfw/CPc1vh5OA=; b=SfDRmASEJXSCbwzGcWooxdtRuqEX0iu9lpZ9md94NtKADo5ESFtApw774ti4/35ICj 7GAnTusVNE4RqqFmC8nRKe/kWSEOEsRtHwNXIA7lGqQH3kUy5Fs0Yqrq8bf0mp0PRSy6 nFNZUTsP3ZxbTI1wyAUWoRPqk1TyGlM/uDKqjpSiOitptQq4z46SiDJxOTqfaU5KHV6S 8tcG8mSZtdkv41KjvEKf0boy8+62ZpJhRXudL6v4PesbOi/w4EcOplKiuYfal3euhjI9 5JAgZcQ6gz6W5TmziXVDWsN1lZB+0YG7KtBrDTJ0PX9tJzmdMDNTi+3XnYYh1I/RerDo O3iw== X-Gm-Message-State: AOAM5319cn7nxaquiOFEv6cGQERw6zXFGTkqBl09oU83gsG9YNj5xZJb D0bI4OeZCtlNDOVT64QvZ7rrq/arUOX2itIV5boyzw== X-Received: by 2002:a17:90a:e7cb:: with SMTP id kb11mr1046139pjb.220.1644963108677; Tue, 15 Feb 2022 14:11:48 -0800 (PST) MIME-Version: 1.0 References: <20220127124058.1172422-1-ruansy.fnst@fujitsu.com> <20220127124058.1172422-3-ruansy.fnst@fujitsu.com> In-Reply-To: <20220127124058.1172422-3-ruansy.fnst@fujitsu.com> From: Dan Williams Date: Tue, 15 Feb 2022 14:11:42 -0800 Message-ID: Subject: Re: [PATCH v10 2/9] mm: factor helpers for memory_failure_dev_pagemap To: Shiyang Ruan Cc: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan wrote: > > memory_failure_dev_pagemap code is a bit complex before introduce RMAP > feature for fsdax. So it is needed to factor some helper functions to > simplify these code. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Darrick J. Wong > Reviewed-by: Christoph Hellwig Looks good, Reviewed-by: Dan Williams