Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp565979pxb; Tue, 15 Feb 2022 22:16:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHJuAJgMUL6gguSaRZJkmrGc1VHzhAoGpw7OZjHD+tRZHLnGK6o3OR4ianQxAgDz9cXpA9 X-Received: by 2002:a17:902:e313:b0:14e:d912:3dca with SMTP id q19-20020a170902e31300b0014ed9123dcamr1173033plc.38.1644992174687; Tue, 15 Feb 2022 22:16:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1644992174; cv=none; d=google.com; s=arc-20160816; b=SLTpG8FDsPnd3d8vr7ZqZf3rUMAYdv7GoJkl9wHUIKvo23hAeApYjQl0iN6T2PKzWV CRDvSVOMpP1B/Bv3qYu8uoOxGkHiacotRMkjgBgdVAGUMD4DODBCacJhute6U0SUfZtC tcEzVbKsBAUEIyi2cI3/+XE7fs1awc8eCCgKWLZDh5KX9AXNmAxbk+DsujV23tPImLZC AtD/+cS06uSBybNmZCw0y8h7pO/ISLCYZwJXOURGM+zJKJKoaY7ppAimunimpu6mTbya HKupwA3n1JCIK+7HpvRgvzF1i5FW1pZXplKIjBvTVLLbPTm7GKtii4BkU71Co/yi4U3x NhhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:reply-to:from:date:dkim-signature; bh=LZ4NrcBJt8HIN1i2uGZd1xJtfMmLm2NJSjUZOXubBM8=; b=j4U8dIsHYJhvSCJ8e7wZA5jLRSA7fq23HOii0hj0JQK9w0ZaU6CLhMGdZCSBn7qFDl Fg5gXkNkJVqJgt8afbaIo6WUYpk4yJtILZrS9lQFruh0v6rD4Tpf9y6vvQWBP4X/emEY EbbIxhMbS2190qrnjd0v6Pl449iClhyeqdwP/F6ieB2QbxpPHd6UdkZ3CTkILi3HpMNs IiQTfdTI0aF7LelaoSpDQ7rcB6b4h268t4Q5iXs1HQbzrk30asP02/wlR7Q/pnl76k1V QDwO6W0+UWyavzUER8sALqWAs+BzOMygP+wOrah0ZuZBS02h0r/LAokPClTno2a+iAjf 1TXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@panix.com header.s=panix header.b=dSp2aF6+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id u62si4634843pgd.482.2022.02.15.22.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 22:16:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail header.i=@panix.com header.s=panix header.b=dSp2aF6+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BA97D195072; Tue, 15 Feb 2022 22:15:58 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344702AbiBPGAt (ORCPT + 99 others); Wed, 16 Feb 2022 01:00:49 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:33326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344695AbiBPGAs (ORCPT ); Wed, 16 Feb 2022 01:00:48 -0500 Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E311111FB3; Tue, 15 Feb 2022 22:00:36 -0800 (PST) Received: from [192.168.55.37] (ip68-111-137-238.sd.sd.cox.net [68.111.137.238]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4Jz6km67fwz193F; Wed, 16 Feb 2022 01:00:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1644991235; bh=WHDwGF8eJzpXUzB5NB3DZN9sBFwhmfASyytRMPy2sXo=; h=Date:From:Reply-To:To:cc:Subject:In-Reply-To:References; b=dSp2aF6+xDjkstjilYz3T6w4LWOK9SOB5+r8ZpyV2wGPkvxn2BKWFrBvF4c4duUVe /h4ekfys1Xml1YC392ReI4WGz4Gv9N8EjTKlnBd3CEP2LcF+MkCl6SONKkH0a5xvXv SKuwsL19SVEEopnrtRGTK+EefnRV188F6ztDdGE0= Date: Tue, 15 Feb 2022 22:00:31 -0800 (PST) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: Vidya Sagar cc: Bjorn Helgaas , bhelgaas@google.com, lorenzo.pieralisi@arm.com, hkallweit1@gmail.com, wangxiongfeng2@huawei.com, mika.westerberg@linux.intel.com, kai.heng.feng@canonical.com, chris.packham@alliedtelesis.co.nz, yangyicong@hisilicon.com, treding@nvidia.com, jonathanh@nvidia.com, abhsahu@nvidia.com, sagupta@nvidia.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kthota@nvidia.com, mmaddireddy@nvidia.com, sagar.tv@gmail.com, "Kenneth R. Crudup" Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume In-Reply-To: <0ccd43af-0293-521b-86d3-ea2ea1c70e5c@nvidia.com> Message-ID: <75a48fb6-3913-ccaf-3c-6d41bbbda533@panix.com> References: <20220207163332.GA397884@bhelgaas> <79a41832-12e2-2ed-f3af-da3bac90d941@panix.com> <3ca14a7-b726-8430-fe61-a3ac183a1088@panix.com> <0ccd43af-0293-521b-86d3-ea2ea1c70e5c@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Feb 2022, Vidya Sagar wrote: > I see that the ASPM-L1 state of Realtek NIC which was in disabled state before > hibernate got enabled after hibernate. That's actually my SD-Card reader; there's a good chance the BIOS does "something" to it at boot time, as it's possible to boot from SD-Card on my laptop. > This patch doesn't do anything to LnkCtl register which has control for ASPM L1 > state. > Could you please check why ASPM L1 got enabled post hibernation? I wouldn't know how to do that; if you're still interested in that let me know what to do to determine that. -Kenny -- Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA